First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 155492
Alias:
Product:
Component:
Status: ASSIGNED
Resolution:
Assigned To: LDAP Herd <ldap-bugs@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Heath Caldwell <hncaldwell@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
nss_getgrent_skipmembers.patch Patch to add option to skip requesting member attributes for group lookups. patch Heath Caldwell 2006-11-17 08:39 0000 7.70 KB Details | Diff
nss_ldap-max_group_depth.patch Patch to add nss_max_group_depth config option. patch Heath Caldwell 2007-02-06 14:59 0000 6.75 KB Details | Diff
nss_ldap-257-nss_max_group_depth.patch Fixed nss_ldap-257-nss_max_group_depth.patch patch Heath Caldwell 2007-12-14 23:24 0000 3.88 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 155492 depends on: Show dependency tree
Show dependency graph
Bug 155492 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-11-17 08:37 0000
In situations with very large groups (thousands to tens of thousands of users),
there is an unacceptable delay when looking up the group which makes nss_ldap
essentially unusable.

Paul Henson has written a patch to allow for a nss_getgrent_skipmembers
parameter in ldap.conf which, if enabled, will cause nss_ldap to not request
member attributes for group lookups.

Luke Howard (the maintainer of nss_ldap) has agreed to look into including the
patch into the official source, but we would like to see the patch go into
portage in the interim.

------- Comment #1 From Heath Caldwell 2006-11-17 08:39:45 0000 -------
Created an attachment (id=102208) [edit]
Patch to add option to skip requesting member attributes for group lookups.

------- Comment #2 From Robin Johnson 2006-12-15 19:32:39 0000 -------
coming soon after 253 is in stable.

------- Comment #3 From Heath Caldwell 2007-02-05 20:30:17 0000 -------
It looks like 253 has been stable for a while.  Any word on when we can look
forward to seeing this feature incorporated?

------- Comment #4 From Robin Johnson 2007-02-06 04:51:02 0000 -------
in cvs now on top of 254 which has some other group optimizations. 253 is still
pending on mips for stable.

------- Comment #5 From Heath Caldwell 2007-02-06 14:58:47 0000 -------
Ok, great.  On the topic of other group optimizations, here is another patch
that adds the ability to configure the maximum number of nested groups queried
for.  It can reduce some unnecessary traffic.  Can you add it as well?

------- Comment #6 From Heath Caldwell 2007-02-06 14:59:31 0000 -------
Created an attachment (id=109329) [edit]
Patch to add nss_max_group_depth config option.

------- Comment #7 From Robin Johnson 2007-09-18 23:18:37 0000 -------
in 257 in CVS now.

------- Comment #8 From Heath Caldwell 2007-12-14 23:22:25 0000 -------
The re-diff of the nss_max_group_depth patch that is in portage is missing the
hunk that sets _nss_ldap_max_group_depth to what was read from the config.  A
fixed patch to follow.

------- Comment #9 From Heath Caldwell 2007-12-14 23:24:00 0000 -------
Created an attachment (id=138522) [edit]
Fixed nss_ldap-257-nss_max_group_depth.patch

------- Comment #10 From Robin Johnson 2008-10-14 10:36:30 0000 -------
hncaldwell: please respin against 262, and state if it's to supplement or
replace the existing space.

------- Comment #11 From Heath Caldwell 2008-10-21 20:02:25 0000 -------
I looked into rewriting the patch to not use a global variable (upstream
wouldn't accept it that way), but it would be such a mess to do it without one
that I don't think that it is worth the trouble.  I am curious why a global
variable isn't ok since it is currently a #define constant, but I never heard
back.

The reason that I wrote the patch in the first place was so that I could
disable querying for nested groups, which gained a slight amount of efficiency,
and I figured that others would like the ability to configure the max depth. 
Since the gained efficiency is pretty insignificant, the only reason I see to
go through the mess of passing another value down through all of the functions
necessary would be if someone needed it to be deeper than the hardcoded 16 (and
even then, it would be easier to just up that).

Since the skip members patch that this bug was initially made for is now
included upstream, I think it is just easiest to close this bug (unless there
is someone out there who really, really wants the max group depth to be
configurable).

First Last Prev Next    No search results available      Search page      Enter new bug