Bugzilla Bug 155152

media-sound/lastfm-ripper-1.2.1-r2 broken by URL-Handling-fix.patch



 media-sound/lastfm-ripper-1.2.1-r1:


last.fm-ripper -d -u XXXXXX -p XXXXXX -n
lastfm://play/tracks/39388027,23780966,26783726,51650057,15337063,30466775,34290133,6896710,15427
438,8654758,30466777,23781107,30466774,7262205,14207013,14209212,30466776,25348164,6896709,8653942,39388027

Now trying to play URL
lastfm://play/tracks/39388027,23780966,26783726,51650057,15337063,30466775,34290133,6896710,15427438,8654758,30466777,23781107,30466774,7262205,14207013,14209212,30466776,25348164,6896709,8653942,39388027
for user ohrc with pass lastfm - md5hash: cfabf0e50837b11fd6ab4aafdfc9fc71

trying to log in
reading from socket
reading login response

set $session="dc14094e038780d1741e9104fbf00fbc"
set $mp3_host="87.117.229.83"
DATA_LENGTH: 0  TRACK:   ARTIST:   ALBUM:
ast.mp3?Session=dc14094e038780d1741e9104fbf00fbc"
trying to tune station from ws.audioscrobbler.com
reading from socket
reading tune response
DATA_LENGTH: 0  TRACK:   ARTIST:   ALBUM: 
requesting streaming data from 87.117.229.83
reading from socket
reading mp3 data
writing to sockets
DATA_LENGTH: 141  TRACK:   ARTIST:   ALBUM: reading from socket
reading mp3 data
found new track

writing to sockets



 media-sound/lastfm-ripper-1.2.1-r2:


last.fm-ripper -d -u XXXXXX -p XXXXX -n
lastfm://play/tracks/39388027,23780966,26783726,51650057,15337063,30466775,34290133,6896710,15427438,8654758,30466777,23781107,30466774,7262205,14207013,14209212,30466776,25348164,6896709,8653942,39388027

Now trying to play URL
lastfm://play/tracks/39388027,23780966,26783726,51650057,15337063,30466775,34290133,6896710,15427438,8654758,30466777,23781107,30466774,7262205,14207013,14209212,30466776,25348164,6896709,8653942,39388027
for user ohrc with pass lastfm - md5hash: cfabf0e50837b11fd6ab4aafdfc9fc71

trying to log in
reading from socket
reading login response

set $session="dc14094e038780d1741e9104fbf00fbc"
set $mp3_host="streamer2.last.fm"
DATA_LENGTH: 0  TRACK:   ARTIST:   ALBUM:
80/last.mp3?Session=dc14094e038780d1741e9104fbf00fbc"
trying to tune station from ws.audioscrobbler.com
reading from socket
reading tune response
DATA_LENGTH: 0  TRACK:   ARTIST:   ALBUM: mp3_host=, mp3_url=/

requesting streaming data from 
could not initialize mp3 socket

Created an attachment (id=102962) [details]
Bugfix for URL-Handling-fix.patch

Please apply this one *after* the original URL-Handling-fix.patch.

Thank you. I added your fix to -r3 and removed the buggy -r2.

Still can't get it to work, just installed r3. Anything else besides the patch,
that has to be done?

(In reply to comment #3)
> Still can't get it to work, just installed r3. Anything else besides the patch,
> that has to be done?
> 

No, it should work pretty out of the box. The problem lies somewhere else.
Check this out:

<0> $ last.fm-ripper -u user -p pass -a morcheeba

This is the lastfm server response:

HTTP/1.0 200 OK
Date: Wed, 04 Mar 2009 17:28:59 GMT
Server: Apache/1.3.39 (Unix)
X-Proxy-Fix-Up: headers fixed up
X-Web-Node: www135
Set-Cookie: LastUser=91a0b317fccbac1603499f8589b5b7ef; expires=Sat, 27-Feb-2010
17:28:59 GMT; path=/; domain=.audioscrobbler.com
Set-Cookie: Session=7683a52f94001381f48d0933a00cfd27; expires=Fri, 03-Apr-2009
17:29:00 GMT; path=/; domain=.audioscrobbler.com
Connection: close
Content-Type: text/plain;charset=utf-8

session=7683a52f94001381f48d0933a00cfd27
stream_url=http://195.24.233.49:80/last.mp3?Session=7683a52f94001381f48d0933a00cfd27
subscriber=0
framehack=0..
base_url=ws.audioscrobbler.com
base_path=/radio
info_message=
fingerprint_upload_url=http://ws.audioscrobbler.com/fingerprint/upload.php
permit_bootstrap=1
DATA_LENGTH: 0  TRACK:   ARTIST:   ALBUM: 

This is the parsed streaming url. Sounds good, right? (see above):

http://195.24.233.49:80/last.mp3?Session=7683a52f94001381f48d0933a00cfd27

Now, trying to open the above url in firefox results in a connection reset
(same as the "could not initialize.." you are experiencing right now).

Maybe wireshark could help, but I've almost no time to do that right now;
sorry.

I can verify this script does not work. After emerging (no useflags set), I do:

last.fm-ripper -u XXXXX -p XXXXX -a XXXXX -d

and I get:

Now trying to play URL lastfm://artist/XXXXX/similarartists for user XXXXX with
pass XXXXX - md5hash: f1bdb2b35831c3e76ba14b1d565447b6

trying to log in
reading from socket
reading login response

set $session="f7962e49461b2b75f9d2fab4e9da61d4"
set $mp3_host="XXX.XX.XXX.XX"
DATA_LENGTH: 0  TRACK:   ARTIST:   ALBUM:
ast.mp3?Session=f7962e49461b2b75f9d2fab4e9da61d4"
trying to tune station from ws.audioscrobbler.com
reading from socket
reading tune response
DATA_LENGTH: 0  TRACK:   ARTIST:   ALBUM: mp3_host=XXX.XX.XXX.XX,
mp3_url=/last.mp3?Session=f7962e49461b2b75f9d2fab4e9da61d4

requesting streaming data from XXX.XX.XXX.XX
could not initialize mp3 socket

--- I have substitued the IPs and users/pass with XXXXX. Also note that if I
try to go to the URL
http://XXX.XX.XXX.XX:80/last.mp3/Session=f7962e49461b2b75f9d2fab4e9da61d4 in my
browser, I get a Could not connect to remote server.

Created an attachment (id=186519) [details]
Adapt to new API

Replace last.fm-ripper with the attached one to use the new last.fm API

I made some more changes in last.fm-ripper-2.0.1 .
I will describe them and continue required discussions in bug #263804 as this
seems more appropriate to me.