Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 154932
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Sound Team <sound@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Alessio Cassibba (X-Drum) <swapon@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
ebuild_1.0.7.diff ebuild patch from 1.0.7 patch Alessio Cassibba (X-Drum) 2006-11-12 13:37 0000 1.95 KB Details | Diff
ebuild.patch corrected patch patch Paweł Hajdan jr 2007-01-23 19:37 0000 1.60 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 154932 depends on: Show dependency tree
Bug 154932 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-11-12 13:36 0000
some ebuild enhancements:
-fixed jack support (dep use)
-fixed use handling

------- Comment #1 From Alessio Cassibba (X-Drum) 2006-11-12 13:37:50 0000 -------
Created an attachment (id=101778) [details]
ebuild patch from 1.0.7

ebuild 1.0.7 patch, some enhancements

------- Comment #2 From Diego E. 'Flameeyes' Pettenò 2006-11-13 07:52:25 0000 -------
Thanks for the patch, but it's not yet ready for commit:

- when enabling lash and not enabling alsa, the ebuild should not die (don't
tell me, I'd prefer it to die, but that's the policy), so it should indeed
warn, but not fail, instead it should either enable ALSA silently (preferred)
or disable lash altogether;
- no need for the double flags on use_enable when they are the same;
- is static useflag used to generate static libraries or static executable? if
it's for static libraries, remove the useflag and let it always build static
libraries aside from shared ones;
- coreaudio is OSX stuff, leave it disabled until the ebuild is picked up by
the OSX guys.

------- Comment #3 From Paweł Hajdan jr 2007-01-23 19:37:07 0000 -------
Created an attachment (id=107926) [details]
corrected patch

------- Comment #4 From Paweł Hajdan jr 2007-01-23 19:41:23 0000 -------
Looks like the reporter didn't provide corrected version of the patch, so I
created my own.

Notes:
- preserved most ideas of original patch
- ebuild doesn't die, only prints a warning
- corrected double flags in use_enable
- static USE-flag was there before; didn't touch it
- removed coreaudio from previous patch
- looks like the ./configure script ignores use_enable for alsa and oss
- I'm not sure about --disable-ladcca option passed to econf; it was in the
previous patch so I preserved it

------- Comment #5 From Diego E. 'Flameeyes' Pettenò 2007-06-20 14:29:24 0000 -------
I've reworked the patch a bit, cleaned up the ebuild a bit, and committed it in
1.0.7a.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug