Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 154504 - media-video/mplayer-1.0_rc1 ebuild defines the wrong skin directory
Summary: media-video/mplayer-1.0_rc1 ebuild defines the wrong skin directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
: 155357 156085 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-11-08 14:17 UTC by baru reddy
Modified: 2006-11-24 00:52 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
install skin to correct directory (install-skin.diff,739 bytes, patch)
2006-11-14 02:22 UTC, Matthias Schwarzott 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description baru reddy 2006-11-08 14:17:48 UTC 
The ebuild for mplayer-1.0_rc1 defines the wrong skin directory when it installs the package. Instead of: 

        dodir /usr/share/mplayer/skin
        cp -r ${WORKDIR}/Blue ${D}/usr/share/mplayer/skin/default || die

it should be:

        dodir /usr/share/mplayer/skins
        cp -r ${WORKDIR}/Blue ${D}/usr/share/mplayer/skins/default || die

The default directory for skins is /usr/share/mplayer/skins. This is not a major problem, but without this fix, if you use gmplayer with the default skin, it will not startup.

BR
Comment 1 Matthias Schwarzott gentoo-dev 2006-11-14 02:07:38 UTC 
This bug is valid.

Looking at the code (Gui/interface.c):
--CUT-----------------------------------------------
 skinDirInHome=get_path("skins");
 skinDirInHome_obsolete=get_path("Skin");
 skinMPlayerDir=MPLAYER_DATADIR "/skins";
 skinMPlayerDir_obsolete=MPLAYER_DATADIR "/Skin";
--CUT-----------------------------------------------
Comment 2 Matthias Schwarzott gentoo-dev 2006-11-14 02:22:42 UTC 
Created attachment 101899 [details, diff]
install skin to correct directory

This is the change to the ebuild as a patch.
Comment 3 Luca Barbato gentoo-dev 2006-11-14 04:49:25 UTC 
Fixed, zzam, next time feel free to commit it and/or ping me on irc if I don't reply.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2006-11-16 07:17:27 UTC 
*** Bug 155357 has been marked as a duplicate of this bug. ***
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2006-11-24 00:52:49 UTC 
*** Bug 156085 has been marked as a duplicate of this bug. ***