Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 154353 - Add jpeg2k use flag to media-libs/netpbm
Summary: Add jpeg2k use flag to media-libs/netpbm
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-07 05:24 UTC by Petteri Räty (RETIRED)
Modified: 2006-11-07 12:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against netpbm-10.36.ebuild (netpbm-10.36.patch,987 bytes, patch)
2006-11-07 05:41 UTC, Petteri Räty (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty (RETIRED) gentoo-dev 2006-11-07 05:24:35 UTC
Like the other use flags, jasper is not mandatory so I added a jpeg2k use flag for it.
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2006-11-07 05:41:34 UTC
Created attachment 101391 [details, diff]
Patch against netpbm-10.36.ebuild
Comment 2 Luca Barbato gentoo-dev 2006-11-07 06:18:35 UTC
Looks fine, please commit =)
Comment 3 SpanKY gentoo-dev 2006-11-07 10:31:58 UTC
that isnt how it works ... netpbm will use the bundled jasper version of you set that value to NONE and that certainly is not correct
Comment 4 Petteri Räty (RETIRED) gentoo-dev 2006-11-07 12:04:00 UTC
(In reply to comment #3)
> that isnt how it works ... netpbm will use the bundled jasper version of you
> set that value to NONE and that certainly is not correct
> 

Please read converter/other/jpeg2000/Makefile again. Relevant code:
ifneq ($(JASPERHDR_DIR),NONE)
  ifneq ($(JASPERLIB_USE),NONE)
    BINARIES = pamtojpeg2k jpeg2ktopam
  endif
endif
Comment 5 Petteri Räty (RETIRED) gentoo-dev 2006-11-07 12:40:13 UTC
(In reply to comment #3)
> that isnt how it works ... netpbm will use the bundled jasper version of you
> set that value to NONE and that certainly is not correct
> 

I verified this with rm -r libjasper and ebuild netpbm-10.36.ebuild compile worked just fine. install had problems because of the SUBDIRS variable. I could of course send a patch upstream that disables the libjasper SUBDIR when jasper support is off and then we can just rm the internal copy. Any way this bug can be marked fixed.w