Bugzilla Bug 154075

If I use xf86-input-evdev-1.1.4 as my keyboard driver and do something that
triggers the bell ("emerge beep && beep" works as a testcase) my X server
crashes. As far as I can tell that is because evdev_key.c calls:

  xf86OSRingBell(percent, ctrl->bell_pitch, ctrl->bell_duration);

which does not exist yet:
evdev_key.c:245: warning: implicit declaration of function 'xf86OSRingBell'

Commenting out that line stops the crash.

It looks like it was added to the server three days ago:

http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=commitdiff;h=81728558a044fdde0e1d63da7b6314755f77296e

and my xorg-server is definitely older than that :)

Portage 2.1.2_rc1-r3 (default-linux/x86/2006.1, gcc-4.1.1, glibc-2.5-r0,
2.6.18-gentoo-r1-m1 i686)
=================================================================
System uname: 2.6.18-gentoo-r1-m1 i686 AMD Athlon(tm) XP 2600+
Gentoo Base System version 1.12.6
Last Sync: Unknown
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.3.5-r3, 2.4.3-r4, 2.5-r1
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     [Not Present]
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.14
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r1
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-ggdb -O2 -march=athlon-xp -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shu
tdown /usr/share/X11/xkb /usr/share/config"                                    
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms
/ /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/texmf/web2c"              
CXXFLAGS="-ggdb -O2 -march=athlon-xp -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig candy collision-protect cvs metadata-transfer sandbox
sfper
ms sign splitdebug strict stricter test userpriv usersandbox verify-rdepend"   
GENTOO_MIRRORS="http://ftp.easynet.nl/mirror/gentoo/"
LANG="en_US.UTF-8"
PKGDIR="/var/tmp/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress 
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude=/distfiles --exclude=/local --exclude=/packages"                     
             PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/cvsco/gentoo-x86"
PORTDIR_OVERLAY="/usr/local/portage/mzbot-overlay
/usr/local/portage/twisted-div
mod-overlay /usr/local/portage/setuptools-overlay /usr/local/portage/private
/usr/local/portage/bzr-overlay /usr/local/portage/pyatlantic-overlay"          
   SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 3dnow 3dnowex 3dnowext X a52 aac alsa ansi apache2 bonobo
browserplugin
 bzip2 cairo canvas ccache cdr crypt cups dbus dri elibc_glibc emacs faad fbcon
firefox flac gif glibc-omitfp glitz glut gmp gnome gpgme gstreamer gstreamer010
gtk gzip-el hal imap input_devices_evdev javascript jit jpeg kdeenablefinal
kdehiddenvisibility kernel_linux kqemu libcaca libnotify mad maildir md5sum mmx
mmx2 mmxext mng mozdevelop moznocompose moznoirc moznomail mozsvg mpeg musepack
nautilus ncurses nethack network new-login nls nntp no-helpbrowser no-old-linux
nonfsv4 nptl nptlonly nsplugin numeric offensive ogg oggvorbis opengl pam pdf
png preview-latex python qemu-fast quicktime readline real rtc softmmu spell
splash sqlite sse ssl startup-notification svg symlink test tetex theora
toolkit-scroll-bars truetype truetype-fonts unicode userland_GNU userlocales
video_cards_radeon vorbis win32codecs wxwindows xcomposite xinerama xml2 xorg
xv zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS, LINGUAS,
MA
KEOPTS, PORTAGE_RSYNC_EXTRA_OPTS

Thanks for finding this - I've alerted upstream about the issue.

I'll look at putting a temporary solution into the tree, since this is quite a
simple fix.

I had this problem as well.  Thanks for finding the solution... 

Interestingly, backing off to evdev-1.1.2-r2 failed with a "SendCoreEvents" and
"DontSendCoreEvents" as well.

So I'm evdevless until this gets fixed.

W

whoops I shoulda been more specific about my problem rolling back to 1.1.2-r2

evdev.c line 235 has those functions undeclared (in function EvDevSwitchMode)

Dunno why this previously stable package is suddenly crashing for me.  Anyway
if this package gets fixed in 1.1.4 it shouldn't be an issue for me.

W

Created an attachment (id=101251) [details]
1.1.4-fix_compatibility.patch

Please give this patch a whirl.

Note that this patch is a bit of a hack - hopefully upstream will have
something better soon.

Patch seems to work fine (no crashing).

Alright.

I've put it in the tree as 1.1.4-r1.  I'm pretty confident it'll hold the fort
until upstream provides a new version.

This bug seems to still exist in 1.1.5

evdev_key.c: In function 'EvdevKbdBell':
evdev_key.c:245: warning: implicit declaration of function 'xf86OSRingBell'

I can't reopen this bug, so I'll create a new one.

W