Bugzilla Bug 153656

This version of asterisk should have dev-db/libpq in its DEPEND even if
postgres USE flag is disabled:

gcc -march=pentium2 -O3 -pipe -fomit-frame-pointer  -pipe  -Wall
-Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations  -Iinclude
-I../include -D_REENTRANT -D_GNU_SOURCE  -march=pentium2 -O3 -pipe
-fomit-frame-pointer         -fomit-frame-pointer  -fPIC
-I/usr/include/postgresql   -c -o cdr_pgsql.o cdr_pgsql.c
cdr_pgsql.c:43:22: error: libpq-fe.h: No such file or directory
cdr_pgsql.c:67: error: expected 

This version of asterisk should have dev-db/libpq in its DEPEND even if
postgres USE flag is disabled:

gcc -march=pentium2 -O3 -pipe -fomit-frame-pointer  -pipe  -Wall
-Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations  -Iinclude
-I../include -D_REENTRANT -D_GNU_SOURCE  -march=pentium2 -O3 -pipe
-fomit-frame-pointer         -fomit-frame-pointer  -fPIC
-I/usr/include/postgresql   -c -o cdr_pgsql.o cdr_pgsql.c
cdr_pgsql.c:43:22: error: libpq-fe.h: No such file or directory
cdr_pgsql.c:67: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or
‘__attribute__’ before ‘*’ token
cdr_pgsql.c:68: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or
‘__attribute__’ before ‘*’ token
cdr_pgsql.c: In function ‘pgsql_log’:
cdr_pgsql.c:82: error: ‘conn’ undeclared (first use in this function)
cdr_pgsql.c:82: error: (Each undeclared identifier is reported only once
cdr_pgsql.c:82: error: for each function it appears in.)
cdr_pgsql.c:82: warning: implicit declaration of function ‘PQsetdbLogin’
cdr_pgsql.c:83: warning: implicit declaration of function ‘PQstatus’
cdr_pgsql.c:83: error: ‘CONNECTION_BAD’ undeclared (first use in this
function)
cdr_pgsql.c:86: warning: implicit declaration of function ‘PQerrorMessage’
cdr_pgsql.c:86: warning: assignment makes pointer from integer without a cast
cdr_pgsql.c:98: warning: implicit declaration of function ‘PQescapeString’
cdr_pgsql.c:134: error: ‘CONNECTION_OK’ undeclared (first use in this
function)
cdr_pgsql.c:138: warning: implicit declaration of function ‘PQreset’
cdr_pgsql.c:143: warning: assignment makes pointer from integer without a cast
cdr_pgsql.c:151: error: ‘result’ undeclared (first use in this function)
cdr_pgsql.c:151: warning: implicit declaration of function ‘PQexec’
cdr_pgsql.c:152: warning: implicit declaration of function ‘PQresultStatus’
cdr_pgsql.c:152: error: ‘PGRES_COMMAND_OK’ undeclared (first use in this
function)
cdr_pgsql.c:153: warning: implicit declaration of function
‘PQresultErrorMessage’
cdr_pgsql.c:153: warning: assignment makes pointer from integer without a cast
cdr_pgsql.c:164: warning: assignment makes pointer from integer without a cast
cdr_pgsql.c: In function ‘my_unload_module’:
cdr_pgsql.c:184: error: ‘conn’ undeclared (first use in this function)
cdr_pgsql.c:185: warning: implicit declaration of function ‘PQfinish’
cdr_pgsql.c: In function ‘process_my_load_module’:
cdr_pgsql.c:292: error: ‘conn’ undeclared (first use in this function)
cdr_pgsql.c:293: error: ‘CONNECTION_BAD’ undeclared (first use in this
function)
cdr_pgsql.c:297: warning: assignment makes pointer from integer without a cast
make[1]: *** [cdr_pgsql.o] Error 1
make[1]: Leaving directory
`/var/tmp/portage/asterisk-1.2.13/work/asterisk-1.2.13/cdr'
make: *** [subdirs] Error 1

!!! ERROR: net-misc/asterisk-1.2.13 failed.
Call stack:
  ebuild.sh, line 1546:   Called dyn_compile
  ebuild.sh, line 937:   Called src_compile
  asterisk-1.2.13.ebuild, line 287:   Called die

!!! Make failed
!!! If you need support, post the topmost build error, and the call stack if
relevant.

Another issue would be the futile mysql flag. Apparently the mysql support has
been removed because MySQL switched to GPL.
Now MySQL is supported only through ODBC.

feel free to fix those issues yourself and fix th

fixed in 1.2.13-r1

*** Bug 154929 has been marked as a duplicate of this bug. ***

I filled (oposite) bug 154929 ...

1. I had no problems to emerge net-misc/asterisk-1.2.13, although I hadn't
libpq installed on my system.

2. I really can't see any reason, why asterisk should ALWAYS depend on libpq.

IMHO this (153656) bug is FALSE and should be revisited/checked.

*** Bug 154929 has been marked as a duplicate of this bug. ***

Oh noes, t3h dependency!!!111! 

Please save the output of the following command and send me to my personal
email address:

  ebuild asterisk-1.2.13.ebuild compile &> /tmp/asterisk.out

Of course, you should not have libpq installed on your system.

Hi Alin,

still doesn't know, where the problem is ?
If not, I suggest to check your libraries for orphant files ...
*'s configure script probable finds it and gets confused.

BTW, I emerged asterisk-1.2.13 on more than 5 systems, no one needs libpq.

noro

I didn' found time to take care of this bug. Patience, my friend...

Fixed without rev bumping by removing libpq dependency.

You were right. I had some /usr/include/postgresql leftovers.
However, the Makefile is wrong. It should include Postgres support if and only
if libpq-fe.h is found. I will submit a bug to upstream regarding this issue.

IMO it should include Postgres support if and only if "postgres" use flag is
set,
regardless of libraries or their headers (proper or orphant).

Of course, but asterisk doesn't have a ./configure script and therefore it
cannot make full use of its USE flags.