Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 153185 - net-www/netscape-flash-9.0.21.55 - change use flag for gflashplayer
Summary: net-www/netscape-flash-9.0.21.55 - change use flag for gflashplayer
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-28 15:35 UTC by Denilson Sá Maia
Modified: 2006-11-14 15:37 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
media-video/flashplayer-9.0.21.55.diff (flashplayer.diff,1.63 KB, patch)
2006-10-31 07:48 UTC, MATSUU Takuto (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denilson Sá Maia 2006-10-28 15:35:13 UTC
Looking at the new netscape-flash/netscape-flash-9.0.21.55 ebuild, I find the gtk useflag is used to download or not the stand-alone flash player, but it is not used for deps.

Does flash player plugin (not the stand-alone) require gtk? If not, why gtk is always required? If yes, then gtk useflag is improperly used to select if stand-alone version should or not be installed.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-10-28 15:50:47 UTC
$ scanelf -n /opt/netscape/plugins/libflashplayer.so
 TYPE   NEEDED FILE 
ET_DYN libdl.so.2,libpthread.so.0,libX11.so.6,libXext.so.6,libXt.so.6,libfreetype.so.6,libfontconfig.so.1,libgtk-x11-2.0.so.0,libgobject-2.0.so.0,libglib-2.0.so.0,libm.so.6,libc.so.6 /opt/netscape/plugins/libflashplayer.so 
Comment 2 Denilson Sá Maia 2006-10-28 16:42:15 UTC
As I said, if gtk+ is really a dependency, why there is a "gtk" useflag?

If we want stand-alone player optional, we need another useflag (like "standalong"), and not gtk.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-10-28 16:59:10 UTC
(In reply to comment #2)
> As I said, if gtk+ is really a dependency, why there is a "gtk" useflag?

Because it installs gtk GUI player? How about that we make it not optional instead of inventing yet another redundant use flag?
Comment 4 Denilson Sá Maia 2006-10-28 17:06:45 UTC
(In reply to comment #3)
> Because it installs gtk GUI player?

Yes, but gtk useflag does mean (at least most of times) optional support for gtk. If gtk support is not optional, it is not appropriate.

> How about that we make it not optional
> instead of inventing yet another redundant use flag?

I see no problem doing that.

If people *really* want it optionally installed, either stand-alone should be an additional package (so, splitting this one in plugin and standalone packages), or they should use a portage overlay. I think the later is easier.
Comment 5 Carsten Lohrke (RETIRED) gentoo-dev 2006-10-28 17:09:28 UTC
I do agree that the gtk use flag is inappropriate. Don't care about users whining about the binary or make gflashplayer its own package.


Can't stand the inflationary, mistakable and reduplicating use flag additions...
Comment 6 Olivier Crete (RETIRED) gentoo-dev 2006-10-29 20:22:26 UTC
We should probably make it a separate package. But we're not sure how they are going to package the final release.. So maybe we should instead just find a better use flag like standalone or player
Comment 7 Denilson Sá Maia 2006-10-30 06:48:20 UTC
(In reply to comment #6)
> So maybe we should instead just find a
> better use flag like standalone or player

Even the plugin can be called "flash player", so player is not a good choice. standalone looks a good one.

> But we're not sure how they are
> going to package the final release..

6 version had separate packages for standalone and plugin. 9 beta also has. Windows versions has only plugin (standalone not included). So, I guess the final release will have separate tarballs.

If there is an standalone version, why not call it "flashplayer-standalone". Maybe also rename current package from "netscape-flash" to "flashplayer-plugin".
I ask this because "netscape-flash-standalone" makes no sense.
Comment 8 Olivier Crete (RETIRED) gentoo-dev 2006-10-30 07:19:04 UTC
We should probably add a gflashplayer package then...
Comment 9 Carsten Lohrke (RETIRED) gentoo-dev 2006-10-30 14:19:32 UTC
Honestly, I don't understabd why people moan about the binary. It's not that it does any harm just because it's installed or wastes a lot of space. Making this optional or dividing this package in two is _so_ pointless.
Comment 10 Olivier Crete (RETIRED) gentoo-dev 2006-10-30 14:25:35 UTC
Carlo certainly has a point
Comment 11 MATSUU Takuto (RETIRED) gentoo-dev 2006-10-31 07:48:16 UTC
Created attachment 100888 [details, diff]
media-video/flashplayer-9.0.21.55.diff

I suggest to add nsplugin USE flag.and pkgmove to media-video/flashplayer.
Comment 12 Olivier Crete (RETIRED) gentoo-dev 2006-10-31 08:30:21 UTC
the pkgmove is useless
I think most people install it for the plugin, so it shouldn't be optional. I still favor just installing both without flags.
Comment 13 Denilson Sá Maia 2006-10-31 17:23:29 UTC
(In reply to comment #11)
> I suggest to add nsplugin USE flag.and pkgmove to media-video/flashplayer.

Like Oliver said, most people will want the nsplugin.

But I think a pkgmove or pkgrename would be good. "netscape-flash" is far different from "(Adobe|Macromedia) Flash Player (Plugin)?". It is not even related to netscape in special. And netscape isn't at portage anymore. [Note: I know plugins are called nsplugins because they use a Netscape API to talk to (any) browser]

I would suggest flash-?player-(plugin|standalone), in case we split this package in two, or flash-?player, with or without an useflag.
Comment 14 Olivier Crete (RETIRED) gentoo-dev 2006-10-31 17:54:43 UTC
I removed the use flag. There really is no good reason not to install both.
Comment 15 Anton Bolshakov 2006-11-14 02:57:51 UTC
Guys,

Can I reopen the bug?..
I would like to agree with you. I want this gtk player to be optional.
Here is my situation:
I don't have gtk installed and have -gtk in my make.conf.
So now because of one plugin it forces me to install the rest:

[ebuild     U ] net-www/netscape-flash-9.0.21.55 [7.0.68]
[ebuild  N    ]  x11-libs/gtk+-2.8.19  USE="X jpeg -debug -doc -tiff -xinerama"
[ebuild  N    ]   x11-misc/shared-mime-info-0.17-r2
[ebuild  N    ]   dev-libs/atk-1.12.1  USE="-debug -doc"
[ebuild  N    ]   x11-libs/pango-1.12.3  USE="-debug -doc

Please make it optional.
I don't see any reason why I should have gtk installed.
Comment 16 Anton Bolshakov 2006-11-14 03:04:32 UTC
sorry typo:
I would like _NOT_ to agree with you
Comment 17 Anton Bolshakov 2006-11-14 04:14:47 UTC
ah, is gtk not optional anymore?
I didn't pay attention on that "libgtk-x11-2.0.so.0"
Sorry.
They've got alsa support but added gtk dependency. I hate adobe.
Comment 18 Olivier Crete (RETIRED) gentoo-dev 2006-11-14 07:26:36 UTC
well, your friendly mozilla family browser already uses gtk+....
Comment 19 Anton Bolshakov 2006-11-14 15:37:40 UTC
I don't have Firefox.
[offtopic]Konqueror and Opera doing the job.[/offtopic]
That's why I didn't have gtk installed and I'm only one who complains :)
I'll try to complain to adobe as well...