Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 152923
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Project Gentopia <gentopia@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Martin Parm <parmus@diku.dk>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
removable.fdi Simple test case which illustrates the bug application/octet-stream Martin Parm 2006-10-26 14:34 0000 538 bytes Details
hal-0.5.7_indirections-in-append-and-preprend.patch Fix for handling indirections in <append> and <prepend> patch Martin Parm 2006-10-26 14:39 0000 4.44 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 152923 depends on: Show dependency tree
Bug 152923 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2006-10-26 14:30 0000 
According to the HAL specs
(http://gitweb.freedesktop.org/?p=hal.git;a=blob_plain;f=doc/spec/hal-spec.html#spec-device-info)
should be able to handle indirections in copy_property in both <merge>,
<append> and <prepend>-nodes, however only <merge> handles indirections right.
A simple .fdi file which illustrates the problem will be posted shortly.
I've looked in the lastest source from the upstream repository, but it doesn't
seem like they have fixed to problem yet either.

------- Comment #1 From Martin Parm 2006-10-26 14:34:57 0000 ------- 
Created an attachment (id=100556) [details]
Simple test case which illustrates the bug

This simple test case illustrates the bug with indirections in <append> and
<prepend>. Simply put this file in /etc/hal/fdi/policy and plug in some
removable storage-device (e.g an USB-key). If indirections in <append> and
<prepend> had worked, volume.policy.desired_mount_point should be "usb_disk"
for a USB-key.

------- Comment #2 From Martin Parm 2006-10-26 14:39:24 0000 ------- 
Created an attachment (id=100558) [details]
Fix for handling indirections in <append> and <prepend>

This patch fixes the bug by correctly handling indirections in copy_property in
<append> and <prepend>. It also simplifies the code a bit by merging the append
and prepend handling code, as they are nearly identical anyway. The patch has
been made with sys-apps/hal-0.5.7-r3 but also works with sys-hal-0.5.7.1-r1
without any changes.

------- Comment #3 From Doug Goldstein 2007-01-30 16:14:19 0000 ------- 
Have you passed this upstream? Please reference where you passed it upstream.

------- Comment #4 From Martin Parm 2007-02-02 12:44:12 0000 ------- 
(In reply to comment #3)
> Have you passed this upstream? Please reference where you passed it upstream.

OK, I passed it upstream now: https://bugs.freedesktop.org/show_bug.cgi?id=9849

However I don't have any high hopes. The last time I tried to get in touch with
the HAL-developers they simply ignored me.

------- Comment #5 From Doug Goldstein 2007-02-13 03:55:44 0000 ------- 
Added in -r5. Good job on this.
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug