Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 152674 - net-p2p/gtk-gnutella-0.96.2 version bump
Summary: net-p2p/gtk-gnutella-0.96.2 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo net-p2p team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-24 10:01 UTC by Dustin C. Hatch
Modified: 2006-12-02 00:13 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gtk-gnutella-0.96.2.ebuild (gtk-gnutella-0.96.2.ebuild,1.68 KB, text/plain)
2006-10-30 13:35 UTC, Hans de Graaff
Details
gtk-gnutella-0.96.2.ebuild (gtk-gnutella-0.96.2.ebuild,1.85 KB, text/plain)
2006-11-02 11:15 UTC, Hans de Graaff
Details
gtk-gnutella-0.96.3.ebuild (gtk-gnutella-0.96.3.ebuild,1.83 KB, text/plain)
2006-11-10 10:29 UTC, Hans de Graaff
Details
gtk-gnutella-0.96.3.ebuild (gtk-gnutella-0.96.3.ebuild,1.73 KB, text/plain)
2006-11-11 00:16 UTC, Hans de Graaff
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dustin C. Hatch 2006-10-24 10:01:08 UTC
I would like to request an ebuild for Gtk-Gnutella - The Graphical Unix Gnutella Client, version 0.96.2, released 17 October 2006.  It would be beneficial if this ebuild could include the patch from Bug #144668
Comment 1 Hans de Graaff gentoo-dev Security 2006-10-29 01:33:23 UTC
Please note that the fix for bug #144668 should not be included in gtk-gnutella 0.96.2, because the problem is solved upstream.
Comment 2 Hans de Graaff gentoo-dev Security 2006-10-30 13:35:29 UTC
Created attachment 100820 [details]
gtk-gnutella-0.96.2.ebuild

An updated ebuild for gtk-gnutella 0.96.2.

Notable changes:
* Depends on either bison or yacc (instead of always requiring yacc)
* Has three new use flags: gnutls for secure Gnutella connections, ipv6 for IPv6-based Gnutella connections, and sqlite3 for using more optimized storage for the spam file in gtkg CVS.
Comment 3 Dustin C. Hatch 2006-11-01 06:30:58 UTC
ebuild works great on amd64. Any idea when this will enter the main portage tree?
Comment 4 Hans de Graaff gentoo-dev Security 2006-11-02 11:15:02 UTC
Created attachment 101067 [details]
gtk-gnutella-0.96.2.ebuild

Here is an updated ebuild that fixes a few more things:

- remove unused gnome use flag
- remove dependency on yacc or bison (it's not needed because the generated files are distributed and used)
- add dependencies on zlib and gtk+
Comment 5 Paul Bredbury 2006-11-08 05:52:03 UTC
> - add dependencies on zlib

The normal ebuild policy is to *ignore* that dependency, because zlib is assumed to be installed (as is e.g. app-arch/gzip and sys-devel/gcc).
Comment 6 Hans de Graaff gentoo-dev Security 2006-11-10 10:29:35 UTC
Created attachment 101615 [details]
gtk-gnutella-0.96.3.ebuild

I've updated the ebuild for the recent release of gtk-gnutella 0.96.3, which contains a number of important bug fixes.
Comment 7 Hans de Graaff gentoo-dev Security 2006-11-11 00:16:14 UTC
Created attachment 101656 [details]
gtk-gnutella-0.96.3.ebuild

I've updated the ebuild to remove the ipv6 flag after discussing this with upstream. ipv6 support should be autodetected and enabled if present. The ability to remove it in the Configure script is really only there to avoid building with ipv6 on systems with a buggy or plainly broken ipv6 implementation. It used to be the case that ipv4-only was more optimized than ipv4 and ipv6, but this is no longer the case, and the ipv4-only code-paths are considered to be more buggy.
Comment 8 Dustin C. Hatch 2006-11-11 07:01:35 UTC
The question I have about this is suppose one migrates from an IPv4 only system to one supporting IPv6.  emerge -avuDN world will not recomplile gtk-gnutella if it does not have an ipv6 use flag. The user must then complile it manually or wait for a version release.

(In reply to comment #7)
> Created an attachment (id=101656) [edit]
> gtk-gnutella-0.96.3.ebuild
> 
> I've updated the ebuild to remove the ipv6 flag after discussing this with
> upstream. ipv6 support should be autodetected and enabled if present. The
> ability to remove it in the Configure script is really only there to avoid
> building with ipv6 on systems with a buggy or plainly broken ipv6
> implementation. It used to be the case that ipv4-only was more optimized than
> ipv4 and ipv6, but this is no longer the case, and the ipv4-only code-paths are
> considered to be more buggy.
> 

Comment 9 Hans de Graaff gentoo-dev Security 2006-11-11 07:09:10 UTC
I think the scenario in comment #8 is fairly unlikely. The code that gets enabled depends on whether the underlying OS supports IPv6, not on whether there actually is IPv6 connectivity. As far as I know most OS currently in use already support IPv6 for quite some time, so only really old systems won't have this support. The chance that you can carry over your installation from such an old system without reinstalling doesn't seem to be very big to me. If there are systems without (working) IPv6 still actively supported for Gentoo than we should reconsider adding the IPv6 USE flag for this reason.

If the IPv6 support is compiled in and you get IPv6 connectivity later then you can just enable the IPv6 parts in the gtk-gnutella interface.
Comment 10 Dustin C. Hatch 2006-11-11 22:45:12 UTC
Actually, the scenario I mentioned above happened to me.  When I first build my system, I did not enable IPv6 support.  When I realized that I was able to get IPv6 connectivity, I recompiled my kernel with IPv6 support, enabled the ipv6 use flag, and rebuild all affected packages.  If gtk-gnutella drops this use flag, it would not have been rebuilt with the rest of the packages, keeping IPv6 support out of the application.
Comment 11 Paul Bredbury 2006-11-11 22:56:30 UTC
(In reply to comment #10)
> keeping IPv6 support out of the application.

Wrong. Look:  "ipv6 support should be autodetected and enabled if present."

Comment 12 Dustin C. Hatch 2006-11-12 05:30:52 UTC
Are you saying that it will just magically recompile itself when it autodetects IPv6 support, or is it going to compile with IPv6 support whether my system has capability or not?
Comment 13 Hans de Graaff gentoo-dev Security 2006-11-12 05:38:33 UTC
Whether or not you enable IPv6 support in the kernel does not change the fact that your system knows about and provides the right include files and definitions for IPv6 as part of the kernel and libc. So gtk-gnutella uses those to include support for IPv6. If you later decide to include IPv6 support in the kernel then gtk-gnutella can use it right away, there is no need for recompilation.

The problem mentioned in comment #8 only happens when your OS doesn't know about IPv6 at all, or its definitions of IPv6 are broken. For example, you are still running Linux 0.99 with libc5 (hypothetical example as I can't remember when IPv6 became supported in the kernel and glibc).
Comment 14 Dustin C. Hatch 2006-11-12 07:59:49 UTC
Understood; I stand corrected.  I just wanted to be absolutly certain about the issue.  Thank you for your explaination. :)
Comment 15 adr 2006-11-12 09:50:17 UTC
The gtk-gnutella-0.96.3.ebuild works fine. Fixes the nls bug also [ http://bugs.gentoo.org/show_bug.cgi?id=144668 ].
Comment 16 Kenyon Ralph 2006-11-20 22:01:49 UTC
I finally got fed up with the crashing of 0.96.1 and installed 0.96.3 using the ebuild attached here.  The emerge worked and the program works.  We'll see if it fixes the crashing though.
Comment 17 Kevin R André 2006-11-27 14:31:25 UTC
(In reply to comment #15)
> The gtk-gnutella-0.96.3.ebuild works fine. Fixes the nls bug also [
> http://bugs.gentoo.org/show_bug.cgi?id=144668 ].

When will this ebuild become available in portage?
Comment 18 Hans de Graaff gentoo-dev Security 2006-11-28 02:28:44 UTC
net-p2p people: if there is currently no active maintainer for gtk-gnutella I'd be happy to take over maintainership.
Comment 19 Jeff 2006-11-29 07:52:22 UTC
(In reply to comment #18)
> net-p2p people: if there is currently no active maintainer for gtk-gnutella I'd
> be happy to take over maintainership.
> 

I second the motion. This is a great app - would be a shame to see it slip away.

You have my vote.
Comment 20 Petteri Räty (RETIRED) gentoo-dev 2006-12-01 00:33:28 UTC
(In reply to comment #18)
> net-p2p people: if there is currently no active maintainer for gtk-gnutella I'd
> be happy to take over maintainership.
> 

You have my blessing. Just join the herd and you can fix other stuff too :)
Comment 21 Hans de Graaff gentoo-dev Security 2006-12-01 06:44:21 UTC
Great. I expect to add the new ebuild to portage this weekend.
Comment 22 Hans de Graaff gentoo-dev Security 2006-12-02 00:13:21 UTC
I've just added gtk-gnutella 0.96.3 to portage. Thanks for the feedback everyone.