Bugzilla Bug 152573

older zlib's had a hard coded list of symbols to export ... the 1.2.3 bump did
not update that list so it did not properly export all new symbols

i rewrote the code to use ELF visibility and to be purely zlib based, so there
should be no need to update this in the future and it should "just work"

make sure you test this before stabilizing as it is a core package ;p

ppc64 stable

1. emerges on x86
2. passes collision test
3. passes test suite
4. revdep-rebuild shows nothing broken and remerged successfully some reverse
deps of zlib.

sys-libs/zlib-1.2.3-r1  USE="-build"

Portage 2.1.1 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.4-r3,
2.6.18.1 i686)
=================================================================
System uname: 2.6.18.1 i686 Genuine Intel(R) CPU           T2300  @ 1.66GHz
Gentoo Base System version 1.12.5
Last Sync: Mon, 23 Oct 2006 10:50:01 +0000
ccache version 2.3 [disabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.3.5-r3, 2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--nospinner"
FEATURES="autoconfig collision-protect distlocks metadata-transfer
parallel-fetch sandbox sfperms strict test userfetch userpriv usersandbox"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LINGUAS="en de en_GB de_CH"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="x86 X a52 aac acpi alsa apache2 asf berkdb bitmap-fonts cairo cdr cdrom
cli cracklib crypt cups dbus divx dlloader dri dts dvd dvdr dvdread eds
elibc_glibc emboss encode fam ffmpeg firefox flac fortran gdbm gif gnome gpm
gstreamer gtk hal input_devices_keyboard input_devices_mouse ipv6 isdnlog java
jpeg kde kernel_linux ldap libg++ linguas_de linguas_de_CH linguas_en
linguas_en_GB mad mikmod mmx mono mp3 mpeg ncurses nls nptl nptlonly ogg opengl
oss pam pcre perl png ppds pppd python qt3 qt4 quicktime readline reflection
rtsp samba sdl session smp spell spl sse sse2 sse3 ssl svg tcpd test tetex
theora threads truetype truetype-fonts type1-fonts udev unicode userland_GNU
vcd video_cards_fbdev video_cards_i810 video_cards_vesa vorbis win32codecs
wxwindows x264 xine xml xorg xprint xv xvid zlib"
Unset:  CTARGET, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS,
PORTDIR_OVERLAY

Works here, x86 out of the way.

SPARC and roll

Tested and stable on ppc.

Stable for HPPA.

amd64 done.

Forgot to amd64 remove from CC.

Stable on Alpha and ia64.

Broken on uclibc.

It looks like this update broke something for uclibc folks, noted on both the
mipsel and arm architectures.
http://forums.gentoo.org/viewtopic-p-3767564.html


Also seems to have broken detection of vsnprintf(),


-----Relevant output from sys-libs/zlib-1.2.3-r1 build-----
Checking whether to use vs[n]printf() or s[n]printf()... using vs[n]printf()
Checking for vsnprintf() in stdio.h... No.
  WARNING: vsnprintf() not found, falling back to vsprintf(). zlib
  can build but will be open to possible buffer-overflow security
  vulnerabilities.
Checking for return value of vsprintf()... Yes.


-----Relevant output from sys-libs/zlib-1.2.3 build-----
Checking whether to use vs[n]printf() or s[n]printf()... using vs[n]printf()
Checking for vsnprintf() in stdio.h... Yes.
Checking for return value of vsnprintf()... Yes.


The build time error related to the visibility stuff:

rm -f libz.so libz.so.1
ln -s libz.so.1.2.3 libz.so
ln -s libz.so.1.2.3 libz.so.1
mipsel-gentoo-linux-uclibc-gcc -Os -pipe -mips32 -mtune=mips32 -funit-at-a-time
-ftracer -fPIC -DHAS_attribute_visibility -fvisibility=hidden -DNO_vsnprintf
-DUSE_MMAP -o example example.o  libz.a
/usr/lib/gcc/mipsel-gentoo-linux-uclibc/3.4.6/../../../../mipsel-gentoo-linux-uclibc/bin/ld:
example: hidden symbol `main' in example.o is referenced by DSO
/usr/lib/gcc/mipsel-gentoo-linux-uclibc/3.4.6/../../../../mipsel-gentoo-linux-uclibc/bin/ld:
final link failed: Nonrepresentable section on output
collect2: ld returned 1 exit status
make: *** [example] Error 1

!!! ERROR: sys-libs/zlib-1.2.3-r1 failed.
Call stack:
  ebuild.sh, line 1569:   Called dyn_compile
  ebuild.sh, line 938:   Called src_compile
  zlib-1.2.3-r1.ebuild, line 39:   Called die



emerge --info

Portage 2.1.2_rc2-r4 (uclibc/mips, gcc-3.4.6, uclibc-0.9.27-r1, 2.6.16 mips)
=================================================================
System uname: 2.6.16 mips Broadcom BCM3302 V0.7
Gentoo Base System version 1.12.6
Last Sync: Sun, 03 Dec 2006 14:00:01 +0000
distcc 2.18.3 mipsel-gentoo-linux-uclibc (protocols 1 and 2) (default port
3632) [disabled]
dev-lang/python:     2.3.4-r1
dev-python/pycrypto: 2.0.1-r5
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.14
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.16.16
ACCEPT_KEYWORDS="mips ~mips"
AUTOCLEAN="yes"
CBUILD="mipsel-gentoo-linux-uclibc"
CFLAGS="-Os -pipe -mips32 -mtune=mips32 -funit-at-a-time -ftracer"
CHOST="mipsel-gentoo-linux-uclibc"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/env.d /etc/gconf /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-Os -pipe -mips32 -mtune=mips32 -funit-at-a-time -ftracer
-fvisibility-inlines-hidden"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks metadata-transfer nodoc noinfo noman sfperms
strict"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/linux/distributions/gentoo"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180 --exclude"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://server/gentoo-portage"
USE="mips alsa bitmap-fonts cli cracklib dlloader dri elibc_uclibc
input_devices_evdev input_devices_keyboard input_devices_mouse kernel_linux mp3
ncurses p"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS,
LINGUAS, PORTAGE_RSYNC_EXTRA_OPTS

umm, no ... those are bugs in the mips/arm toolchain, not bugs in zlib ... i'm
not going to track that issue here

 12 May 2007; Joshua Kinard <kumba@gentoo.org> zlib-1.2.3-r1.ebuild:
  Stable on mips.