Bugzilla Bug 152007

Currently masked flac-1.1.3_beta2 package is going to widely break API, because
upstream:

a) removed libOggFLAC and libOggFLAC++ libraries;
b) moved inside libFLAC the Ogg support;
c) changed some internal APIs entirely.

Up to now, a few packages built fine with the new 1.1.3, mostly the ones that
just use the metadata-access functions. Software that uses flac command for
encoding without using libFLAC should be fine too, the rest should be checked,
if it does not build, or it disables FLAC support (pay attention to that!),
then the dependency should be changed to ~media-libs/flac-1.1.2 to make sure
the tree is correct. When patches will be available, the dep will be changed.

gnustep-apps/cynthiune-0.9.4
kde-base/kdemultimedia-kioslaves-3.5.2
kde-base/kdemultimedia-kioslaves-3.5.3
kde-base/kdemultimedia-kioslaves-3.5.4
kde-base/kdemultimedia-kioslaves-3.5.5
media-plugins/audacious-plugins-1.2.0-r1
media-plugins/audacious-plugins-1.2.1
media-plugins/gst-plugins-flac-0.10.3
media-plugins/mythmusic-0.19
media-plugins/mythmusic-0.20
media-sound/abcde-2.1.15
media-sound/abcde-2.1.19
media-sound/abcde-2.1.9
media-sound/abcde-2.2.0
media-sound/abcde-2.3.0
media-sound/asunder-0.1.0
media-sound/audacious-1.1.0
media-sound/audacious-1.1.1
media-sound/audacious-1.1.1-r1
media-sound/audacious-1.1.2
media-sound/audacious-1.1.2-r1
media-sound/audiotag-0.13
media-sound/audiotag-0.14
media-sound/audiotag-0.15
media-sound/hydrogen-0.9.0
media-sound/hydrogen-0.9.1
media-sound/hydrogen-0.9.2
media-sound/hydrogen-0.9.3
media-sound/jack-3.0.0
media-sound/jack-3.1.1
media-sound/lltag-0.10
media-sound/lltag-0.12.1
media-sound/moc-2.2.0-r1
media-sound/moc-2.3.0
media-sound/mpd-0.11.5-r2
media-sound/mpd-0.12.0
media-sound/mpd-0.12.1
media-sound/mpd-svn-20060810
media-sound/mpd-svn-20060817
media-sound/mpd-svn-20060824
media-sound/mpd-svn-20060916
media-sound/muine-0.8.4
media-sound/muine-0.8.5
media-sound/prokyon3-0.9.4
media-sound/prokyon3-0.9.4-r1
media-sound/qmbtagger-0.07
media-sound/rezound-0.12.0_beta
media-sound/rezound-0.12.2_beta
media-sound/rezound-0.12.2_beta-r1
media-sound/ripperx-2.6.4
media-sound/ripperx-2.6.6
media-sound/timidity++-2.13.2-r2
media-video/mkvtoolnix-1.5.5
media-video/mkvtoolnix-1.7.0
net-p2p/lopster-1.2.2
net-p2p/lopster-1.2.2-r1
net-p2p/lopster-1.2.2-r2
rox-extra/musicbox-027

kdebase-kioslaves uses only flac binary for encoding.

lltag only uses metaflac and a test showed it worked fine with the new version.

rox-extra/musicbox-027 is not compatible with 1.1.3 (builds some custom python
bindings)

I have changed the dependency to ~media-libs/flac-1.1.2 which works great.

(In reply to comment #0)
> media-sound/mpd-0.11.5-r2
> media-sound/mpd-0.12.0
> media-sound/mpd-0.12.1
> media-sound/mpd-svn-20060810
> media-sound/mpd-svn-20060817
> media-sound/mpd-svn-20060824
> media-sound/mpd-svn-20060916

With flac-1.1.3_beta2, mpd's configure decides to disable oggflac support, but
dies during compile anyway. Depend atom changed to ~media-sound/flac-1.1.2.

I'm not going to touch mpd-svn anymore, as it is package.masked and about to be
removed from the tree completely.

Thanks for the heads up!

mkvtoolnix deps fixed to 1.1.2 too.

mpd-svn is depreciated, We're hopeing to have a patch sooner than later for
MPD, but no guarantees.

qmbtagger is incompatible with 1.1.3, dependency fixed.
audiotag uses the commands at runtime, and it's fine.
abcde is a bash script, uses the commands at runtime, and it's fine.
asunder uses the commands at runtime, and it's fine.

The list is now down to:

gnustep-apps/cynthiune-0.9.4
media-plugins/audacious-plugins-1.2.0-r1
media-plugins/audacious-plugins-1.2.1
media-plugins/gst-plugins-flac-0.10.3
media-plugins/mythmusic-0.19
media-plugins/mythmusic-0.20
media-sound/audacious-1.1.0
media-sound/audacious-1.1.1
media-sound/audacious-1.1.1-r1
media-sound/audacious-1.1.2
media-sound/audacious-1.1.2-r1
media-sound/hydrogen-0.9.0
media-sound/hydrogen-0.9.1
media-sound/hydrogen-0.9.2
media-sound/hydrogen-0.9.3
media-sound/jack-3.0.0
media-sound/jack-3.1.1
media-sound/moc-2.2.0-r1
media-sound/moc-2.3.0
media-sound/muine-0.8.4
media-sound/muine-0.8.5
media-sound/prokyon3-0.9.4
media-sound/prokyon3-0.9.4-r1
media-sound/rezound-0.12.0_beta
media-sound/rezound-0.12.2_beta
media-sound/rezound-0.12.2_beta-r1
media-sound/ripperx-2.6.4
media-sound/ripperx-2.6.6
media-sound/timidity++-2.13.2-r2
net-p2p/lopster-1.2.2
net-p2p/lopster-1.2.2-r1
net-p2p/lopster-1.2.2-r2

lopster builds fine
jack does not use the library
prokyon3 builds but says FLAC is disabled (not sure if it's a generic bug of
the ebuild)
ripperx builds and seems not to require the library

gnustep-apps/cynthiune fixed at 1.1.2

audacious (and plugins) checked, does not build, fixed to 1.1.2
mythmusic checked, does not build, fixed to 1.1.2
moc checked, does not build, fixed to 1.1.2

rezound does not build, might be worth removing it? I'll consider that.
prokyon3 still has to be checked, as I'm afraid something is broken in it..

media-plugins/gst-plugins-flac-0.10.3
media-sound/hydrogen-0.9.0
media-sound/hydrogen-0.9.1
media-sound/hydrogen-0.9.2
media-sound/hydrogen-0.9.3
media-sound/muine-0.8.4
media-sound/muine-0.8.5
media-sound/prokyon3-0.9.4
media-sound/prokyon3-0.9.4-r1
media-sound/rezound-0.12.0_beta
media-sound/rezound-0.12.2_beta
media-sound/rezound-0.12.2_beta-r1

I cannot test muine on pitr, dotnet guys, it's yours.

My amd64 machine at home will happily test muine for you sometime this weekend.

hydrogen depends on libsndfile, which in turn requires flac 1.1.2, so it's not
much important right now.

rezound is masked and last rited.

gst-plugins-flac is fixed to 1.1.2.

Fixed muine to 1.1.2 since it uses gst-plugins-flac anyways.

I would like to add easytag to the list of apps in need of "fixing" for flac
1.1.3.

To confirm, the following combination is FLAC 1.1.3 tolerant (tested compile &
playback on PPC):
media-sound/audacious-1.2.2
media-plugins/audacious-plugins-1.2.5

Runtime switching is not supported, the configure script will make a decision
on whether to build the flac112 or the flac113 plugin.
This should fit in well with a revdep-rebuild. Anyone managing to get FLAC
upstream to stop this continuous API breaking madness wins a lot of respect,
btw.

(In reply to comment #16)

> Anyone managing to get FLAC
> upstream to stop this continuous API breaking madness wins a lot of respect,
> btw.


I think we can't blame Josh for that, the api changes are meant to simplify
flac api and he sent patches to be compatible with both api to almost every
single package upstream :) (look at the bunch of bugs I've been filling lately,
all patches are from him)


So now, besides the bugs blocking this one, the following packages still need
patches :

media-libs/sdl-sound

media-plugins/mythmusic

media-sound/bossogg -- I have patches for this one, but it doesn't want to
start (this doesnt seem to be flac related, I'll investigate this)

media-sound/cmus -- doesn't compile with flac 1.1.3, not even ~ depping to flac
1.1.2 : opfer ?

media-sound/hydrogen -- doesn't compile with flac 1.1.3, not even ~ depping to
flac 1.1.2 : eldad ?

media-sound/audacity -- doesn't compile with flac 1.1.3, failing at configure,
not even ~ depping to flac 1.1.2 : I'll fix this one

media-sound/mpd : Ticho, any news from upstream about this ?

media-sound/muine -- depends on bug #157707 , we'll check this one when it'll
be resolved.

media-video/vlc -- We have the patches, Diego (or me) should apply them soon

rox-extra/musicbox


Hopin' I didn't forget anything

> media-sound/mpd : Ticho, any news from upstream about this ?

Ticho is not around in #mpd, so here's the skinny. MPDs svn is working with
flac-1.1.3, we're simply working out the details of the next release, which
hopefully, will happen in the next week.

(In reply to comment #17)
> media-sound/cmus -- doesn't compile with flac 1.1.3, not even ~ depping to flac
> 1.1.2 : opfer ?

 I contacted upstream.

(In reply to comment #18)
> Ticho is not around in #mpd, so here's the skinny. MPDs svn is working with
> flac-1.1.3, we're simply working out the details of the next release, which
> hopefully, will happen in the next week.


That's perfect, thanks.


media-video/vlc-0.8.6 is flac 1.1.3 ready

media-sound/timidity++ is not flac 1.1.3 ready, I had forgot it, I have Josh's
patches but that'd be better to fix bug #156539 before.

(In reply to comment #17)
> media-sound/cmus -- doesn't compile with flac 1.1.3, not even ~ depping to flac
> 1.1.2 : opfer ?

 A new version will be release soon, upstream is investigating how to fix it
with flac 1.1.3.  In the meantime, should cmus-2.0.4 depend on flac 1.1.2? 
That works here.

>  A new version will be release soon, upstream is investigating how to fix it
> with flac 1.1.3.  In the meantime, should cmus-2.0.4 depend on flac 1.1.2? 
> That works here.


Like Diego said : "... if it does not build, or it disables FLAC support (pay
attention to that!),
then the dependency should be changed to ~media-libs/flac-1.1.2 to make
sure..." 

:)


If that might help them, there are some flac 1.1.3 patches in the tree. The
best way to fix this would be to be compatible with flac 1.1.2 and flac 1.1.3 
like it has always been the case with the patches I've commited, so that when
we'll be ready to unmask flac 1.1.3 there won't be any extra work.

cmus will build with flac 1.1.3 in the next release...should I backport the
patch or just wait for new upstream files?

Feel free to wait, it will take a bit before we unmask it anyway.

cmus is updated to 2.1.0, which supports flac 1.1.3 and .2

Just to say at flac>=1.3 will break 
media-sound/alsaplayer with USE=flac.

I committed a fix into alsaplayer svn and I am doing some tests. A new release
with support for flac 1.2, 1.3 and 1.4 will be done in the following days.
Normally, it will be enough to just bump alsaplayer ebuild when the release
will be done.

Is there something keeping flac from being unmasked?

(In reply to comment #27)
> Is there something keeping flac from being unmasked?

No.

(In reply to comment #28)
> (In reply to comment #27)
> > Is there something keeping flac from being unmasked?
> 
> No.
> 

3 packages that fail to build isn't enough ?

Note that if you don't care about those packages, you can still unmask flac
locally, so I don't see the point in unmasking it while we *know* that some
packages will break

(In reply to comment #29)
> 3 packages that fail to build

Exactly which ones?

(In reply to comment #30)
> (In reply to comment #29)
> > 3 packages that fail to build
> 
> Exactly which ones?
> 

the ones for which I had opened a bug and that this bug depends on, i.e., bug
#181822 , bug #181829 , bug #181864 that are still not marked as fixed

(In reply to comment #15)
> I would like to add easytag to the list of apps in need of "fixing" for flac
> 1.1.3.
> 

It's been fixed by upstream before 2.0 release in testing 1.99.x ones, and
~arch is actually in version 2.1.2 by now. Previous versions have been removed
from tree, they we're using GTK+-1.2 anyways.. fugly..

Unmasked.

Nothing left to do here. All bugs closed.