First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 151257
Alias:
Product:
Component:
Status: REOPENED
Resolution:
Assigned To: Gentoo's Team for Core System packages <base-system@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Adam Goossens <adam.goossens@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
eject-space-handling.patch fixes space handling patch Adam Goossens 2006-10-13 21:20 0000 1.50 KB Details | Diff
eject-2.1.5-handle-spaces.patch eject-2.1.5-handle-spaces.patch patch SpanKY 2006-10-14 13:24 0000 1.89 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 151257 depends on: Show dependency tree
Show dependency graph
Bug 151257 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)









View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-10-13 21:20 0000
Mount points with spaces in the name (such as "/media/LEXAR MEDIA") are stored
with spaces encoded within /etc/mtab and /proc/mounts (i.e., as
/media/LEXAR\040MEDIA). eject simply extracts this mountpoint and passes it to
pumount/pmount without decoding these characters. As such, it becomes
equivalent to executing "pumount /media/LEXAR\040MEDIA" which will fail.

I've attached a patch - this was taken out of debian's patch set for eject.

Portage 2.1.1 (default-linux/x86/2006.0, gcc-4.1.1, glibc-2.4-r4,
2.6.17-gentoo-r7 i686)
=================================================================
System uname: 2.6.17-gentoo-r7 i686 AMD Athlon(tm) XP 2800+
Gentoo Base System version 1.12.5
Last Sync: Fri, 13 Oct 2006 01:00:08 +0000
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     [Not Present]
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=i686 -O2 -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/lib/mozilla/defaults/pref /usr/share/X11/xkb
/usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-rebuild /etc/splash /etc/terminfo"
CXXFLAGS="-march=i686 -O2 -fomit-frame-pointer -pipe
-fvisibility-inlines-hidden"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks metadata-transfer sandbox sfperms strict
userpriv usersandbox"
GENTOO_MIRRORS="http://mirror.isp.net.au/ftp/pub/gentoo
http://gentoo.osuosl.org http://www.ibiblio.org/pub/Linux/distributions/gentoo"
LDFLAGS="-Wl,-O1 -Wl,--sort-common -s"
LINGUAS=""
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/gentopia"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X aac alsa apache2 apm asf berkdb bitmap-fonts cdr cli crypt cups dbus
dlloader dri dvd eds elibc_glibc emboss encode esd foomaticdb fortran gdbm gif
gnome gpm gstreamer gtk gtk2 hal imlib input_devices_keyboard
input_devices_mouse ipod ipv6 isdnlog jpeg kde kdeenablefinal kernel_linux
libg++ libwww mad mikmod motif mp3 mpeg ncurses nls nptl nptlonly ogg opengl
oss pam pcre perl png pppd python qt3 qt4 quicktime readline reflection sdl
session spell spl ssl tcpd truetype truetype-fonts type1-fonts udev
userland_GNU video_cards_nvidia vorbis win32codecs xinerama xml xorg xv zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL,
PORTAGE_RSYNC_EXTRA_OPTS

------- Comment #1 From Adam Goossens 2006-10-13 21:20:41 0000 -------
Created an attachment (id=99632) [edit]
fixes space handling

------- Comment #2 From SpanKY 2006-10-14 13:24:25 0000 -------
Created an attachment (id=99676) [edit]
eject-2.1.5-handle-spaces.patch

i dont really like that Debian patch ... try this one instead

------- Comment #3 From Adam Goossens 2006-10-14 20:25:51 0000 -------
Thanks - new patch works fine for me.

------- Comment #4 From SpanKY 2006-10-15 19:07:53 0000 -------
2.1.5-r1 in portage with patch

------- Comment #5 From Jakub Moc 2006-12-16 01:10:09 0000 -------
*** Bug 158252 has been marked as a duplicate of this bug. ***

------- Comment #6 From Jakub Moc 2007-02-14 13:40:16 0000 -------
*** Bug 166825 has been marked as a duplicate of this bug. ***

------- Comment #7 From Jakub Moc 2007-02-14 13:40:38 0000 -------
Reopen wrt Bug 166825 

------- Comment #8 From Jan 2007-02-14 13:46:21 0000 -------
Relevant information from closed bug (thanks for re-opening Jakub):

The patch does not resolve the problem in my opinion.

De-mangling of the mount points must be done *before* the strcmp(), not
afterwards. Additionally, I would suggest testing for "\0nn" when looking for
an octal number rather than testing for "\nnn".

Suggested patch: http://bugs.gentoo.org/attachment.cgi?id=110163&action=view

First Last Prev Next    No search results available      Search page      Enter new bug