Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 151024
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Steve Dibb <beandog@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Rodrigo Severo <rodrigo@fabricadeideias.com>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
use_flag_message_enhancement.patch Patch for dvdrip-0.98.1 ebuild (improving complains about incompatible transcode USE flags patch Rodrigo Severo 2006-10-12 08:32 0000 1.04 KB Details | Diff
dvdrip-0.98.1.ebuild.diff dvdrip-0.98.1.ebuild.diff patch Jakub Moc (RETIRED) 2006-10-12 08:53 0000 742 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 151024 depends on: Show dependency tree
Bug 151024 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2006-10-12 08:30 0000 
dvdrip 0.98.1 currently complains about the lack of transcode dvdread USE flag
*and* of the presence of transcode extrafilters USE flag even if only one of
the conditions are actually happening.

This confuses the users.

------- Comment #1 From Rodrigo Severo 2006-10-12 08:32:26 0000 ------- 
Created an attachment (id=99440) [details]
Patch for dvdrip-0.98.1 ebuild (improving complains about incompatible
transcode USE flags

This simple patch makes dvdrip 0.98.1 ebuild present only the appropriate
complains about transcode USE flags.

------- Comment #2 From Jakub Moc (RETIRED) 2006-10-12 08:36:13 0000 ------- 
(From update of attachment 99440 [details])
Eh, this will just die twice if the use happens to have both...

------- Comment #3 From Jakub Moc (RETIRED) 2006-10-12 08:53:17 0000 ------- 
Created an attachment (id=99442) [details]
dvdrip-0.98.1.ebuild.diff

Keep it short and simple... :P

------- Comment #4 From Rodrigo Severo 2006-10-12 19:18:49 0000 ------- 
(In reply to comment #2)
> (From update of attachment 99440 [details] [edit])
> Eh, this will just die twice if the use happens to have both...

I don't understand what you mean by "die twice". The patch I proposed would
present both messages at the same time if tanscode had both problems but would
present only one message if transcode had only one problem. Please explain
better what you mean by "die twice".

Anyway, I think your suggestion doesn't really solves the problem, at least as
I see it: asking the user to do something he already did. I mean, for example,
asking him to include the USE flag "dvdread" when he already did just because
he needs "-extrafilters".

This confuses users.

------- Comment #5 From Steve Dibb 2006-10-22 22:43:10 0000 ------- 
Fixed in CVS, thanks
Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug