Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 150314
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Development Tools Team <dev-tools@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Federico Fissore <federico@fsfe.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
eclipse-sdk-3.2.1-r1.ebuild eclipse-sdk-3.2.1-r1.ebuild text/plain Federico Fissore 2006-10-06 13:13 0000 12.14 KB Details
eclipse.ebuild.diff diff from 3.2.1 to 3.2.1-r1 patch Federico Fissore 2006-10-06 13:14 0000 11.95 KB Details | Diff
customBuildCallbacks.xml-add-pre.gather.bin.parts.patch customBuildCallbacks.xml-add-pre.gather.bin.parts.patch patch Federico Fissore 2006-10-06 13:15 0000 1.28 KB Details | Diff
eclipse-sdk-3.2.1-build.patch eclipse-sdk-3.2.1-build.patch patch Federico Fissore 2006-10-06 13:15 0000 1.68 KB Details | Diff
eclipse-sdk-3.2.1-buildDocPlugins.patch eclipse-sdk-3.2.1-buildDocPlugins.patch patch Federico Fissore 2006-10-06 13:16 0000 1.75 KB Details | Diff
eclipse-sdk-3.2.1-bz162177.patch eclipse-sdk-3.2.1-bz162177.patch patch Federico Fissore 2006-10-06 13:16 0000 1.43 KB Details | Diff
eclipse-sdk-3.2.1-compare-create-api.patch eclipse-sdk-3.2.1-compare-create-api.patch patch Federico Fissore 2006-10-06 13:17 0000 36.35 KB Details | Diff
eclipse-sdk-3.2.1-disable-junit4-apt.patch eclipse-sdk-3.2.1-disable-junit4-apt.patch patch Federico Fissore 2006-10-06 13:18 0000 24.62 KB Details | Diff
eclipse-sdk-3.2.1-ecj-classpath.patch eclipse-sdk-3.2.1-ecj-classpath.patch patch Federico Fissore 2006-10-06 13:18 0000 557 bytes Details | Diff
eclipse-sdk-3.2.1-ecj-gcj.patch eclipse-sdk-3.2.1-ecj-gcj.patch patch Federico Fissore 2006-10-06 13:19 0000 52.28 KB Details | Diff
eclipse-sdk-3.2.1-ecj-rpmdebuginfo.patch eclipse-sdk-3.2.1-ecj-rpmdebuginfo.patch patch Federico Fissore 2006-10-06 13:19 0000 1.94 KB Details | Diff
eclipse-sdk-3.2.1-fileinitializer.patch eclipse-sdk-3.2.1-fileinitializer.patch patch Federico Fissore 2006-10-06 13:20 0000 17.82 KB Details | Diff
eclipse-sdk-3.2.1-gentoo-libswt-enableallandO2.patch eclipse-sdk-3.2.1-gentoo-libswt-enableallandO2.patch patch Federico Fissore 2006-10-06 13:20 0000 548 bytes Details | Diff
eclipse-sdk-3.2.1-gnuformatterjdt.patch eclipse-sdk-3.2.1-gnuformatterjdt.patch patch Federico Fissore 2006-10-06 13:20 0000 13.50 KB Details | Diff
eclipse-sdk-3.2.1-gnuformatterjdtui.patch eclipse-sdk-3.2.1-gnuformatterjdtui.patch patch Federico Fissore 2006-10-06 13:21 0000 2.95 KB Details | Diff
eclipse-sdk-3.2.1-helpindexbuilder.patch eclipse-sdk-3.2.1-helpindexbuilder.patch patch Federico Fissore 2006-10-06 13:21 0000 1.02 KB Details | Diff
eclipse-sdk-3.2.1-icu4j-build-files.patch eclipse-sdk-3.2.1-icu4j-build-files.patch patch Federico Fissore 2006-10-06 13:21 0000 15.95 KB Details | Diff
eclipse-sdk-3.2.1-javadoclinks.patch eclipse-sdk-3.2.1-javadoclinks.patch patch Federico Fissore 2006-10-06 13:22 0000 4.83 KB Details | Diff
eclipse-sdk-3.2.1-launcher-link.patch eclipse-sdk-3.2.1-launcher-link.patch patch Federico Fissore 2006-10-06 13:22 0000 6.64 KB Details | Diff
eclipse-sdk-3.2.1-libswt-xpcomgcc4.patch eclipse-sdk-3.2.1-libswt-xpcomgcc4.patch patch Federico Fissore 2006-10-06 13:22 0000 3.35 KB Details | Diff
eclipse-sdk-3.2.1-libupdatebuild.patch eclipse-sdk-3.2.1-libupdatebuild.patch patch Federico Fissore 2006-10-06 13:23 0000 1.11 KB Details | Diff
eclipse-sdk-3.2.1-libupdatebuild2.patch eclipse-sdk-3.2.1-libupdatebuild2.patch patch Federico Fissore 2006-10-06 13:23 0000 783 bytes Details | Diff
eclipse-sdk-3.2.1-pde.build-add-package-build.patch eclipse-sdk-3.2.1-pde.build-add-package-build.patch patch Federico Fissore 2006-10-06 13:23 0000 11.09 KB Details | Diff
eclipse-sdk-3.2.1-searchindexlucene.patch eclipse-sdk-3.2.1-searchindexlucene.patch patch Federico Fissore 2006-10-06 13:24 0000 589 bytes Details | Diff
eclipse-sdk-3.2.1-swt-firefox.2.patch eclipse-sdk-3.2.1-swt-firefox.2.patch patch Federico Fissore 2006-10-06 13:24 0000 1.45 KB Details | Diff
eclipse-sdk-3.2.1-swt-firefox.patch eclipse-sdk-3.2.1-swt-firefox.patch patch Federico Fissore 2006-10-06 13:25 0000 19.34 KB Details | Diff
eclipse-sdk-3.2.1-swt-rm-ON_TOP.patch eclipse-sdk-3.2.1-swt-rm-ON_TOP.patch patch Federico Fissore 2006-10-06 13:25 0000 958 bytes Details | Diff
eclipse-sdk-3.2.1-swttools.patch eclipse-sdk-3.2.1-swttools.patch patch Federico Fissore 2006-10-06 13:26 0000 2.29 KB Details | Diff
eclipse-sdk-3.2.1-tomcat55.patch eclipse-sdk-3.2.1-tomcat55.patch patch Federico Fissore 2006-10-06 13:26 0000 66.39 KB Details | Diff
eclipse-sdk-3.2.1-tomcat55-build.patch eclipse-sdk-3.2.1-tomcat55-build.patch patch Federico Fissore 2006-10-06 13:26 0000 11.41 KB Details | Diff
eclipse-sdk-3.2.1-updatehomedir.patch eclipse-sdk-3.2.1-updatehomedir.patch patch Federico Fissore 2006-10-06 13:27 0000 11.21 KB Details | Diff
eclipse-sdk-3.2.1-usebuiltlauncher.patch eclipse-sdk-3.2.1-usebuiltlauncher.patch patch Federico Fissore 2006-10-06 13:27 0000 11.41 KB Details | Diff
eclipse-sdk-3.2.1-webapp-tomcat55.patch eclipse-sdk-3.2.1-webapp-tomcat55.patch patch Federico Fissore 2006-10-06 13:27 0000 4.70 KB Details | Diff
splash.bmp splash.bmp application/octet-stream Federico Fissore 2006-10-06 13:28 0000 394.15 KB Details
emerge_info emerge_info text/plain Federico Fissore 2006-10-06 13:28 0000 3.00 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 150314 depends on: Show dependency tree
Bug 150314 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-10-06 13:12 0000
Hi all
This is, from top to bottom, an explanation of the changes:

* Changed SRC_URI as I'm currently storing patches in my local "files" folder.
That's easier

* Changed dev-java/ant dependency. This solves bug #148974

* src_unpack function now calls, at its end, the function "apply-patchset":
(almost) all patches moved there

* Cleaned up src_install: commented insinto e moved exeinto

* apply-patchset function: here is where I've collected the fedora patchset.
Patches are applied in the same order as in fedora's file "eclipse.spec" (rows:
381 to 486). Two patch "subsets" weren't applied because they make the build
fail. Further investigation will follow. Attached you find the whole patcheset
(even the patches that I can't apply)

* fix-swt-targets function: here the missing patch (that causes the "almost" at
point 3) is applied. Its file is named "-gentoo-" as the original fedora patch
did not apply: I had to review it, even removing the last lines as thery are
handled by "if use gnome..." checks. The trick here is to enable -O2 when
building native things. Eclipse actually seems a bit faster than before.

* Final note: I've tried with a branded splash screen :) Remove it if you
dislike it: I won't care. Just remember to comment the second-last "pushd"
sequence in apply-patchset function

I think this ebuild also solves bug #147217 as the patch
customBuildCallbacks.xml-add-pre.gather.bin.parts.patch adds an empty
"pre.gather.bin.parts" ant target

That's all. I look forward for some feedback

------- Comment #1 From Federico Fissore 2006-10-06 13:13:21 0000 -------
Created an attachment (id=98957) [details]
eclipse-sdk-3.2.1-r1.ebuild

------- Comment #2 From Federico Fissore 2006-10-06 13:14:45 0000 -------
Created an attachment (id=98958) [details]
diff from 3.2.1 to 3.2.1-r1

------- Comment #3 From Federico Fissore 2006-10-06 13:15:13 0000 -------
Created an attachment (id=98959) [details]
customBuildCallbacks.xml-add-pre.gather.bin.parts.patch

------- Comment #4 From Federico Fissore 2006-10-06 13:15:49 0000 -------
Created an attachment (id=98960) [details]
eclipse-sdk-3.2.1-build.patch

------- Comment #5 From Federico Fissore 2006-10-06 13:16:20 0000 -------
Created an attachment (id=98961) [details]
eclipse-sdk-3.2.1-buildDocPlugins.patch

------- Comment #6 From Federico Fissore 2006-10-06 13:16:38 0000 -------
Created an attachment (id=98962) [details]
eclipse-sdk-3.2.1-bz162177.patch

------- Comment #7 From Federico Fissore 2006-10-06 13:17:59 0000 -------
Created an attachment (id=98963) [details]
eclipse-sdk-3.2.1-compare-create-api.patch

------- Comment #8 From Federico Fissore 2006-10-06 13:18:25 0000 -------
Created an attachment (id=98964) [details]
eclipse-sdk-3.2.1-disable-junit4-apt.patch

------- Comment #9 From Federico Fissore 2006-10-06 13:18:47 0000 -------
Created an attachment (id=98965) [details]
eclipse-sdk-3.2.1-ecj-classpath.patch

------- Comment #10 From Federico Fissore 2006-10-06 13:19:19 0000 -------
Created an attachment (id=98967) [details]
eclipse-sdk-3.2.1-ecj-gcj.patch

------- Comment #11 From Federico Fissore 2006-10-06 13:19:33 0000 -------
Created an attachment (id=98968) [details]
eclipse-sdk-3.2.1-ecj-rpmdebuginfo.patch

------- Comment #12 From Federico Fissore 2006-10-06 13:20:14 0000 -------
Created an attachment (id=98969) [details]
eclipse-sdk-3.2.1-fileinitializer.patch

------- Comment #13 From Federico Fissore 2006-10-06 13:20:31 0000 -------
Created an attachment (id=98971) [details]
eclipse-sdk-3.2.1-gentoo-libswt-enableallandO2.patch

------- Comment #14 From Federico Fissore 2006-10-06 13:20:53 0000 -------
Created an attachment (id=98972) [details]
eclipse-sdk-3.2.1-gnuformatterjdt.patch

------- Comment #15 From Federico Fissore 2006-10-06 13:21:14 0000 -------
Created an attachment (id=98973) [details]
eclipse-sdk-3.2.1-gnuformatterjdtui.patch

------- Comment #16 From Federico Fissore 2006-10-06 13:21:31 0000 -------
Created an attachment (id=98974) [details]
eclipse-sdk-3.2.1-helpindexbuilder.patch

------- Comment #17 From Federico Fissore 2006-10-06 13:21:53 0000 -------
Created an attachment (id=98975) [details]
eclipse-sdk-3.2.1-icu4j-build-files.patch

------- Comment #18 From Federico Fissore 2006-10-06 13:22:15 0000 -------
Created an attachment (id=98976) [details]
eclipse-sdk-3.2.1-javadoclinks.patch

------- Comment #19 From Federico Fissore 2006-10-06 13:22:37 0000 -------
Created an attachment (id=98977) [details]
eclipse-sdk-3.2.1-launcher-link.patch

------- Comment #20 From Federico Fissore 2006-10-06 13:22:57 0000 -------
Created an attachment (id=98978) [details]
eclipse-sdk-3.2.1-libswt-xpcomgcc4.patch

------- Comment #21 From Federico Fissore 2006-10-06 13:23:17 0000 -------
Created an attachment (id=98979) [details]
eclipse-sdk-3.2.1-libupdatebuild.patch

------- Comment #22 From Federico Fissore 2006-10-06 13:23:37 0000 -------
Created an attachment (id=98981) [details]
eclipse-sdk-3.2.1-libupdatebuild2.patch

------- Comment #23 From Federico Fissore 2006-10-06 13:23:59 0000 -------
Created an attachment (id=98982) [details]
eclipse-sdk-3.2.1-pde.build-add-package-build.patch

------- Comment #24 From Federico Fissore 2006-10-06 13:24:25 0000 -------
Created an attachment (id=98983) [details]
eclipse-sdk-3.2.1-searchindexlucene.patch

------- Comment #25 From Federico Fissore 2006-10-06 13:24:52 0000 -------
Created an attachment (id=98984) [details]
eclipse-sdk-3.2.1-swt-firefox.2.patch

------- Comment #26 From Federico Fissore 2006-10-06 13:25:12 0000 -------
Created an attachment (id=98985) [details]
eclipse-sdk-3.2.1-swt-firefox.patch

------- Comment #27 From Federico Fissore 2006-10-06 13:25:36 0000 -------
Created an attachment (id=98986) [details]
eclipse-sdk-3.2.1-swt-rm-ON_TOP.patch

------- Comment #28 From Federico Fissore 2006-10-06 13:26:09 0000 -------
Created an attachment (id=98987) [details]
eclipse-sdk-3.2.1-swttools.patch

------- Comment #29 From Federico Fissore 2006-10-06 13:26:30 0000 -------
Created an attachment (id=98988) [details]
eclipse-sdk-3.2.1-tomcat55.patch

------- Comment #30 From Federico Fissore 2006-10-06 13:26:48 0000 -------
Created an attachment (id=98989) [details]
eclipse-sdk-3.2.1-tomcat55-build.patch

------- Comment #31 From Federico Fissore 2006-10-06 13:27:09 0000 -------
Created an attachment (id=98990) [details]
eclipse-sdk-3.2.1-updatehomedir.patch

------- Comment #32 From Federico Fissore 2006-10-06 13:27:39 0000 -------
Created an attachment (id=98991) [details]
eclipse-sdk-3.2.1-usebuiltlauncher.patch

------- Comment #33 From Federico Fissore 2006-10-06 13:27:54 0000 -------
Created an attachment (id=98992) [details]
eclipse-sdk-3.2.1-webapp-tomcat55.patch

------- Comment #34 From Federico Fissore 2006-10-06 13:28:24 0000 -------
Created an attachment (id=98993) [details]
splash.bmp

------- Comment #35 From Federico Fissore 2006-10-06 13:28:54 0000 -------
Created an attachment (id=98994) [details]
emerge_info

if you care

------- Comment #36 From Federico Fissore 2006-10-06 13:34:22 0000 -------
don't forget to put the sh file "eclipse-3.2" in your overlay files folder

------- Comment #37 From Federico Fissore 2006-10-06 16:27:29 0000 -------
to speed things up, I've set up this link
http://www.fridrik.it/files/eclipse-sdk.tar.bz2

------- Comment #38 From Vlastimil Babka (Caster) 2006-10-07 03:56:08 0000 -------
*** Bug 150109 has been marked as a duplicate of this bug. ***

------- Comment #39 From Josh Nichols (RETIRED) 2006-10-07 19:44:55 0000 -------
Fixed in 3.2.1-r1. Thanks again for the help!

------- Comment #40 From Carsten Lohrke 2006-10-08 06:37:16 0000 -------
One strong point of Gentoo is not to force any branding realted stuff on users.
Please revert the splash change or make it optional via the branding use flag.

------- Comment #41 From Josh Nichols (RETIRED) 2006-10-08 08:06:11 0000 -------
USE=branding it is then.

In the future, please open a separate bug for this type of thing, instead of
re-opening the bug that brought it into being.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug