Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 150097
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: José Alberto Suárez López <bass@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Charlie Shepherd (RETIRED) <masterdriverz@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
cleanup.patch First patch - general cleanup patch Charlie Shepherd (RETIRED) 2006-10-04 13:04 0000 8.53 KB Details | Diff
list.patch Second patch - add list action and change operation of pretend action patch Charlie Shepherd (RETIRED) 2006-10-04 13:05 0000 3.50 KB Details | Diff
list.patch Updated second patch - add list action and change operation of pretend action patch Charlie Shepherd (RETIRED) 2006-10-07 06:38 0000 3.50 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 150097 depends on: Show dependency tree
Bug 150097 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-10-04 13:03 0000
Here are two patches for localepurge-0.5.2. The first is a general cleanup
patch, the second moves what used to be the pretending action to a new action
called list (I felt this was more appropriate for what it does), and creates a
new pretend action printing all the files that would be deleted if run without
pretend. See a more detailed summary below.

Patch 1:
eerror echoes to stderr
Line up and help text and put it in alphabetical order
Put option parsing in alphabetical order
Change option parsing to elifs, and add an else clause for unrecognised options
Apply consistant coding style:
    Indent = 4 spaces
    if [ .. ]; then
Remove replicated code
Add verbosity requirement to pretend status info

Patch 2:
Define default ACTION as /bin/rm
Define new print function
Add list to option parsing and help
Crash out on list and pretend enabled at the same time
Change /bin/rm to ACTION
Change PRETEND to LIST in certain places
Add pretend status message and change wording of list status message

------- Comment #1 From Charlie Shepherd (RETIRED) 2006-10-04 13:04:44 0000 -------
Created an attachment (id=98793) [details]
First patch - general cleanup

------- Comment #2 From Charlie Shepherd (RETIRED) 2006-10-04 13:05:39 0000 -------
Created an attachment (id=98794) [details]
Second patch - add list action and change operation of pretend action

------- Comment #3 From Charlie Shepherd (RETIRED) 2006-10-07 06:38:52 0000 -------
Created an attachment (id=99042) [details]
Updated second patch - add list action and change operation of pretend action

The original second patch had a syntax error - bash would choke on "else;".
This is now fixed.

------- Comment #4 From José Alberto Suárez López 2006-10-13 03:28:39 0000 -------
thanks, nice patch :)
0.5.3 now in CVS

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug