Bugzilla Bug 149888

New version with tag and ipod writing.

is there a chance that there will be a "gnome" useflag introduced in the
rhythmbox ebuild? rhythmbox does not necesseraly depend on "gnome-media". it
would be nice to turn this on and off for people who want to use rhythmbox
without (most of) gnome. 

That's a good idea. You can generalize it to all GTK applications which can
work without gnome specific libs. Those applications are supposed to be able to
run under xfce.

Your idea sounds good but it'd go a long way if you could provide a working
ebuild :) (even if it's not perfect, it helps a lot)

Created an attachment (id=98910) [details]
rhythmbox-0.9.6-r2.ebuild

an experimental(!) ebuild based heavily on rhythmbox-0.9.5.ebuild introducing
"cdr" and "gnome" useflags.

I'm really busy with school right now if somebody else wants to take this.

On my system (full ~x86), the provided rhythmbox-0.9.6-r2 ebuild does not
compile:
/bin/sh ../../libtool --mode=link i686-pc-linux-gnu-gcc  -O2 -march=athlon-xp
-fomit-frame-pointer -pipe   -o libgeneric-player.la -rpath  -module
-avoid-version rb-generic-player-plugin.lo rb-generic-player-source.lo
rb-psp-source.lo rb-nokia770-source.lo  -lz 
libtool: link: only absolute run-paths are allowed

Created an attachment (id=99533) [details]
revision of previously attached ebuild, without compile problems

I got the same libtool error, it was caused by some unintended whitespace in
the ebuild ending the with-cd-burning line.  The second attached ebuild fixes
this problem.

There are problems with disabling the cdr use flag, detailed in further
comments.

With the cdr use flag disabled, I get the following fatal compile time error.

 i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../..
-DGNOMELOCALEDIR=\"/usr/share/locale\" -DG_LOG_DOMAIN=\"Rhythmbox\" -I../..
-I../../lib -I../../metadata -I../../player -I../../rhythmdb -I../../widgets
-I../../sources -I../../iradio -I../../podcast -I../../remote -I../../remote
-I../../plugins -I../../shell -DPIXMAP_DIR=\"/usr/share/pixmaps\"
-DSHARE_DIR=\"/usr/share/rhythmbox\" -DDATADIR=\"/usr/share\" -pthread
-DORBIT2=1 -I/usr/include/totem/1/plparser -I/usr/include/gtk-2.0
-I/usr/include/libxml2 -I/usr/include/gnome-vfs-2.0
-I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-vfs-module-2.0
-I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -DDBUS_API_SUBJECT_TO_CHANGE
-I/usr/include/hal -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include
-DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0
-I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0
-I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0
-I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
-I/usr/include/gnome-keyring-1 -I/usr/include/orbit-2.0
-I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0
-I/usr/include/freetype2 -I/usr/include/libxml2 -I/usr/include/libglade-2.0
-I/usr/include/gnome-vfs-module-2.0 -pthread -I/usr/include/gstreamer-0.10
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2
-D_XOPEN_SOURCE -D_BSD_SOURCE -march=pentium4 -O3 -pipe -MT
rb-audiocd-plugin.lo -MD -MP -MF .deps/rb-audiocd-plugin.Tpo -c
rb-audiocd-plugin.c  -fPIC -DPIC -o .libs/rb-audiocd-plugin.o
rb-audiocd-plugin.c:33:33: error: nautilus-burn-drive.h: No such file or
directory
rb-audiocd-plugin.c:353: error: expected ')' before '*' token
rb-audiocd-plugin.c: In function 'impl_activate':
rb-audiocd-plugin.c:465: warning: assignment makes pointer from integer without
a cast
rb-audiocd-plugin.c:470: error: 'NautilusBurnDrive' undeclared (first use in
this function)
rb-audiocd-plugin.c:470: error: (Each undeclared identifier is reported only
once
rb-audiocd-plugin.c:470: error: for each function it appears in.)
rb-audiocd-plugin.c:470: error: 'drive' undeclared (first use in this function)
rb-audiocd-plugin.c:470: error: expected expression before ')' token
rb-audiocd-plugin.c:473: warning: passing argument 2 of
'gnome_vfs_volume_monitor_get_volume_for_path' makes pointer from integer
without a cast
make[4]: *** [rb-audiocd-plugin.lo] Error 1

Created an attachment (id=99606) [details]
rhythmbox-0.9.6-r2.ebuild (fixed?)

another day, another try...

* seems that nautilus-cd-burner is necessary for playing audio cds as well
* while I'm here... add gnome-keyring support (dependency maybe too high, but
it is stable on [almost] all archs)

r2 complied fine for me with +cdr and +gnome. It may be noted that the cd
plugin do not like to be compiled with LDFLAGS="-Wl,--as-needed". It complains
about not finding the symbol mb_GetResultInt. This doesn't effect most people
and recompiling it without that LDFLAG is a resonable fix.

The problem is that audiocd plugin is not linking to musicbrainz, so when you
have USE="-musicbrainz" it should be fine whereas if USE="musicbrainz" the
plugin would use musicbrainz code without linking to it.

I made a patch that fixes this issue. I'm doing some tests with another user
before posting it there. I think this bug should also be pushed upstream, so if
Sylvain wants to do it, go ahead.

Created an attachment (id=100780) [details]
Patch to get audiocd plugin to link to musicbrainz

Created an attachment (id=100781) [details]
patch from 0.9.5 to 0.9.6

By the way, I think that a gnome USE is inapproriate since rhythmbox is a gnome
app.

Note:
 I have not verified if the dbus patch still applies since I worked on the
ebuild provided here (named 0.9.6-r2).

ok after some more testing, it appears that my patch is not working (as in
breaks compilation) if you have USE="-cdr".
Any help to get this fixed appreciated

bumped on cvs. When you got the patch working open a new bug so we can review
it again.

Thanks

opened a bug upstream http://bugzilla.gnome.org/show_bug.cgi?id=371178

I'll create a new bug when this will be solved upstream.