Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 149274 - net-fs/openafs-kernel-1.4.2-rc4 module does not load in gentoo-sources-2.6.18
Summary: net-fs/openafs-kernel-1.4.2-rc4 module does not load in gentoo-sources-2.6.18
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Stefaan De Roeck (RETIRED)
URL:
Whiteboard:
Keywords:
: 151412 174516 (view as bug list)
Depends on: 151567
Blocks: 148429
  Show dependency tree
 
Reported: 2006-09-27 02:44 UTC by Andrej Filipcic
Modified: 2007-05-07 15:18 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
tasklist_lock patch (tasklist.patch,2.06 KB, patch)
2006-09-27 02:46 UTC, Andrej Filipcic
Details | Diff
Same patch for the 1.5-branch (tasklist_lock_1.5.12.patch,439 bytes, patch)
2006-12-14 05:10 UTC, Stefaan De Roeck (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Filipcic 2006-09-27 02:44:33 UTC
openafs-kernel-1.4.2-rc4 module does not load in gentoo-sources-2.6.18 due to tasklist_lock undefined (at least on amd64). tasklist_lock seems to be not exported anymore. From few mailing list archives it seems to me it is not needed from 2.6.18. The patch attached works for me, although the "df /afs" shows 162129586585337855983616 instead of 9000000 as up to now (irrelevant anyway).
Comment 1 Andrej Filipcic 2006-09-27 02:46:12 UTC
Created attachment 98205 [details, diff]
tasklist_lock patch
Comment 2 Stefaan De Roeck (RETIRED) gentoo-dev 2006-09-29 12:19:05 UTC
The problem has already been mentioned on the openafs mailing list. 
https://lists.openafs.org/pipermail/openafs-info/2006-September/023749.html

It mentions the following patch available in cvs:
http://www.openafs.org/cgi-bin/wdelta/MAIN/tasklist-lock-redux-20060922?diff&f=u

At first sight it seems to touch the same code etc., but I'm no kernel hacker, so could you try if this works as well? If it does, I'd prefer adding a patch that's already in the upstream cvs. I'm sorry if you put a lot of effort in it...

Thanks a lot for reporting, and for providing a patch!!
Comment 3 Andrej Filipcic 2006-09-29 14:04:04 UTC
The patch looks OK to me. Unfortunately, it does not apply cleanly to rc4. Anyway, it seems it will be included in next release, some we can wait a couple of days.

Thanks.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2006-10-15 00:41:37 UTC
*** Bug 151412 has been marked as a duplicate of this bug. ***
Comment 5 Stefaan De Roeck (RETIRED) gentoo-dev 2006-10-15 03:30:14 UTC
It seems upstream is still debating on how to fix this properly, I'm afraid we'll have to wait some more. People who want to run the new kernel now, can use the attached patch...
Comment 6 Daniel Drake (RETIRED) gentoo-dev 2006-10-15 17:36:04 UTC
Stefaan, while this is unresolved, any chance you could modify the stable tree ebuilds to bail out on 2.6.18?
Comment 7 Stefaan De Roeck (RETIRED) gentoo-dev 2006-10-17 23:41:34 UTC
(In reply to comment #6)
> Stefaan, while this is unresolved, any chance you could modify the stable tree
> ebuilds to bail out on 2.6.18?

The problem in stable went a bit further than 2.6.18 only. I filed bug #151567 to stabilize openafs-1.4.1, because the current stable wouldn't build for gentoo-sources-2.6.17-r4.  I will make openafs-1.4.1 bail out on unsupported kernels as soon as the stabling is done.  

Also, I'm happy to announce that openafs-1.4.2 is in the tree, and that it seems to build against 2.6.18.  Could this be tested, please?
Comment 8 Daniel Drake (RETIRED) gentoo-dev 2006-10-19 19:13:54 UTC
I looked at fixing 1.4.1 for 2.6.18 but it appears to be no easy task
Comment 9 Alexandre Ferreira 2006-10-25 07:29:40 UTC
I tried compiling openafs-1.4.2 with 2.6.18-r1 and the missing symbol problem is still present.
Comment 10 Stefaan De Roeck (RETIRED) gentoo-dev 2006-10-27 12:19:08 UTC
Could you try enabling "CONFIG_KEYS" in your kernel configuration?  It seems to fix the problem on my computer...  
(I have yet to figure out whether CONFIG_KEYS could be an undesirable requirement, or even why it would be a requirement. I have contacted upstream about this)
Comment 11 Alexandre Ferreira 2006-11-03 20:05:41 UTC
Adding CONFIG_KEYS does solve the problem. The module compiled and worked perfectly.
Comment 12 Daniel Drake (RETIRED) gentoo-dev 2006-11-09 06:29:45 UTC
As I'll be filing a 2.6.18 stable request very soon, any chance the 1.4.1 ebuild could be fixed to bail out on >=2.6.18 now?
Comment 13 Stefaan De Roeck (RETIRED) gentoo-dev 2006-11-09 07:17:42 UTC
Done.  Thanks for your patience.  And good luck with 2.6.18!!

(In reply to comment #12)
> As I'll be filing a 2.6.18 stable request very soon, any chance the 1.4.1
> ebuild could be fixed to bail out on >=2.6.18 now?
> 

Comment 14 Daniel Drake (RETIRED) gentoo-dev 2006-11-10 05:59:39 UTC
Thanks, I guess we can close this bug then
Comment 15 Stefaan De Roeck (RETIRED) gentoo-dev 2006-11-10 06:21:24 UTC
A remark for the people running 1.4.2 on 2.6.18: CONFIG_KEYS is currently required in the kernel, but this is considered a bug. Upstream intends to fix this.

For more information, see the openafs-info mailinglist, message by Jeffrey Hutzelman, on Oct 30, 2006 7:25 PM, subject: Re: [OpenAFS] tasklist_lock undefined Linux 2.6.18, OpenAFS 1.4.2.  It contains a patch proposal I'm supposed to try out, but I still haven't gotten to that.  Feel free to try it yourself...
Comment 16 Stefaan De Roeck (RETIRED) gentoo-dev 2006-11-11 00:14:39 UTC
Tried the patch I mentioned, it works, put the result in openafs-kernel-1.4.2-r1. This means it should now work without the CONFIG_KEYS option in the kernel. 
Comment 17 Alan Jones 2006-12-14 04:45:06 UTC
I've got the same error here with 1.5.12 on 2.6.18 and 2.6.19 - will try 2.6.17 if I can't get 1.4.2 to work properly with 2.6.17 (having issues with some applications claiming there's no free space when saving).
Comment 18 Stefaan De Roeck (RETIRED) gentoo-dev 2006-12-14 05:10:57 UTC
Created attachment 104039 [details, diff]
Same patch for the 1.5-branch

(In reply to comment #17)
> I've got the same error here with 1.5.12 on 2.6.18 and 2.6.19 - will try 2.6.17
> if I can't get 1.4.2 to work properly with 2.6.17 (having issues with some
> applications claiming there's no free space when saving).

Could you try this patch?  It's an attempt to port the 1.4.2-r1 patch to 1.5.12. 

Concerning the free space, you might be interested in: https://lists.openafs.org/pipermail/openafs-devel/2006-November/014507.html

A side note: if you're using a mixed 1.4 / 1.5 setup, I'm very interested to know how well releasing volumes from 1.5 to 1.4 works on your setup. 

Hope this helps,
Stefaan
Comment 19 Axel Mueller 2007-03-28 06:21:01 UTC
The bug still (or again?) exists in openafs-kernel-1.4.4 and gentoo-sources-2.6.19-r5
libafs: Unknown symbol tasklist_lock
I just upgraded from openafs-kernel-1.4.4 to openafs-kernel-1.4.2-r2.
Enabling "CONFIG_KEYS" in my kernel configuration  did not help either.
Comment 20 Axel Mueller 2007-03-29 07:47:20 UTC
Correction. Enabling "CONFIG_KEYS" did help to solve the problem. I had to reemerge openafs-kernel after recompiling the kernel.
Comment 21 Stefaan De Roeck (RETIRED) gentoo-dev 2007-03-29 08:09:59 UTC
Glad to hear.  Thanks for reporting!!
Comment 22 Jakub Moc (RETIRED) gentoo-dev 2007-04-13 20:37:20 UTC
*** Bug 174516 has been marked as a duplicate of this bug. ***
Comment 23 Stefaan De Roeck (RETIRED) gentoo-dev 2007-04-19 07:25:50 UTC
If CONFIG_KEYS really was required to build and load openafs, I would add the requirement to the ebuild.  However, all my systems run without CONFIG_KEYS, so adding the requirement would probably just annoy many people when it's not necessary.  
If anyone has a clue, or can report on another system running well without CONFIG_KEYS, it would be appreciated.  
Comment 24 Axel Mueller 2007-05-07 12:49:37 UTC
CONFIG_KEYS is also needed for new kernel 2.6.20-r7 and openafs-kernel-1.4.4
Comment 25 Stefaan De Roeck (RETIRED) gentoo-dev 2007-05-07 14:54:14 UTC
I'm currently running 2.6.20-gentoo-r4 with openafs-1.4.4.  My kernel configuration contains:
# CONFIG_KEYS is not set

In case your kernel is also without CONFIG_KEYS:
Maybe the newest openafs-1.5.19 doesn't have the same problem?  There's some mention of tasklist_lock in the changelog.  
If the problem persists, I'm interested to learn:
What does "nm /lib/modules/$(uname -r)/fs/openafs/libafs.ko | grep tasklist" show?
What does "nm {kernel-source}/vmlinux | grep tasklist" show?

Thanks,
Stefaan
Comment 26 Axel Mueller 2007-05-07 15:18:48 UTC
$ grep CONFIG_KEYS /usr/src/linux/.config
CONFIG_KEYS=y

Without CONFIG_KEYS set I can compile the openafs module (there is a warning about tasklist_lock) but I cannot load it. 

$ nm /lib/modules/$(uname -r)/fs/openafs/libafs.ko | grep tasklist
w tasklist_lock

nm /usr/src/linux-2.6.19-gentoo-r5/vmlinux | grep tasklist
c0465c00 D tasklist_lock

Identical results for kernel 2.6.20-r7