First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 148778
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Alastair Tse (RETIRED) <liquidx@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Timo Kamph <timo@kamph.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
gnutls-1.4.4-r1.ebuild Fixed ebuild text/plain Timo Kamph 2006-09-23 07:13 0000 1.75 KB Details
gnutls-1.4.4-r1.ebuild.patch Fix as patch patch Timo Kamph 2006-09-23 07:17 0000 656 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 148778 depends on: Show dependency tree
Show dependency graph
Bug 148778 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2006-09-23 07:10 0000 
Problem:
The gnutls-1.4.4-r1 ebuild unconditionally (r)depends on gettext, even if the
nls use flag is not set.

Solution:
The ebuild should check the nls use flag and only add sys-devel/gettext to
RDEPEND if the flag is set.

I'll attatch a fixed ebuild.

------- Comment #1 From Timo Kamph 2006-09-23 07:13:41 0000 ------- 
Created an attachment (id=97852) [edit]
Fixed ebuild

------- Comment #2 From Timo Kamph 2006-09-23 07:17:39 0000 ------- 
Created an attachment (id=97854) [edit]
Fix as patch

This is a diff between the original and the fixed ebuild file.

------- Comment #3 From Jakub Moc (RETIRED) 2006-09-23 07:18:57 0000 ------- 
(From update of attachment 97852 [edit])
How exactly will this work? You didn't change anything except for adding the
use flag. 

You need $(use_enable nls) there (and no, I didn't check if it's even honored
by the build system).

------- Comment #4 From Jakub Moc (RETIRED) 2006-09-23 07:22:58 0000 ------- 
Plus gettext shouldn't be in RDEPEND:

RDEPEND="nls? ( virtual/libintl )
   ...."

DEPEND="${RDEPEND}
   nls? ( sys-devel/gettext )"

------- Comment #5 From Timo Kamph 2006-09-23 07:39:27 0000 ------- 
(In reply to comment #3)
> (From update of attachment 97852 [edit] [edit])
> How exactly will this work? You didn't change anything except for adding the
> use flag. 

I added a check to RDEPEND, this is how it's done in other ebuilds and with the
other use flags in the gnutls ebuild. The important part of the fix is:

-       sys-devel/gettext"
+       nls? ( sys-devel/gettext )"

in RDEPEND=...

So please check it again.

------- Comment #6 From Timo Kamph 2006-09-23 07:41:52 0000 ------- 
(In reply to comment #4)
> Plus gettext shouldn't be in RDEPEND:
> 
> RDEPEND="nls? ( virtual/libintl )
>    ...."
> 
> DEPEND="${RDEPEND}
>    nls? ( sys-devel/gettext )"
> 

Well, I just want to get gettext out of my non-nls system.
Someone else put in into RDEPNED in the first place.

------- Comment #7 From Daniel Black 2006-09-23 15:16:13 0000 ------- 
by bad. Thanks Timo for bringing it to my attentioned. Problem should be fixed
now.
First Last Prev Next    No search results available      Search page      Enter new bug