First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 148390
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Benjamin Smee (strerror) (RETIRED) <strerror@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Paul Bredbury <brebs@sent.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
cryptsetup-luks-1.0.3-r2.patch cryptsetup-luks-1.0.3-r2.patch patch Paul Bredbury 2006-09-20 09:04 0000 1.28 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 148390 depends on: 192556 Show dependency tree
Bug 148390 blocks: 189924
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-09-20 09:02 0000
Hi, the usage of linux_chkconfig_present in the sys-fs/cryptsetup-luks ebuilds
will always fail, because linux-info_pkg_setup is not called first, so
KV_OUT_DIR in linux-info will not have been defined.

Here is a patch to fix it, whilst hopefully still satisfying bug #141182 via
usage of the global "build" USE flag. It also uses the "check_extra_config"
routine for checking and reporting the problem, rather than pointing the user
at a kernel option whose location keeps changing, depending on the kernel
version (it's changed again in kernel 2.6.18).

The sys-fs/cryptsetup ebuilds should be changed similarly.

------- Comment #1 From Paul Bredbury 2006-09-20 09:04:17 0000 -------
Created an attachment (id=97550) [edit]
cryptsetup-luks-1.0.3-r2.patch

------- Comment #2 From Lars Weiler (RETIRED) 2006-09-22 07:24:52 0000 -------
The problem is, we don't use the 'build' nor the 'livecd' USE-flag during our
GRP-set building.

------- Comment #3 From Paul Bredbury 2006-09-22 07:50:28 0000 -------
Then ignore the ewarn, or add a "grp" USE flag ;)

------- Comment #4 From Benjamin Smee (strerror) (RETIRED) 2006-10-12 04:06:14 0000 -------
fixed in cvs, try -r3

------- Comment #5 From Chris Gianelloni (RETIRED) 2007-08-23 17:24:09 0000 -------
OK.  This is still incorrect.

Running the linux-info_pkg_setup on a system with an unconfigured kernel will
*always* fail.  This means building GRP, LiveCD, or using the Installer.

Packages that are not kernel modules should *never* fail on an unconfigured
kernel.  We never use the "build" USE flag outside of building a stage1
tarball, so the suggestion to use it was completely incorrect.  Instead, the
build check should be removed, and it should be replaced with proper checking. 
Warnings are fine.  Failures are not.

Basically, you have no need to run linux-info_pkg_setup, at all.  Remove the
USE=build check, run the dm-crypt_check, crypto_check, and cbc_check
unconditionally, and remove linux-info_pkg_setup completely, as it doesn't do
anything this package needs to build.  It will complain about the missing
kernel, but it won't fail.

------- Comment #6 From Chris Gianelloni (RETIRED) 2007-09-13 00:15:40 0000 -------
If nobody has any objections, I can go ahead and add this.  This is pretty much
what we did for the 2006.1/2007.0 releases, so we know it works.

------- Comment #7 From Benjamin Smee (strerror) (RETIRED) 2007-09-13 02:35:38 0000 -------
go for it.

------- Comment #8 From Chris Gianelloni (RETIRED) 2007-09-14 21:32:18 0000 -------
Ugh... I think linux-info has changed recently.

OK.  I've gone ahead and made the changes to cryptsetup/cryptsetup-luks, but
some code needs to change in linux-info.  As such, I am leaving this bug open
in an attempt to keep you from getting dupes.  I'll close it once the other bug
is resolved and this bug will magically be "fixed" along with linux-info.

------- Comment #9 From Chris Gianelloni (RETIRED) 2008-01-25 18:47:15 0000 -------
Yay!

First Last Prev Next    No search results available      Search page      Enter new bug