Bugzilla Bug 147570

This bug is for tracking any issues before we request arches mark 3.5.4 stable.
  Who wants to chime in first?

To carlo: do you think we will have the patch set ready for kde-base/kdebase
and kde-base/kdm? I'd like to have the grub fixes patch in kde-base/kdebase
already applied before stabilization.

I've another kdelibs revision bump sitting - will commit tomorrow. Remaining
open problems are the broken hal support and speech-tools + festival GCC 4.x
breakage.

I'm willing to test the current state of KDE 3.5.4 if needed, I will be
rebuilding my system with gcc 4 anyway...

any more thoughts/objections on requesting stabilization from the arches?

Are there any potential problems here that might require testing?

Broken hal support is the only one that worries me, but I don't know the
specifics of it.

changing to 3.5.5, since it's almost 30 days in portage.  any other thoughts
from the kde herd on 3.5.5?

I have been testing 3.5.5 at work on the stable system there with no issues.
Seems to work very well there (amd64 system) as well as on my two unstable
systems. I think it is a good stable candidate. Right now hal support seems to
be working - I have been busy though and am not familiar with the issue.

I would certainly support stabilising 3.5.5.

Ok, I plan to ask arches to stabilize 3.5.5 in the next few days unless someone
objects here.

Okay, I'm going forth with asking arches to stabilize KDE 3.5.5.  We were going
to ask for 3.5.4, but 3.5.5 seems to be running more stably and it has been in
portage for > 30 days now.

Arches: This should work just like your stabilization of KDE 3.5.2.  Obviously
it's a big task and I'm sure there will be some bumps on the way.  Please fire
questions or concerns here.

Created an attachment (id=101392) [edit]
kdepackages 07/11/2006_1430

This should be all packckages to be stabled for KDE

Should we stable latest available for monolithic?

(In reply to comment #11)
> Created an attachment (id=101392) [edit]
> kdepackages 07/11/2006_1430
> 
> This should be all packckages to be stabled for KDE
> 

Please, stabilize latest revisions (e.g. kde-base/kdm-3.5.5-r1).

(In reply to comment #13)
> (In reply to comment #11)
> > Created an attachment (id=101392) [edit]
> > kdepackages 07/11/2006_1430
> > 
> > This should be all packckages to be stabled for KDE
> > 
> Please, stabilize latest revisions (e.g. kde-base/kdm-3.5.5-r1).

 I knew I forgot a step...in a few hours I will finish that off.

Created an attachment (id=101413) [edit]
kdepackages 07/11/2006_2245

updated list with revisions...may contain errors, report them or update the
list yourself

You missed kdelibs and arts

Created an attachment (id=101526) [edit]
kdepackages 09/11/2006_1007

(In reply to comment #16)
> You missed kdelibs and arts

 And a lot more.

don't forget the kdebindings stuff, like smoke, qtruby, and korundum (to name a
few).

Created an attachment (id=101534) [edit]
kdepackages 09/11/2006_1431

(In reply to comment #18)
> don't forget the kdebindings stuff, like smoke, qtruby, and korundum (to name a
> few).
 Everything that is pulled in by kdebindings-meta is now in the list.  Please
have a look (at the end of the file).

Created an attachment (id=101585) [edit]
 kdepackages 10/11/2006_0756

This should be complete now, a typo for kdebindings-meta and I really forgot
kde-meta itself. :)

It looks like we are missing a revision bump for ~kde-base/libkdeedu-3.5.5 (or
a dependency needs to be adjusted). When trying to to an emerge -uDNv world
with kde-meta installed, I get the following error:

emerge: there are no ebuilds to satisfy "~kde-base/libkdeedu-3.5.5".
(dependency required by "kde-base/klatin-3.5.5" [ebuild])
!!! Problem resolving dependencies for kde-base/kde-meta
!!! Depgraph creation failed.

Looking in CVS shows libkdeedu-3.5.4 as the latest revision.

(In reply to comment #21)
> It looks like we are missing a revision bump for ~kde-base/libkdeedu-3.5.5 (or
> a dependency needs to be adjusted). When trying to to an emerge -uDNv world
> with kde-meta installed, I get the following error:
> 
> emerge: there are no ebuilds to satisfy "~kde-base/libkdeedu-3.5.5".
> (dependency required by "kde-base/klatin-3.5.5" [ebuild])
> !!! Problem resolving dependencies for kde-base/kde-meta
> !!! Depgraph creation failed.
> 
> Looking in CVS shows libkdeedu-3.5.4 as the latest revision.
> 

The whole point of split ebuilds is that you don't need to update them. If you
look at the klatin ebuild, it works with libkdeedu 3.5.4 - latest version. The
problem is that libkdeedu-3.5.4 should be added to Opfer's list.

Created an attachment (id=101591) [edit]
kdepackages 10/11/2006_1151

It's me again, two more typos found during testing the new release...it should
be the definitive list now.  (And I did not say something like that before!)

I updated kde to 3.5.5, didn't spot any problems. There were no collision
problems. I didn't run the test suites after I had several failures.
It runs smooth here, revdep-rebuild shows nothing broken.

Please note the following two things:
* kdelibs:
  QA Notice: the following files are setXid, dyn linked, and using lazy
bindings
  LAZY usr/kde/3.5/bin/start_kdeinit

* kdebase:
  QA Notice: the following files are setXid, dyn linked, and using lazy
bindings
  LAZY usr/kde/3.5/bin/kcheckpass

kde-base/kde-i18n-3.5.5 is not in the list (It doesn't belong to kde{,-meta}
directly but should also be marked stable IMHO)


modular kde
Portage 2.1.1-r1 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.4-r4,
2.6.18.1 i686)
=================================================================
System uname: 2.6.18.1 i686 Genuine Intel(R) CPU           T2300  @ 1.66GHz
Gentoo Base System version 1.12.6
Last Sync: Thu, 09 Nov 2006 07:30:01 +0000
ccache version 2.3 [disabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.3.5-r3, 2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c"
CXXFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--nospinner"
FEATURES="autoconfig collision-protect distlocks metadata-transfer
parallel-fetch sandbox sfperms strict test userfetch userpriv usersandbox"
GENTOO_MIRRORS="http://mirror.switch.ch/mirror/gentoo/ http://gentoo.inode.at/"
LINGUAS="en de en_GB de_CH"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X a52 aac acpi alsa apache2 asf berkdb bitmap-fonts cairo cdr cdrom
cli cracklib crypt cups dbus divx dlloader dri dts dvd dvdr dvdread eds
elibc_glibc emboss encode fam ffmpeg firefox flac fortran gdbm gif gnome gpm
gstreamer gtk hal iconv input_devices_keyboard input_devices_mouse ipv6 isdnlog
java jpeg kde kdeenablefinal kernel_linux ldap libg++ linguas_de linguas_de_CH
linguas_en linguas_en_GB mad mikmod mmx mono mp3 mpeg ncurses nls nptl nptlonly
ogg opengl oss pam pcre perl png ppds pppd python qt3 qt4 quicktime readline
reflection rtsp samba sdl session smp spell spl sse sse2 sse3 ssl svg tcpd test
tetex theora threads truetype truetype-fonts type1-fonts udev unicode
userland_GNU vcd video_cards_fbdev video_cards_i810 video_cards_vesa vorbis
win32codecs wxwindows x264 xine xml xorg xprint xv xvid zlib"
Unset:  CTARGET, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS,
PORTDIR_OVERLAY

monolithic kde
Portage 2.1.1-r1 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.4-r3,
2.6.17.13 i686)
=================================================================
System uname: 2.6.17.13 i686 AMD Athlon(TM) XP1800+
Gentoo Base System version 1.12.6
Last Sync: Tue, 07 Nov 2006 17:50:01 +0000
ccache version 2.3 [enabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.3.5-r3, 2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=i686 -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-O2 -march=i686 -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--nospinner"
FEATURES="autoconfig ccache collision-protect distlocks fixpackages
metadata-transfer parallel-fetch sandbox sfperms strict test userfetch userpriv
usersandbox"
GENTOO_MIRRORS="http://mirror.switch.ch/mirror/gentoo/ http://gentoo.inode.at/"
LANG="en_GB.utf8"
LINGUAS="en de en_GB"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/normal"
SYNC="rsync://192.168.2.1/gentoo-portage"
USE="x86 3dnow 3dnowext X a52 aac acpi alsa apache2 bash-completion berkdb
bitmap-fonts bzip2 cairo cdr cli cracklib crypt css cups dbus divx4linux
dlloader dri dts dvd dvdr dvdread elibc_glibc emboss exif fam ffmpeg firefox
font-server fortran gdbm gif gnome gphoto2 gpm gstreamer gtk gtk2 gtkhtml hal
iconv input_devices_keyboard input_devices_mouse ipv6 isdnlog java jpeg kde
kernel_linux ldap libclamav libg++ linguas_de linguas_en linguas_en_GB
logitech-mouse mad mikmod mmx mmxext mono mozcalendar mozdevelop mozsvg mp3
mpeg ncurses network nls nptl nptlonly nvidia oav ogg opengl oss pam pcre perl
png ppds pppd python qt qt3 qt4 quicktime readline reflection samba sdl
seamonkey session spell spl ssl tcltk tcpd test tetex tiff truetype
truetype-fonts type1-fonts udev unicode usb userland_GNU vcd video_cards_none
video_cards_nv vorbis win32codecs xine xinerama xml xorg xorg-x11 xprint xv xvg
xvid zlib"
Unset:  CTARGET, INSTALL_MASK, LC_ALL, LDFLAGS, MAKEOPTS,
PORTAGE_RSYNC_EXTRA_OPTS

Created an attachment (id=101671) [edit]
kdepackages 11/11/2006_1321

(In reply to comment #24)
> kde-base/kde-i18n-3.5.5 is not in the list (It doesn't belong to kde{,-meta}
> directly but should also be marked stable IMHO)

 Added.

https://bugs.gentoo.org/show_bug.cgi?id=151652

With >KDE-3.5.2 scrolling and pasting with the 3rd mouse button doesn't work.
Could you fix this before 3.5.5 goes stable?

Just asking...

Regards
Sebastian

how do we fix it?  I don't see this as a blocker to stabilization, since you
can just change a configuration item to fix it.  There's no patches available
that I can see.

Not a blocker for sure, it's an UPSTREAM problem, not our after all.

Should we mark kdelibs-3.5.5-r5?  It depends on >=hunspell-1.0 and it doesn't
look like that's really ready to go stable? Bug #152274 was just filed for a
bunch of arches, so they're not ready for kdelibs-3.5.5-r5 stabilization.

There's also a bunch of duplicates in the last list.

(In reply to comment #29)
> Should we mark kdelibs-3.5.5-r5?  It depends on >=hunspell-1.0 and it doesn't
> look like that's really ready to go stable? Bug #152274 was just filed for a
> bunch of arches, so they're not ready for kdelibs-3.5.5-r5 stabilization.

 As mentioned in bug #152818#c2, all PIC based arches need at least -r1.  

Go for 3.5.5-r4, as hspell was added to the tree just recently. There shouldn't
be any other difference between the two.

This stablisation has broken emerge -u world for some people, see bug #154999.
Also it seems like only some of the stuff in the kdepackages list is now
stable, eg. kdelibs is, but what happened to korganiser, kwalletmanager, etc?

Chris do you have any vague idea of the _size_ of KDE?
It's not possible to commit everything on one go, for a few counts, emerge
--sync will produce a stale tree, but that's not something you can solve... CVS
is slow to commit it, and repoman will scan everything everytime too.

So please hang tight.

Created an attachment (id=101837) [edit]
kdepackages 13/11/2006_1626

Additionally you need net-libs/meanwhile, dev-python/PyQt and net-libs/ortp
stable. This version has fewer dupes (none if uniq does not lie), some more
packages and a typo less.

x86 is finished, I will stay here for a while if issues occure.

> x86 is finished, I will stay here for a while if issues occure.

Thanks for your help in this, Christian.  I imagine we'll find some issues as
we go along, but it's to be expected.  We'll take care of them as they arise.

(In reply to comment #36)
> > x86 is finished, I will stay here for a while if issues occure.
> 
> Thanks for your help in this, Christian.  I imagine we'll find some issues as
> we go along, but it's to be expected.  We'll take care of them as they arise.

kde-base/kde-env needs updating, for instance. Seems to block 3.5.5:

RDEPEND="!>=kde-base/kdelibs-3.5.4-r2"

emerge output:

[blocks B     ] kde-base/kde-env (is blocking kde-base/kdelibs-3.5.5-r5)

I already unmerged kde-env but there is not better version available, of
course. This is on a stable x86 system, no KDE packages in package.keywords.

kde-env is gone, removed from 3.5.5 release.

I'm still getting only kdelibs-3.5.2-r6. Was this missed, or will it just take
a while for mirrors to update?

Cheers.

Must be a mirror issue?  Stable for me on x86:

c12 somedir # grep KEYWORD /usr/portage/kde-base/kdelibs/*.ebuild
/usr/portage/kde-base/kdelibs/kdelibs-3.5.2-r6.ebuild:KEYWORDS="alpha amd64
hppa ia64 mips ppc ppc64 sparc x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.5-r5.ebuild:KEYWORDS="~alpha amd64
~ppc ~ppc64 ~sparc x86 ~x86-fbsd"

This is weird:

# grep KEYWORDS /usr/portage/kde-base/kdelibs/*.ebuild
/usr/portage/kde-base/kdelibs/kdelibs-3.5.2-r6.ebuild:KEYWORDS="alpha amd64
hppa ia64 mips ppc ppc64 sparc x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.3-r4.ebuild:KEYWORDS="~alpha ~amd64
~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.4-r3.ebuild:KEYWORDS="~alpha ~amd64
~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.4-r4.ebuild:KEYWORDS="~alpha ~amd64
~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.5-r4.ebuild:KEYWORDS="~alpha ~amd64
~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.5-r5.ebuild:KEYWORDS="~alpha amd64
~ppc ~ppc64 ~sparc x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.5.ebuild:KEYWORDS="~alpha ~amd64
~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"

# emerge --search kdelibs
Searching...
[ Results for search key : kdelibs ]
[ Applications found : 1 ]

*  kde-base/kdelibs
      Latest version available: 3.5.2-r6
      Latest version installed: 3.5.2-r6
      Size of files: 15,101 kB
      Homepage:      http://www.kde.org/
      Description:   KDE libraries needed by all kde programs
      License:       GPL-2 LGPL-2

And nothing in package.keywords or package.mask:

# grep kdelibs /etc/portage/*
[nothing]

And my arch is x86. Any ideas?

Thanks :-)

emerge -p kdelibs?

Most likely kde-env is a blocker.  Just un-emerge it before you emerge the new
kdelibs

People in the forums have found

emerge -C kde-env
emerge -1 kde-base/arts
emerge -1 kde-base/kdelibs
emerge -1 kde-base/kdesu
emerge -1 kde-base/kcminit

to do the trick

sparc stable.

Calculating world dependencies... done!
[blocks B     ] >=kde-base/kdelibs-3.5.4-r2 (is blocking kde-base/kde-env-3-r4)


Both kdelibs and kde-env -C'd still getting this - sync'd about 3 minutes ago.

two machines hard down here over this, help?

maybe kde-env is still in your world file?

Any practical reason why hppa@ was not CC'd?

vykk3: you need to emerge sync again. I was getting the same error until today,
it means you caught the tree in the middle of being updated and some old
ebuilds still depend on kde-env. Maybe some of the mirrors are being slow to
catch up - rsync.uk.gentoo.org is ok.

jer: nope, just must have missed it.  Sorry about that.

Created an attachment (id=102046) [edit]
kdepackages 16/11/2006

The last version of the list was missing libkdepim.  I've added that and fixed
the order so that a script can commit each package.

And, ppc should be done now using the last list, please re-add me if I forgot
something.

Thanks!

(In reply to comment #42)
> emerge -p kdelibs?
> 
> Most likely kde-env is a blocker.  Just un-emerge it before you emerge the new
> kdelibs

Tried this, and nope.

Did an emerge --unmerge kde-env. Following the instructions from the forum
(above), still getting:

# emerge -p kdelibs

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild     UD] kde-base/arts-3.5.2-r1 [3.5.5]
[ebuild   R   ] kde-base/kdelibs-3.5.2-r6

Just emerge sync'd to rsync.uk.gentoo.org two minutes ago. All else is as in my
previous post.

In addition...

grep KEYWORDS /usr/portage/kde-base/kdelibs/kdelibs-3.5*
/usr/portage/kde-base/kdelibs/kdelibs-3.5.2-r6.ebuild:KEYWORDS="alpha amd64
hppa ia64 mips ppc ppc64 sparc x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.3-r4.ebuild:KEYWORDS="~alpha ~amd64
~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.4-r3.ebuild:KEYWORDS="~alpha ~amd64
~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.4-r4.ebuild:KEYWORDS="~alpha ~amd64
~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.5-r4.ebuild:KEYWORDS="~alpha ~amd64
~hppa ~ia64 ~mips ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.5-r5.ebuild:KEYWORDS="~alpha amd64
~ppc ~ppc64 sparc x86 ~x86-fbsd"
/usr/portage/kde-base/kdelibs/kdelibs-3.5.5.ebuild:KEYWORDS="~alpha ~amd64
~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"


# emerge -pv =kdelibs-3.5.5-r5

These are the packages that would be merged, in order:

Calculating dependencies
!!! All ebuilds that could satisfy "=kdelibs-3.5.5-r5" have been masked.
!!! One of the following masked packages is required to complete your request:
- kde-base/kdelibs-3.5.5-r5 (masked by: ~x86 keyword)

How is it masked by ~x86 when it's clearly been shown not to? I have no kde-env
or anything else depending specifically on earlier versions.

Cheers.

>How is it masked by ~x86 when it's clearly been shown not to? I have no kde-env
> or anything else depending specifically on earlier versions.

Do you have a portage overlay?  Or do you have some override in /etc/portage ?

(In reply to comment #54)
> >How is it masked by ~x86 when it's clearly been shown not to? I have no kde-env
> > or anything else depending specifically on earlier versions.
> 
> Do you have a portage overlay?  Or do you have some override in /etc/portage ?

d'oh! Yes...

emerge --sync != ( emerge --sync && layman -s ALL )

Thanks!

Kugelfang already took care of this on amd64, no complaints so far, so I'm
removing us from CC.

kde-3.5.5 stable on hppa.

ppc64 stable

Alpha stable.

all arches seem to be stable.  closing.