Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 147189 - openldap unnecessarily depends on berkdb with 'minimal' USE flag
Summary: openldap unnecessarily depends on berkdb with 'minimal' USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High trivial (vote)
Assignee: Gentoo LDAP project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-11 06:39 UTC by Jan Oravec
Modified: 2006-09-30 17:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Oravec 2006-09-11 06:39:20 UTC
Some libraries (like berkdb and gdbm) are used by openldap only at server side. Ebuild does not take it into account and depends on berkdb even when neither 'berkdb' nor 'gdbm' is in USE flags.

I would propose wrapping dependency conditions for berkdb/gdbm inside minimal? () block or splitting the ebuild into -client and -server as these parts are semantically different things (see discussion for bug #143473).
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-09-11 07:24:31 UTC
No plans to split anything here.
Comment 2 Benjamin Smee (strerror) (RETIRED) gentoo-dev 2006-09-18 06:45:44 UTC
Due to not splitting things out this won't change. Won't fix sorry.
Comment 3 Jan Oravec 2006-09-18 07:04:39 UTC
I proposed two possible solutions. While I understand that the second one (package split) may not be what you want, the first one was to actually fix USE flag minimum by wrapping berkdb/gdbm dependency inside !minimal? () block like this:

--- openldap-2.3.24-r1.ebuild   2006-09-18 15:53:55.000000000 +0200
+++ openldap-2.3.24-r1.ebuild   2006-09-18 15:58:59.000000000 +0200
@@ -29,10 +29,12 @@
        perl? ( >=dev-lang/perl-5.6 )
        samba? ( >=dev-libs/openssl-0.9.6 )
        kerberos? ( virtual/krb5 )
-       berkdb? ( ${RDEPEND_BERKDB} )
-       !berkdb? (
-               gdbm? ( >=sys-libs/gdbm-1.8.0 )
-               !gdbm? ( ${RDEPEND_BERKDB} )
+       !minimal? (
+               berkdb? ( ${RDEPEND_BERKDB} )
+               !berkdb? (
+                       gdbm? ( >=sys-libs/gdbm-1.8.0 )
+                       !gdbm? ( ${RDEPEND_BERKDB} )
+               )
        )
        selinux? ( sec-policy/selinux-openldap )"


Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-09-30 17:11:51 UTC
ok, I see what there is to gain here, and I'm implementing it for 2.3.27-r1 ;-).
If we build with USE=minimal, we're bringing a whack of DEPs that we don't actually need.
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-09-30 17:49:31 UTC
fixed in cvs.