Bugzilla Bug 146956

I had to correct a couple of issues in KWlanInfo before the values it displayed
on my system made any sense:

- The iwreq structure (particularly the iwr.data.length field) isn't properly
initialized before invoking the SIOCGIWESSID and SIOCGIWNICKN ioctls to query
the ESSID and Nickname.

- The program assumes the SIOCGIWFREQ ioctl to return the current frequency,
but some drivers return the channel number instead (though this is deprecated).
I have added a trivial workaround for that case. At least the ipw2200 driver
used to behave that way before version 1.1.3, other drivers might still do so.

- The displayed channel number might be wrong due to inaccurate rounding.

I've sent my patch to the original author about half a year ago, but
unfortunately he's to busy to apply it and release a new version. So, I figured
it might still be useful to other Gentoo users.

Created an attachment (id=96478) [edit]
Proposed patch for all three issues

(In reply to comment #0)
> I've sent my patch to the original author about half a year ago, but
> unfortunately he's to busy to apply it and release a new version.

6/8 months ago? Please consider filing a bug upstream (bugs.kde.org) - we are
unlikely to support patches refused by upstream. If upstream cba to accept it,
it reflects pretty poorly on them.

(In reply to comment #2)
> Please consider filing a bug upstream (bugs.kde.org) - we are
> unlikely to support patches refused by upstream.

kwlaninfo is not an official KDE project, is it? I don't think they feel
responsible for it. Upstream, in this case, refers to a single coder who hasn't
shown any activity for almost two years now.
Anyway, since there doesn't seem to be any equivalent tool around (what with
kwirelessmonitor growing more and more unstable and finally being dropped from
portage) I thought my patches might actually be useful to others. They
certainly are to me.

Created an attachment (id=103349) [edit]
New version of the patch.

A recent change in the kernel's wireless layer triggered yet another bug in
kwlanino, now the applet will display an error message due to a failed ioctl()
whenever the mouse hovers above it. New patch attached.

I've just sent an email to upstream to ask about KWlanInfo's status and this 
patch.

Peter (upstream) just informed me that he will be using the patch for version 
0.9.5 which he expects to provide in a few days. He's going to notify me when 
it's out.

This patch was included in version 0.9.5 which I've just committed to CVS.

This patch was included in version 0.9.5 which I've just committed to CVS.