First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 146738
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Diego E. 'Flameeyes' Pettenò <flameeyes@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Ben de Groot <yngwin@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
rubyripper-0.2-r1.ebuild media-sound/rubyripper-0.2 ebuild text/plain Ben de Groot 2006-09-07 11:56 0000 1.23 KB Details
rubyripper-0.2-r2.ebuild media-sound/rubyripper-0.2.ebuild text/plain Ben de Groot 2006-09-10 19:32 0000 1.14 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 146738 depends on: Show dependency tree
Bug 146738 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-09-07 11:54 0000
From http://wiki.hydrogenaudio.org/index.php?title=Rubyripper :
"Rubyripper is a digital audio extraction algorithm that uses cdparanoia or
cdda2wav in a sophisticated way to make sure that a CD rip is done succesfully
and accurately. It is very similiar to and inspired by EAC. Rubyripper is
written in the ruby programming language."

This is an excellent little program that makes exact rips from audio CDs and
optionally encodes them as flac, ogg vorbis and/or mp3. It has both commandline
and gtk2 GUI versions. I think this would be a great addition to Gentoo. Please
review and consider for inclusion.

------- Comment #1 From Ben de Groot 2006-09-07 11:56:35 0000 -------
Created an attachment (id=96308) [edit]
media-sound/rubyripper-0.2 ebuild

This ebuild is what I use, based on kpex-media overlay's 0.1.1 version. Of
course: it works for me.

------- Comment #2 From Diego E. 'Flameeyes' Pettenò 2006-09-09 05:07:28 0000 -------
Ben, the ebuild is mostly good, but if you can fix a couple of things it would
be better:

- the license "as-is" is misplaced, the site states RubyRipper is under GPL2;
- pkg_postinst is indented with 4 spaces, rather than tabs;
- the identical sed calls on two files can become a single sed line; the sed
dependency can be removed, it's not needed for non-system packages;
- the ${S} entries should be quoted as "${S}" for extra safety;
- the mp3 useflag should be encode instead (as that's what lame is used, I
know, it's an unfortunate name for an useflag :( ).

A part this, the ebuild looks fine, and I'd look forward to add it to portage
soon after testing it a bit.

------- Comment #3 From Ben de Groot 2006-09-10 19:32:44 0000 -------
Created an attachment (id=96645) [edit]
media-sound/rubyripper-0.2.ebuild

Improved ebuild.

It doesn't make sense to use the encode useflag for mp3 encoding. As the
transcode ebuild also uses the mp3 useflag for the lame dependancy, I vote for
keeping it simple and straightforward.

------- Comment #4 From Diego E. 'Flameeyes' Pettenò 2006-09-15 07:35:29 0000 -------
I thought a bit about the problem of lame and encode, and you are right. It
does not make sense to use the encode useflag in this sense. I think it's
probably time to get rid of the lame<->encode link.

The ebuild sounds good to enter portage, let me test it a bit more and I'll see
to do that.

------- Comment #5 From Diego E. 'Flameeyes' Pettenò 2006-09-15 12:21:44 0000 -------
There was still the SLOT missing, and I missed it too :)

Anyway, now in portage :) Thanks for submitting the ebuild.

------- Comment #6 From Ben de Groot 2006-09-15 18:28:47 0000 -------
Thanks, Diego, for commiting this to portage!

First Last Prev Next    No search results available      Search page      Enter new bug