Bugzilla Bug 146551

# emerge dev-util/pkgconfig
...
make  check-TESTS
make[2]: Entering directory
`/var/tmp/portage/pkgconfig-0.21/work/pkg-config-0.21/check'
PASS: check-cflags
PASS: check-libs
PASS: check-define-variable
PASS: check-libs-private
../pkg-config --cflags requires-test :
'-I/requires-test/include -I/private-dep/include -I/public-dep/include' !=
'-I/requires-test/include -I/public-dep/include'
FAIL: check-requires-private
PASS: check-includedir
===================
1 of 6 tests failed
===================
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory
`/var/tmp/portage/pkgconfig-0.21/work/pkg-config-0.21/check'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory
`/var/tmp/portage/pkgconfig-0.21/work/pkg-config-0.21/check'
make: *** [check-recursive] Error 1

!!! ERROR: dev-util/pkgconfig-0.21 failed.
Call stack:
  ebuild.sh, line 1543:   Called dyn_test
  ebuild.sh, line 985:   Called src_test
  ebuild.sh, line 615:   Called die

!!! Make check failed. See above for details.
!!! If you need support, post the topmost build error, and the call stack if
relevant.



# emerge --info
Portage 2.1.1_rc1-r4 (default-linux/x86/2006.1/desktop, gcc-4.1.1,
glibc-2.4-r3, 2.6.16-suspend2-r12 i686)
=================================================================
System uname: 2.6.16-suspend2-r12 i686 Intel(R) Pentium(R) M processor 1.70GHz
Gentoo Base System version 1.12.4
Last Sync: Wed, 06 Sep 2006 06:00:09 +0000
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
ccache version 2.4 [enabled]
app-admin/eselect-compiler: [Not Present]
dev-lang/python:     2.4.3-r3
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.4-r2
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.13-r3
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=pentium-m -fomit-frame-pointer -mfpmath=sse"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-rebuild /etc/splash /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=pentium-m -fomit-frame-pointer -mfpmath=sse"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache collision-protect distlocks
metadata-transfer sandbox sfperms strict test"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LANG="ru_RU.UTF-8"
LINGUAS="ru uk"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_EXTRA_OPTS="--exclude-from=/etc/portage/rsync_excludes"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X a52 aac acpi alsa amr apache2 asf avi berkdb bitmap-fonts bzip2
cairo cdr chardet chroot cli crypt dbus dlloader dri dvd dvdr elibc_glibc
emboss encode fam fat ffmpeg firefox flac fluidsynth freetype gd gdbm gif glitz
glut gnome gpm gstreamer gtk gtk2 hal iconv input_devices_keyboard
input_devices_mouse input_devices_synaptics irda isdnlog ithreads jpeg
kernel_linux libg++ linguas_ru linguas_uk logrotate mikmod mmap mmx mozdevelop
mozilla moznocompose moznoirc mp3 ncurses nls nptl nptlonly ogg opengl pam
pam_chroot pcre pdflib perl pic png pnp ppds pppd pthreads readline reflection
reiser4 reiserfs samba sdl seamonkey session slang spl sse sse2 ssl svg symlink
syslog tcpd threads timidity truetype truetype-fonts type1-fonts udev unicode
usb userland_GNU userlocales utf8 video_cards_ati video_cards_fglrx
video_cards_nv video_cards_nvidia video_cards_radeon video_cards_vesa
video_cards_vga vim-with-x vlm vorbis win32codecs wma wxwindows x264 xinerama
xml xml2 xmms xorg xv xvid zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS

Same failure on sparc and on amd64.

(Forgot to actually push 'Add Archs')

Looks to be an issue with upstream - ./configure && make && make check outside
of portage fails with the same error.

Same failure on amd64 for dev-util/pkgconfig-0.21-r1

Same problem on ppc w/ -r1.

*** Bug 156869 has been marked as a duplicate of this bug. ***

http://lists.freedesktop.org/archives/pkg-config/2006-November/000162.html

Is the fix in the message correct? At least it worksforme, but I do not know if
it breaks the pupose of the checks.

The patch in the message has a total of three fixes, but the changes that makes
this test works for me is the following:

@@ -11,17 +15,21 @@

 # expect cflags from requires-test and public-dep
 ARGS="--cflags requires-test"
-RESULT="-I/requires-test/include -I/public-dep/include"
+RESULT="-I/requires-test/include -I/private-dep/include -I/public-dep/include"
 run_test

 # still expect those cflags for static linking case
 ARGS="--static --cflags requires-test"
-RESULT="-I/requires-test/include -I/public-dep/include"
+RESULT="-I/requires-test/include -I/private-dep/include -I/public-dep/include"
 run_test

No, I think that's wrong.  I think the test is expecting the correct output,
and pkg-config is broken to fail the test.  Changing the expected results is
wrong; those deps are marked private, and shouldn't show up.  I'll try and look
into this to see why it's broken, but this particular breakage just results in
pulling in extra headers, so it shouldn't cause failures in general.

Okay, it turns out you were right.  Behavior for CFLAGS changed in 0.21, so the
changes to the tests are appropriate.  I've fixed this, but without bumping
(since it only affects the tests).