Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 145941 - portage_overlay leaves behind overlay directory in squashfs and PORTDIR_OVERLAY in make.conf
Summary: portage_overlay leaves behind overlay directory in squashfs and PORTDIR_OVERL...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: Catalyst (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Catalyst Developers
URL:
Whiteboard:
Keywords: InVCS
: 147430 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-09-01 20:40 UTC by Andrew Gaffney (RETIRED)
Modified: 2007-02-06 22:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gaffney (RETIRED) gentoo-dev 2006-09-01 20:40:10 UTC
I just booted up the x86 2006.1 LiveCD, and I've got the overlay for the updated gentoo-sources in /root. On my local system, the overlay path was /root/catalyst/overlays/portage. This is the exact path (contents included) on the LiveCD. The PORTDIR_OVERLAY line is also in the LiveCD's /etc/make.conf.
Comment 1 Andrew Gaffney (RETIRED) gentoo-dev 2006-09-01 20:48:09 UTC
In modules/generic_stage_target.py, it looks like the portage_overlay directory is copied over with full path into the chroot. PORTDIR_OVERLAY is also added directly to make.conf. At no point in this file is the PORTDIR_OVERLAY line removed from make.conf or the copied overlay removed from the chroot.

I recommend setting PORTDIR_OVERLAY in the env instead of in make.conf. Also, use a known temp dir for the overlay, so you can just remove the whole dir tree when done without fear of killing something important. rsync the overlay to /tmp/portage_overlay or some other known directory. Even if it's left around, it won't be so obvious.
Comment 2 Chris Gianelloni (RETIRED) gentoo-dev 2006-09-03 13:38:54 UTC
Actually, I'm trying to move away from doing things in the environment only.  Instead, we'll likely be copying the "hosts" idea and making a backup of make.conf, then making changes to make.conf, then restoring the backup when we're done.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-09-13 03:56:40 UTC
*** Bug 147430 has been marked as a duplicate of this bug. ***
Comment 4 Chris Gianelloni (RETIRED) gentoo-dev 2006-11-22 08:43:28 UTC
OK.  I lied.  The "best" solution that I can come up with here is to create a new function to remove the overlay from make.conf and the directory.  I still like the idea of putting it into a known location, though.
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2007-01-09 14:53:07 UTC
This should be fixed in subversion now...
Comment 6 Chris Gianelloni (RETIRED) gentoo-dev 2007-02-06 22:53:50 UTC
Fixed in 2.0.2