Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!
Not eligible to see or edit group visibility for this bug.
View Bug Activity | Format For Printing | XML | Clone This Bug
new ebuild for a, maybe, krdc replacement.
Created an attachment (id=95542) [edit] krd-1.1.ebuild krd-1.1.ebuild
Created an attachment (id=95983) [edit] krd-1.1.ebuild updated mirror-path
Created an attachment (id=97577) [edit] krd-1.3.ebuild version update
version update
Because the fact that it's using the KDE eclass, you don't need to specify src_compile(). It's inherited. Anyways, simply removing src_compile and bumping to krd-1.4.ebuild works fine. Also, net-misc/rdesktop should be added for rdesktop support. And so should net-misc/tightvnc for vnc support.
Created an attachment (id=113297) [edit] krd-1.4.ebuild Version bump and ebuild - fixes, please check.
Looks good, but since you did it with USE flags, do a pkg_setup() with an if conditional to check if rdesktop or vnc is set. If neither are, die with ewarn or eerror. Since otherwise it has no functionality.
Created an attachment (id=114596) [edit] krd-1.4.ebuild Thanks for advice. Please check again.
Almost there. Switch ~amd64 with ~x86 (order). And change pkg_setup() { if ! use rdesktop && ! use vnc ; then eerror eerror "${PN} requires rdesktop or vnc USE - flag to work." die "${PN} requires rdesktop or vnc USE - flag to work." fi } to pkg_setup() { if ! use rdesktop && ! use vnc ; then echo eerror "${PN} has no use without rdesktop or vnc support." eerror "To have rdesktop or vnc support, please emerge with" eerror "USE=\"rdesktop\", USE="\vnc\" or USE=\"rdesktop vnc\" die "${PN} requires rdesktop or vnc USE flag(s)" fi } Just makes the error make a bit more sense, and well, you should always demonstrate the USE examples.
Was also just noticing, what's the reason for inheriting eutils? It's not used in the ebuild from what I saw.
Created an attachment (id=114624) [edit] krd-1.4.ebuild Thanks for advice. So this one may be the final one.
Looks good to me. Good job.
Created an attachment (id=122433) [edit] krd-1.5.ebuild version bump
Ebuild is now in the gentoo-sunrise overlay, available here: http://gentoo-sunrise.org/svn/sunrise/kde-misc/krd
(In reply to comment #14) > Ebuild is now in the ... tree. Bumped to 1.6. Thanks to all who worked on this!