Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 143509 - ati-drivers: use more of linux-mod (patch)
Summary: ati-drivers: use more of linux-mod (patch)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Luca Barbato
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-10 16:14 UTC by Stefan Schweizer (RETIRED)
Modified: 2006-12-04 12:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ati-drivers-linux-mod.diff (ati-drivers-linux-mod.diff,3.19 KB, patch)
2006-08-10 16:14 UTC, Stefan Schweizer (RETIRED)
Details | Diff
ati-drivers-linux-mod.diff (ati-drivers-linux-mod.diff,3.49 KB, patch)
2006-08-11 18:14 UTC, Stefan Schweizer (RETIRED)
Details | Diff
this is patch for 2.6.19 compatibility (ati-drivers-8.31.5-linux-2.6.19.patch,3.08 KB, text/plain)
2006-12-01 19:32 UTC, Jory A. Pratt
Details
patch for linux-mod (ati-drivers.diff,3.85 KB, text/plain)
2006-12-01 19:33 UTC, Jory A. Pratt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schweizer (RETIRED) gentoo-dev 2006-08-10 16:14:03 UTC
use more of linux-mod.eclass and thus make the ebuild better and cleaner:

 ati-drivers-8.27.10-r1.ebuild |   63 ++++++++++--------------------------------
 1 file changed, 16 insertions(+), 47 deletions(-)


Please verify if it is working ok and commi it or llo me to do so.
Comment 1 Stefan Schweizer (RETIRED) gentoo-dev 2006-08-10 16:14:29 UTC
Created attachment 93951 [details, diff]
ati-drivers-linux-mod.diff
Comment 2 Luca Barbato gentoo-dev 2006-08-11 06:12:43 UTC
please make CHECK_CONFIG cope with the module case before.

please add "+" check if builtin and "." check if module or something similar.

beside that the rest looks quite nice =)
Comment 3 Stefan Schweizer (RETIRED) gentoo-dev 2006-08-11 18:14:50 UTC
Created attachment 94021 [details, diff]
ati-drivers-linux-mod.diff

changes:
- use $S
- check for DRM correctly (builtin only)

Status: needs proper compile-time-testing
Comment 4 Luca Barbato gentoo-dev 2006-08-11 19:05:24 UTC
>>> Install ati-drivers-8.27.10-r1 into /var/tmp/portage/ati-drivers-8.27.10-r1/image/ category x11-drivers
 * Installing fglrx module
install: cannot stat `fglrx.ko': No such file or directory

Looks like it isn't working as supposed...
Comment 5 Jory A. Pratt 2006-11-17 18:26:27 UTC
-	cd ${WORKDIR}/common/lib/modules/fglrx/build_mod

this can not be deleted as you must specify were the file to install is. After that changes are sane :)
Comment 6 Jory A. Pratt 2006-12-01 19:32:54 UTC
Created attachment 103170 [details]
this is patch for 2.6.19 compatibility 

Patch created by myself.
Comment 7 Jory A. Pratt 2006-12-01 19:33:57 UTC
Created attachment 103171 [details]
patch for linux-mod

Here is the linux-mod patch. Thanks to dsd_ for helping to get it all straightened out. This is against the beta release but should be easy enough to apply to 8.30.3-r1 as well.
Comment 8 Pandor 2006-12-03 01:42:42 UTC
(In reply to comment #6)
> Created an attachment (id=103170) [edit]
> this is patch for 2.6.19 compatibility 
> 
> Patch created by myself.
> 

Wouldn't it be more sane to check kernel version and apply accordingly?
 
 +#if (LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,18))
 +#include <linux/config.h>
 +#endif

maybe?
Comment 9 Stefan Schweizer (RETIRED) gentoo-dev 2006-12-03 06:11:48 UTC
thanks anarchy! Your patches work for me. lu, can you please apply them?
Comment 10 Luca Barbato gentoo-dev 2006-12-04 12:55:08 UTC
Applied, thanks everybody =)