First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 142203
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: media-video herd <media-video@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Jakub Moc (RETIRED) <jakub@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
ogmrip-0.9.0-r1.ebuild.diff ogmrip-0.9.0-r2.ebuild.diff patch Jakub Moc (RETIRED) 2006-07-30 11:24 0000 1.97 KB Details | Diff
ogmrip-0.9.0-r1.ebuild.patch An updated version of the patch patch Olivier Rolland 2006-08-17 13:37 0000 1.36 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 142203 depends on: Show dependency tree
Bug 142203 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-07-30 11:09 0000
<snip>
pkg_setup() {
        if ! which mencoder > /dev/null 2>&1; then
                eerror "Unable to find mencoder in the PATH. You need mencoder
to use OGMRip."
                eerror "Please, add encode to your USE flags and emerge mplayer
again."
                die "Unable to find mencoder in the PATH. You need mencoder to
use OGMRip."
        fi
        if ! mencoder -ovc help 2> /dev/null | grep -q "^ *xvid *- .*$"; then
                echo
                eerror "Mplayer is not build with XviD support. OGMRip requires
XviD support in mplayer."
                eerror "Please, add xvid to your USE flags and emerge mplayer
again."
                die "Mplayer is not build with XviD support. OGMRip requires
XviD support in mplayer."
        fi
}
</snip>

Err...

1/ mplayer is in RDEPEND, why would one miss mencoder? What are you after here?
2/ Use built_with_use check from eutils eclass, perhaps?

------- Comment #1 From Jakub Moc (RETIRED) 2006-07-30 11:24:19 0000 -------
Created an attachment (id=93074) [edit]
ogmrip-0.9.0-r2.ebuild.diff

- fix pkg_setup()
- add quoting
- do not dodoc COPYING INSTALL

------- Comment #2 From Olivier Rolland 2006-08-17 13:37:37 0000 -------
Created an attachment (id=94473) [edit]
An updated version of the patch

------- Comment #3 From Matthias Schwarzott 2006-08-30 09:21:00 0000 -------
Added this to ogmrip-0.9.0-r1.ebuild.

First Last Prev Next    No search results available      Search page      Enter new bug