Bug 142203 – media-video/ogmrip spooky pkg_setup()

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jakub Moc (RETIRED) 2006-07-30 11:09:32 UTC]

<snip>
pkg_setup() {
        if ! which mencoder > /dev/null 2>&1; then
                eerror "Unable to find mencoder in the PATH. You need mencoder to use OGMRip."
                eerror "Please, add encode to your USE flags and emerge mplayer again."
                die "Unable to find mencoder in the PATH. You need mencoder to use OGMRip."
        fi
        if ! mencoder -ovc help 2> /dev/null | grep -q "^ *xvid *- .*$"; then
                echo
                eerror "Mplayer is not build with XviD support. OGMRip requires XviD support in mplayer."
                eerror "Please, add xvid to your USE flags and emerge mplayer again."
                die "Mplayer is not build with XviD support. OGMRip requires XviD support in mplayer."
        fi
}
</snip>

Err...

1/ mplayer is in RDEPEND, why would one miss mencoder? What are you after here?
2/ Use built_with_use check from eutils eclass, perhaps?

[Comment 1 Jakub Moc (RETIRED) 2006-07-30 11:24:19 UTC]

Created attachment 93074 [details, diff]
ogmrip-0.9.0-r2.ebuild.diff

- fix pkg_setup()
- add quoting
- do not dodoc COPYING INSTALL

[Comment 2 Olivier Rolland 2006-08-17 13:37:37 UTC]

Created attachment 94473 [details, diff]
An updated version of the patch

[Comment 3 Matthias Schwarzott 2006-08-30 09:21:00 UTC]

Added this to ogmrip-0.9.0-r1.ebuild.