Bugzilla Bug 142155

Version 0.6.0 Beta 2 was recently released so I took the liberty of making an
updated ebuild from the current one in portage (0.5.0). Will someone put
0.6.0beta2 in the main tree?

Created an attachment (id=93047) [edit]
Basket 0.6.0 beta2 ebuild

Please attach a diff against latest version and reopen.

Created an attachment (id=93064) [edit]
Basket 0.6.0 beta2 diff

I hope that's how you are supposed to do a diff, first time I've done it :).
Also I'm not sure if there is a better way to do it then using the mv command.

Added 0.5.0 -> 0.6.0 beta2 diff

The ebuild you have attached is not an improvement to the one in portage at
all. To make an ebuild for the 0.6_beta2 it is enough to copy the old ebuild to
your overlay in /usr/local/portage and name it to basket-0.6_beta2.

In your ebuild the download URI is hardcoded and thats BAD (TM).I am not sure
how one can fix this cause upstream didn't follow the naming conventions though
. 

The "arts" IUSE is managed by the kde eclass as far as I know and must not be
used directly in the ebuild.

Furthermore you dropped 3 patches from the original ebuild - did you test if
they are realy not needed anymore (e.g. do you have GCC 4.1)?

Last but not least your cd and mv actions are not needed at all - one should
avoid such actions and keep things simple ...

If you want to improve in writing ebuilds checkout the docs at
http://devmanual.gentoo.org  

> The ebuild you have attached is not an improvement to the one in portage at
> all. To make an ebuild for the 0.6_beta2 it is enough to copy the old ebuild to
> your overlay in /usr/local/portage and name it to basket-0.6_beta2.

Copying the ebuild and renaming it did not work so I changed it till it did, I
realize the changes might not be up to the expected quality of service of
actual developers but I figured by some off chance maybe this could help
someone.

> In your ebuild the download URI is hardcoded and thats BAD (TM).I am not sure
> how one can fix this cause upstream didn't follow the naming conventions though

Using the 0.5.0 URI did not work because the file was labeled 0.6.0Beta2
instead of 0.6.0_beta2 so I hard coded it not knowing what else I could do.

> The "arts" IUSE is managed by the kde eclass as far as I know and must not be
> used directly in the ebuild.

I honestly can't say why I put that in there, whether it was because the
package listed it when I used the configure --help flag or because of some
other reason, I forgot....

> Furthermore you dropped 3 patches from the original ebuild - did you test if
> they are realy not needed anymore (e.g. do you have GCC 4.1)?

I only see 2 patches though and not 3.... I have GCC 4.1 and the ebuild
wouldn't accept the patch for AMD64 and after taking it out it compiled
perfectly on AMD64 for me. As for the noarts patch it would not work with the
new basket either. (did I have to change something to make them work or are
they already applied in the upstream?)

> Last but not least your cd and mv actions are not needed at all - one should
> avoid such actions and keep things simple ...
> 
> If you want to improve in writing ebuilds checkout the docs at
> http://devmanual.gentoo.org  

I know but that was the only way it would work. As you can tell I just wanted
things to work until an official package was released. When changing an ebuild
it becomes hard to know what fixed the problem and what the official way of
doing it is. As it is now it consists of a hack upon a hack which requires
another hack to get those to work and then the ebuild will install, I am sure
there are better ways to do it. I will try to sit down and read the whole
manual so I can make better ebuilds.

Created an attachment (id=93931) [edit]
Diff between basket-0.5.0.ebuild and basket-0.6.0_beta2.ebuild

Created my own ebuild based on portages and the one that was here.
Diff attached.

Both patches have been pushed upstream (have GCC 4.1 and built / checked source
about -arts), so removed the entire src_unpack() section. Using versionator and
some bash replacing to convert the version string / working folder.

(From update of attachment 93931 [edit])
text/plain please :)

Bumped in portage.