Bugzilla Bug 141177

Pasted from
https://savannah.nongnu.org/bugs/index.php?func=detailitem&item_id=15349
------------------------------
I've noticed that when my dialup connection dies and reconnects that mldonkey
is slow to start downloading and uploading normally. I figure this is because
there are a lot of stale connections that haven't timed-out. When I used the
command close_all_sockets mlnet started uploading again and began finding
sources normally again. Maybe it would be beneficial to 'close_all_sockets' or
something similar (so the GUI doesn't get disconnected needlessly...). However
it probably wouldn't know to close the sockets until one of the connections to
a server timed out or something (and when you connect to a new server and
obtain a different IP from the last one).
------------------------------

Sending SIGHUP via ip-up script to MLDonkey core closes all connections after
reconnect. Implementing the idea of the OP does not solve the problem because
MLDonkey still must wait for some timeouts of connections.

(In reply to comment #0)

> Maybe it would be beneficial to 'close_all_sockets' or
> something similar (so the GUI doesn't get disconnected needlessly...)

To avoid disconnecting GUIs try this patch which updates SIGHUP behaviour
https://savannah.nongnu.org/patch/?func=detailitem&item_id=5275

The aforementioned patch is in MLDonkey since 2.8.0.

I think this bug can be closed as soon as 2.8.2 is stable.

The patch to fix comment 1 is in CVS, correct.

But the SIGHUP command is not part of MLDonkey scripts yet,
this is a useful extension which should be added to the
Gentoo package.

Created an attachment (id=106740) [edit]
mldonkey.initd

Created an attachment (id=106742) [edit]
mldonkey.confd

Please find attached an updated init script for MLDonkey.  It now features a
"reload" function which sends SIGHUP to the running MLDonkey.  Also introduces
is a USE_LOGGER variable, which should be set to true in mldonkey.confd, if the
option log_to_syslog is enabled in MLDonkey.  In this case, the script will
also specify that it uses the system logger.

I also tried to clean the script up a bit.

Created an attachment (id=106743) [edit]
mldonkey.initd

BTW spiralvoice, what is the official MLDonkey homepage?  All MLDonkey ebuild
currently specify www.nongnu.org/mldonkey...

(In reply to comment #6)
> BTW spiralvoice, what is the official MLDonkey homepage?  All MLDonkey ebuild
> currently specify www.nongnu.org/mldonkey...

This page forwards to http://mldonkey.sourceforge.net
This is the new, official homepage of the project.

MLDonkey project is now split on two platforms:
- Sourceforge for forum, wiki, file release <- user-oriented
- Savannah for CVS, patch/task/bug trackers <- dev-oriented

OK, I have opened bug 161875 about it.

It fails when I run the following:
./mldonkey slow
 * Reducing bandwidth to 6k/2k ...                                        [ !!
]

./mldonkey fast
 * Increasing bandwidth to 100k/11k ...                                   [ !!
]

Thanks

(In reply to comment #9)
> It fails when I run the following:
> ./mldonkey slow
>  * Reducing bandwidth to 6k/2k ...                                        [ !!
> ]
> 
> ./mldonkey fast
>  * Increasing bandwidth to 100k/11k ...                                   [ !!
> ]

Strange, this works here.  Do you have added you password and username to
/etc/conf.d/mldonkey?  Does ist fail immediatly or does it take approximately
10 seconds?

(In reply to comment #9)
> It fails when I run the following:
> ./mldonkey slow
>  * Reducing bandwidth to 6k/2k ...                                        [ !!
> ]
> 
> ./mldonkey fast
>  * Increasing bandwidth to 100k/11k ...                                   [ !!
> ]

I forgot to mention that the new init script does only work with
>=mldonkey-2.8.0 because it is based on ${FILESDIR}/mldonkey.initd-2.8.  Could
it be the case that you use an older version?  There was a slight modification
in telnet syntax that forced this change.

(In reply to comment #10)
> (In reply to comment #9)
> > It fails when I run the following:
> > ./mldonkey slow
> >  * Reducing bandwidth to 6k/2k ...                                        [ !!
> > ]
> > 
> > ./mldonkey fast
> >  * Increasing bandwidth to 100k/11k ...                                   [ !!
> > ]
> 
> Strange, this works here.  Do you have added you password and username to
> /etc/conf.d/mldonkey?  Does ist fail immediatly or does it take approximately
> 10 seconds?
> 

immediatly. I attach my init.d file

Created an attachment (id=106985) [edit]
bad mldonkey.initd file

(In reply to comment #13)
> Created an attachment (id=106985) [edit]
> bad mldonkey.initd file

Sorry, this seems to be a misunderstanding.  The file you attached seems to be
exactly the same file as attachment 106743 [edit].

I can think of two reasons why the my new init script fails with "slow" and
"fast" on your system:

1. You use <mldonkey-2.8.
2. You did not configure your password in the script's configuration file
/etc/conf.d/mldonkey (not the *conf.d*, not init.d).

Could you please check if at least one of the above points is true for you?

(In reply to comment #14)
> 1. You use <mldonkey-2.8.

OK, this point is invalid.  Only the "info" function in the new init script
does not work with older versions of MLDonkey, "fast" and "slow" should work
fine with all versions.

(In reply to comment #14)
> (In reply to comment #13)
> > Created an attachment (id=106985) [edit]
> > bad mldonkey.initd file
> 
> Sorry, this seems to be a misunderstanding.  The file you attached seems to be
> exactly the same file as attachment 106743 [edit] [edit].
> 
> I can think of two reasons why the my new init script fails with "slow" and
> "fast" on your system:
> 
> 1. You use <mldonkey-2.8.
> 2. You did not configure your password in the script's configuration file
> /etc/conf.d/mldonkey (not the *conf.d*, not init.d).
> 
> Could you please check if at least one of the above points is true for you?
> 

Sorry, I am spanish and I didn't understand it well.

1. I use mldonkey 2.8.2-r1
2. Yes, I have added a user and a password in the last two lines that I have
uncommented :-/

Thanks

But the problem persists. I attach my mldonkey conf.d file with a test user and
password.

Created an attachment (id=107051) [edit]
bad mldonkey conf.d file

(In reply to comment #18)
> Created an attachment (id=107051) [edit]
> bad mldonkey conf.d file
> 

Works for me...

Your script is fine, I had bad configured my mldonkey.

Thanks a lot :-)

(From update of attachment 106985 [edit])
FIXED

(From update of attachment 107051 [edit])
Fixed

Spiralvoice, maybe you can help me.  What's the best way to start MLDonkey as a
daemon?  The current script does it the following way:

        env MLDONKEY_DIR=${MLDONKEY_DIR} start-stop-daemon --quiet --start \
                -c ${USER} -N ${NICE} -x ${MLDONKEY_BINARY} &>${LOG} &

So it just starts MLDonkey in the background and redirects its output to a
logfile.  I don't like this approach because this file is kept open as long as
MLDonkey is running.  Is there a cleaner way to do it?  I thought of using the
"-daemon" option, but apparently it does not exist anymore:

$ mlnet --help
[...]
-daemon  : this argument was removed, core will exit
[...]

Regards
Christian

(In reply to comment #23)
> What's the best way to start MLDonkey as a daemon?

http://savannah.nongnu.org/task/?4241#comment22

mlnet > /dev/null 2>&1 &

is the way to go, the old --daemon parameter was buggy.
Everything about it can be found using the link above.

(In reply to comment #23)
> Spiralvoice, maybe you can help me.  What's the best way to start MLDonkey as a
> daemon?  The current script does it the following way:
> 
>         env MLDONKEY_DIR=${MLDONKEY_DIR} start-stop-daemon --quiet --start \
>                 -c ${USER} -N ${NICE} -x ${MLDONKEY_BINARY} &>${LOG} &
> 
> So it just starts MLDonkey in the background and redirects its output to a
> logfile.  I don't like this approach because this file is kept open as long as
> MLDonkey is running.  Is there a cleaner way to do it?  I thought of using the
> "-daemon" option, but apparently it does not exist anymore:
> 
> $ mlnet --help
> [...]
> -daemon  : this argument was removed, core will exit
> [...]
> 
> Regards
> Christian
> 

Any update on this? I'm going to put the init script asap...

(In reply to comment #25)
> Any update on this? I'm going to put the init script asap...

Basically the current init script starts MLDonkey as spiralvoice suggested.  We
just do not categorically redirect MLDonkey's output to /dev/null, but to a
user configured file ${LOG} which defaults to /var/log/mldonkey.log.

So I think the script can be committed as-is.

Added into 2.8.2-r1. However i edited the net.lo thing. I'm working with the
baselayout maintainer to fix this in a clean way.