Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 140697 - don't use prepallman (it's invoked automatically).
Summary: don't use prepallman (it's invoked automatically).
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Tavis Ormandy (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-16 13:41 UTC by Brian Harring (RETIRED)
Modified: 2007-12-23 06:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Harring (RETIRED) gentoo-dev 2006-07-16 13:41:55 UTC
pretty simple.  prepall calls prepallman on it's own.  calling it yourself just means you like running it twice for... ya know. um.  just to be safe? ;)

Punt the usage please.
Comment 1 Brian Harring (RETIRED) gentoo-dev 2006-07-16 13:57:28 UTC
just pasting the list (small enough).

maintainer-wanted: you're cc'd for cfal (no owner/herd)

/usr/portage/eclass/ruby.eclass:	prepallman
/usr/portage/sys-cluster/pvm/pvm-3.4.4-r3.ebuild:	prepallman
/usr/portage/sys-cluster/pvm/pvm-3.4.5-r1.ebuild:	prepallman
/usr/portage/sys-cluster/pvm/pvm-3.4.5-r2.ebuild:	prepallman
/usr/portage/sys-cluster/pvm/pvm-3.4.4-r1.ebuild:	prepallman
/usr/portage/sys-cluster/pvm/pvm-3.4.5.ebuild:	prepallman
/usr/portage/sys-cluster/pvm/pvm-3.4.4-r2.ebuild:	prepallman
/usr/portage/sys-cluster/mpich/mpich-1.2.6-r4.ebuild:	prepallman
/usr/portage/sys-cluster/mpich/mpich-1.2.5.2.ebuild:	prepallman
/usr/portage/sys-cluster/mpich/mpich-1.2.7_p1.ebuild:	prepallman
/usr/portage/sys-cluster/mpich/mpich-1.2.6-r3.ebuild:	prepallman
/usr/portage/app-admin/skey/skey-1.1.5-r5.ebuild:	prepallman
/usr/portage/app-admin/skey/skey-1.1.5-r3.ebuild:	prepallman
/usr/portage/app-admin/skey/skey-1.1.5-r4.ebuild:	prepallman
/usr/portage/app-admin/syslog-ng/syslog-ng-1.6.9.ebuild:	prepallman
/usr/portage/app-admin/syslog-ng/syslog-ng-1.6.11.ebuild:	prepallman
/usr/portage/app-admin/sdsc-syslog/sdsc-syslog-1.0.2.ebuild:	prepallman
/usr/portage/app-text/rhyme/rhyme-0.9.ebuild:	prepallman
/usr/portage/x11-plugins/wmrecord/wmrecord-1.0.5.3-r1.ebuild:	prepallman
/usr/portage/x11-plugins/wmblob/wmblob-1.0.1.ebuild:	prepallman
/usr/portage/x11-plugins/wmsystray/wmsystray-0.1.1.ebuild:	prepallman
/usr/portage/media-sound/sox/sox-12.17.7-r2.ebuild:	prepallman
/usr/portage/media-sound/sox/sox-12.17.9.ebuild:	prepallman
/usr/portage/media-sound/sox/sox-12.17.7-r1.ebuild:	prepallman
/usr/portage/media-sound/sox/sox-12.17.6.ebuild:	prepallman
/usr/portage/media-sound/sox/sox-12.17.5-r1.ebuild:	prepallman
/usr/portage/media-sound/sox/sox-12.17.6-r1.ebuild:	prepallman
/usr/portage/app-misc/tdl/tdl-1.5.2.ebuild:	prepallman
/usr/portage/app-misc/tdl/tdl-1.4.1.ebuild:	prepallman
/usr/portage/media-gfx/radiance/radiance-3.5.ebuild:	prepallman
/usr/portage/x11-wm/fvwm/fvwm-2.5.14-r1.ebuild:	prepallman
/usr/portage/x11-wm/fvwm/fvwm-2.5.16.ebuild:	prepallman
/usr/portage/x11-wm/fvwm/fvwm-2.5.12.ebuild:	prepallman
/usr/portage/x11-wm/fvwm/fvwm-2.5.13-r1.ebuild:	prepallman
/usr/portage/sys-apps/findutils/findutils-4.2.25.ebuild:	prepallman
/usr/portage/sys-apps/findutils/findutils-4.1.20-r2.ebuild:	prepallman
/usr/portage/sys-apps/findutils/findutils-4.1.20-r1.ebuild:	prepallman
/usr/portage/sys-apps/findutils/findutils-4.2.24.ebuild:	prepallman
/usr/portage/sys-apps/findutils/findutils-4.2.27.ebuild:	prepallman
/usr/portage/sys-apps/findutils/findutils-4.3.0.ebuild:	prepallman
/usr/portage/dev-lang/cxx/cxx-6.5.9.31-r1.ebuild:	prepallman
/usr/portage/dev-lang/cxx/cxx-6.5.9.31.ebuild:	prepallman
/usr/portage/dev-lang/cfal/cfal-1.2.0.4.ebuild:	prepallman
/usr/portage/net-misc/putty/putty-0.58.ebuild:	prepallman
/usr/portage/net-misc/putty/putty-0.57.ebuild:	prepallman
Comment 2 Brian Harring (RETIRED) gentoo-dev 2006-07-16 13:58:10 UTC
and... should anyone wonder, portage-2.0.50-r11 called prepallman automatically also, so it's been this way for a while (meaning no reason to keep it around now).
Comment 3 Michael Imhof (RETIRED) gentoo-dev 2006-07-16 14:33:56 UTC
All ebuilds in sys-cluster are fixed in cvs.
Comment 4 Krzysztof Pawlik (RETIRED) gentoo-dev 2006-07-16 14:50:41 UTC
All x11-plugins ebuilds done.
Comment 5 SpanKY gentoo-dev 2006-07-16 14:52:34 UTC
then there's no reason to export prepallman to the ebuild in the first place ...

fixed:
skey
findutils
Comment 6 Brian Harring (RETIRED) gentoo-dev 2006-07-16 14:57:21 UTC
(In reply to comment #5)
> then there's no reason to export prepallman to the ebuild in the first place
> ...
> 
> fixed:
> skey
> findutils

It's not exported.

It's a helper script- same as emerge, just cause it's there doesn't mean usage of directly by an ebuild is valid (excuses aside).
Comment 7 Daniel Black (RETIRED) gentoo-dev 2006-07-16 15:10:26 UTC
sdcc-syslog fixed. Thanks Brian.
Comment 8 SpanKY gentoo-dev 2006-07-16 17:29:14 UTC
exported -> it's in $PATH for ebuilds to utilize

move the script to a private path so that ebuilds cant utilize it directly, then there is no problem
Comment 9 Brian Harring (RETIRED) gentoo-dev 2006-07-16 17:45:08 UTC
and emerge?
ebuild?
repoman?
dispatch-conf?
etc-update?
via that logic, should stick a wrapper in place of rm because we don't want people using rm -rf / ;)

Yes, reaching, and no, can't punt it.  There is, and always shall be, implementation details that if an ebuild knows about, it can access- that doesn't make it proper however.  Ebuilds can change the exported SLOT in src_install, and have it take hold- again, just because it's possible, doesn't excuse usage of it.

Presumably, there was a historical reason for ebuilds to use it.  That said, there hasn't been any reason since at least 2.0.50-r11 to call it- either way, the call is a dupe, and isn't needed.  Want it punted from the path, talk to portage devs... I'd expect they'll ignore the request (it's pointless).
Comment 10 SpanKY gentoo-dev 2006-07-16 17:51:24 UTC
what exactly is your point ?  i'm proposing moving things out of an ebuild's PATH into a private path for everyone else to utilize ... so people cant call things like 'prepallman' or 'prepall' since there is no reason for an ebuild to call it

i dont care about the historical reasons, i'm looking forward ... and as you noted, there is no reason anymore for ebuilds to call these scripts
Comment 11 Daniel Black (RETIRED) gentoo-dev 2006-11-12 12:51:33 UTC
# qgrep -H prepallman
app-text/rhyme/rhyme-0.9.ebuild:        prepallman
dev-lang/cfal/cfal-1.2.0.4.ebuild:      prepallman
dev-lang/cxx/cxx-6.5.9.31-r1.ebuild:    prepallman
dev-lang/cxx/cxx-6.5.9.31.ebuild:       prepallman
media-gfx/radiance/radiance-3.5.ebuild:         prepallman
media-sound/sox/sox-12.17.9.ebuild:     prepallman
media-sound/sox/sox-12.18.2.ebuild:     prepallman
net-misc/putty/putty-0.57.ebuild:       prepallman
net-misc/putty/putty-0.58.ebuild:       prepallman
x11-wm/fvwm/fvwm-2.5.16.ebuild:         prepallman
x11-wm/fvwm/fvwm-2.5.18.ebuild:         prepallman
Comment 12 Charlie Shepherd (RETIRED) gentoo-dev 2006-11-22 22:34:45 UTC
cfal done. Taviso, looks like you commited it, would you mind adding yourself to metadata.xml (which currently doesn't exist), or adding maintainer-needed to metadata.xml to make it more explicit who is maintaining it.

sound -> sox is yours
graphics -> radiance is yours
desktop-wm -> fvwm is yours
Comment 13 Charlie Shepherd (RETIRED) gentoo-dev 2006-11-22 22:38:52 UTC
(In reply to comment #12)
> metadata.xml (which currently doesn't exist)

Meh, looks like beandog's already assigned it to maintainer-needed. Please add yourself if you want it.

Comment 14 David Shakaryan (RETIRED) gentoo-dev 2006-11-27 23:24:05 UTC
(In reply to comment #12)
> desktop-wm -> fvwm is yours

Done. :)
Comment 15 Nguyen Thai Ngoc Duy (RETIRED) gentoo-dev 2006-12-04 00:39:33 UTC
ruby.eclass overrides prepall so it should call prepallman, isn't it?
Comment 16 Samuli Suominen (RETIRED) gentoo-dev 2007-08-05 16:17:40 UTC
app-text/rhyme/rhyme-0.9.ebuild:        prepallman -> This is yours taviso
dev-lang/cxx/cxx-6.5.9.31-r1.ebuild:    prepallman -> This is yours taviso
dev-lang/cxx/cxx-6.5.9.31.ebuild:       prepallman -> This is yours taviso
net-misc/putty/putty-0.58.ebuild:       prepallman -> This is yours taviso
net-misc/putty/putty-0.59.ebuild:       prepallman -> This is yours taviso

These are left, according to 'grep -r prepallman * | grep .ebuild' in gentoo-x86/

Sound is gone, fixed sox.
Comment 17 Samuli Suominen (RETIRED) gentoo-dev 2007-08-05 16:41:00 UTC
in eclass/
ruby.eclass:    prepallman
Comment 18 Hans de Graaff gentoo-dev Security 2007-08-06 05:09:15 UTC
(In reply to comment #17)
> in eclass/
> ruby.eclass:    prepallman

See comment #15. I have not looked into the matter myself yet, but from the comment it looks like the usage should remain in the ruby.eclass? 

Comment 19 SpanKY gentoo-dev 2007-08-06 12:35:44 UTC
except that ruby.eclass gets prepall wrong

the tail of it should read:
(unset prepall; prepall)
Comment 20 Hans de Graaff gentoo-dev Security 2007-08-17 18:46:54 UTC
ruby.eclass now fixed in revision 1.66.
Comment 21 Mark Loeser (RETIRED) gentoo-dev 2007-12-23 06:07:10 UTC
I cleaned up taviso's packages.  Bug 167029 is a slightly different issue, so we'll just track that one there.