Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 140596 - media-gfx/splashutils-1.3-r1 incorrectly assumes -lmng -llcms
Summary: media-gfx/splashutils-1.3-r1 incorrectly assumes -lmng -llcms
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
: 141985 143252 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-07-15 23:39 UTC by ferret
Modified: 2006-08-08 15:19 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ferret 2006-07-15 23:39:47 UTC
Problem 1: In ${WORKDIR}/splashutils-1.3/Makefile, line 89:
LDLIBS += -lmng -llcms -ljpeg -lz

This goes into effect if you set mng in your USE.  However, neither lcms nor libmng packages are in the DEPEND, and neither library is in the tarball.

On my system, I had libmng but no lcms, thus the compile failed at the link stage.

These two libraries either need to be provided in the tarball or *DEPENDed upon - I personally don't know which is the correct way.

Problem 2: While I'm here, there's also a problem with line 186 of the same file:
sed -i "s:#define JMESSAGE.*::" jerror.c ; \

Since the CWD at that point is $(ROOT)/$(OBJDIR)/jpeglib, which doesn't contain that file, this sed fails (although the ebuild happily chugs on regardless).

This line clearly needs to be:
sed -i "s:#define JMESSAGE.*::" $(ROOT)/$(JPEGSRC)/jerror.c ; \
Comment 1 ferret 2006-07-15 23:50:13 UTC
Oops, forgot to mention for anyone who wanders along -- lcms is a USE-conditional dep of libmng (as is libjpeg, which may be irrelevant).  Maybe the ebuild needs built_with_use from the eutils eclass?
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-07-28 03:43:57 UTC
*** Bug 141985 has been marked as a duplicate of this bug. ***
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-08-08 13:50:30 UTC
*** Bug 143252 has been marked as a duplicate of this bug. ***
Comment 4 Michal Januszewski (RETIRED) gentoo-dev 2006-08-08 15:19:35 UTC
Fixed in 1.3-r2, thanks for your help and reporting the problem.