Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 140179 - x11-libs/xforms --as-needed patch
Summary: x11-libs/xforms --as-needed patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Other
: High normal (vote)
Assignee: Charlie Shepherd (RETIRED)
URL:
Whiteboard:
Keywords: Inclusion
: 155989 (view as bug list)
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2006-07-12 21:02 UTC by Robert Marmorstein
Modified: 2006-11-23 09:30 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to make xforms compile with as-needed flag (xforms-1.0.90-as-needed.patch,385 bytes, patch)
2006-07-12 21:41 UTC, Robert Marmorstein
Details | Diff
patch against xforms-1.0.90-r1.ebuild (xforms-1.0.90-r1.ebuild-as-needed.diff,963 bytes, patch)
2006-09-02 13:53 UTC, Matthias Schwarzott
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Marmorstein 2006-07-12 21:02:52 UTC
xforms breaks with libXpm not found errors when compiled with -Wl,--as-needed in the linker flags.  I will add a patch that fixes the problem.
Comment 1 Robert Marmorstein 2006-07-12 21:41:41 UTC
Created attachment 91614 [details, diff]
patch to make xforms compile with as-needed flag

Allows xforms to compile with --as-needed by linking libXpm to libforms.la.
Requires an "eautoreconf" in src_unpack.
Comment 2 Sander Sweers 2006-07-12 23:35:12 UTC
You can do this yourself by making the bug block the tracker bug 129413.
Comment 3 Matthias Schwarzott gentoo-dev 2006-09-02 13:53:14 UTC
Created attachment 95785 [details, diff]
patch against xforms-1.0.90-r1.ebuild

With these changes to the ebuild it compiles perfectly with --as-needed.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2006-11-23 01:34:52 UTC
*** Bug 155989 has been marked as a duplicate of this bug. ***
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2006-11-23 01:36:18 UTC
@masterdriverz - you've added the patch, but ${P} doesn't include -r1. Either change it to ${PF} or preferably rename the patch. :)
Comment 6 Charlie Shepherd (RETIRED) gentoo-dev 2006-11-23 04:46:53 UTC
Meh, my bad. Will fix when I get home.
Comment 7 Charlie Shepherd (RETIRED) gentoo-dev 2006-11-23 04:47:09 UTC
Assigning...
Comment 8 Charlie Shepherd (RETIRED) gentoo-dev 2006-11-23 09:30:50 UTC
Fixed in CVS, my apologies for any inconveniences