Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 14010 - REQUEST: addition of tcl-sql to portage
Summary: REQUEST: addition of tcl-sql to portage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Doug Goldstein (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-15 23:26 UTC by Jake Weg
Modified: 2004-08-08 21:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild. (tcl-sql-20000114.ebuild,981 bytes, text/plain)
2004-08-07 13:57 UTC, Will Buckner
Details
fix-const.patch (fix-const.patch,2.37 KB, patch)
2004-08-08 02:34 UTC, Ming Zhao (RETIRED)
Details | Diff
Complete patch (tcl-sql_gentoofixes.patch,3.58 KB, patch)
2004-08-08 12:30 UTC, Will Buckner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Weg 2003-01-15 23:26:54 UTC
can u add tclsql to emerge.

http://www.parand.com/tcl-sql/

it hasnt been updated in a while and there is a bug in the source that prevents 
it from being compiled in the present version of GCC I fixed these problems for 
myself if you want the fixes just email me thank you

eweg@optonline.net
Comment 1 Seemant Kulleen (RETIRED) gentoo-dev 2003-01-17 08:45:03 UTC
please do
Comment 2 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2003-06-29 06:00:43 UTC
I can't see that any ebuild, nor patches have been attached to this bug. 

If you have to the time, please attach an ebuild and any patches you had to apply to the upstream sources to this bug, and reopen it.

Comment 3 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2003-11-03 10:30:30 UTC
Sorry. I don't have the capacity to deal with tcl and tk stuff anymore.
Comment 4 Doug Goldstein (RETIRED) gentoo-dev 2004-08-06 14:02:46 UTC
Jake,

If you attach an ebuild here or at least your fixes to make it compile. I will gladly review the ebuild/patches and work on getting it included into Portage.

-Doug
Comment 5 Will Buckner 2004-08-07 13:57:11 UTC
Created attachment 36977 [details]
Ebuild.

Created an ebuild. Tested; works.

Will Buckner (Wcc)
Comment 6 Doug Goldstein (RETIRED) gentoo-dev 2004-08-07 15:38:29 UTC
Will,

ebuild does not work as expected.

sql.cc: In function `int Sql_Init(Tcl_Interp*)':
sql.cc:228: error: invalid conversion from `int (*)(void*, Tcl_Interp*, int,
   char**)' to `int (*)(void*, Tcl_Interp*, int, const char**)'
make: *** [obj/sql.o] Error 1
Comment 7 Will Buckner 2004-08-07 20:20:27 UTC
Hmm, didn't get that here.

538 taf ~ # ebuild /usr/portage/dev-tcltk/tcl-sql/tcl-sql-20000114.ebuild install
>>> md5 src_uri ;-) tcl-sql-20000114.tgz
>>> Checking tcl-sql-20000114.tgz's mtime...
>>> /usr/portage/dev-tcltk/tcl-sql/tcl-sql-20000114.ebuild has been updated; recreating WORKDIR...
>>> Unpacking source...
>>> Unpacking tcl-sql-20000114.tgz to /var/tmp/portage/tcl-sql-20000114/work
>>> Source unpacked.
g++ -c -I/usr/local/include -I/usr/include/mysql -I/usr/local/mysql/include -fPIC  -Wall -o obj/sql-mysql.o sql-mysql.cc
g++ -c -I/usr/local/include -I/usr/include/mysql -I/usr/local/mysql/include -fPIC  -Wall -o obj/sql.o sql.cc
g++ -c -I/usr/local/include -I/usr/include/mysql -I/usr/local/mysql/include -fPIC  -Wall -o obj/sql-manager.o sql-manager.cc
g++ obj/sql-mysql.o obj/sql.o obj/sql-manager.o  -L/usr/lib/mysql -L/usr/local/mysql/lib -L/usr/lib -lmysqlclient -shared -lgcc -o sql.so

>>> Install tcl-sql-20000114 into /var/tmp/portage/tcl-sql-20000114/image/ category dev-tcltk
man:
prepallstrip:
strip: 
strip: 
   usr/lib/tcl-sql/libtcl-sql.so
>>> Completed installing into /var/tmp/portage/tcl-sql-20000114/image/


---

Tcl version? I will do some more testing. I do not possibly see how line 228 of sql.cc could be generating that error, though. Hmm.
Comment 8 Will Buckner 2004-08-07 20:34:44 UTC
In fact, line 228 is blank.
Comment 9 Doug Goldstein (RETIRED) gentoo-dev 2004-08-08 01:35:15 UTC
I'm running tcl-8.4.6.


Line 228 contains a NULL function pointer way off to the right of the screen as part of a function call, but I didn't get a chance to find where the overload is declared. It didn't look like it was declared by tcl-sql so it appears its declared by tcl but then there wouldn't be this conflict so I basically need to look into it more.
Comment 10 Will Buckner 2004-08-08 01:51:08 UTC
Same version I'm running, but no errors here. Very odd. If you look at the error, the prototypes don't even remotely match. I don't see what could be causing the error.
Comment 11 Ming Zhao (RETIRED) gentoo-dev 2004-08-08 02:34:53 UTC
Created attachment 37007 [details, diff]
fix-const.patch

a simple patch to fix the compile error:  sql.cc:228: error: invalid conversion
from...
Comment 12 Doug Goldstein (RETIRED) gentoo-dev 2004-08-08 08:10:20 UTC
yeah.. that patch is kind of wrong. That patch is to remove the fixes that are needed to make this compile and it gets the sources back to their original state. Had to reverse the patch but it compiles. Commiting it because if you look at the C... logically... that patch is needed.
Comment 13 Will Buckner 2004-08-08 12:30:43 UTC
Created attachment 37057 [details, diff]
Complete patch

Well, if we have to apply a patch anyway, we can go ahead and move all the
changes to a patch and remove the 'sedMagic' (TM) from src_compile().

(Attached new patch.. changes in the ebuild should be trivial).
Comment 14 Doug Goldstein (RETIRED) gentoo-dev 2004-08-08 21:31:22 UTC
Thank you. Reworked and used. :)