First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 139337
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Catalyst Developers <catalyst@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Joshua Kinard <kumba@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
cat2-mips-create_iso_sh-tweaks.patch mips tweaks for targets/support/create-iso.sh patch Joshua Kinard 2006-07-05 10:01 0000 3.01 KB Details | Diff
cat2-mips-arcload_conf-tweaks.patch Update the source file for generating the arcload config patch Joshua Kinard 2006-07-05 10:03 0000 4.61 KB Details | Diff
cat2-main-livecd_update-tweak.patch Update gdm.conf handling to account for gdm-2.14 differences patch Joshua Kinard 2006-07-05 10:45 0000 2.16 KB Details | Diff
cat2-main-kermge_kerncache-tweak.patch Prevent catalyst from re-merging sources all the time patch Joshua Kinard 2006-07-05 10:47 0000 523 bytes Details | Diff
cat2-main-generic_stage_target-tweaks1.patch Favour settings in the specfile versus make.conf patch Joshua Kinard 2006-07-05 10:49 0000 2.32 KB Details | Diff
cat2-mips-bootloader_setup-tweaks.patch Add sanity checks to mips' bootloader-setup section patch Joshua Kinard 2006-07-05 10:57 0000 1.68 KB Details | Diff
cat2-main-stage_target_overrides.patch Fix chost/c[xx]flags/ldflags overrides patch Joshua Kinard 2006-07-05 13:45 0000 2.09 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 139337 depends on: Show dependency tree
Bug 139337 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-07-05 09:59 0000
Attached are several patches for catalyst to get in some final mips tweaks and
miscellaneous catalyst tweaks.  Some are safe to go right in, others could use
a review and consideration.  I'll denote which should need review.

------- Comment #1 From Joshua Kinard 2006-07-05 10:01:46 0000 -------
Created an attachment (id=90980) [edit]
mips tweaks for targets/support/create-iso.sh

Changes the supported fstype to squashfs, adds some additional comments to
better explain things, and some conditional checks before shifting files
around.

------- Comment #2 From Joshua Kinard 2006-07-05 10:03:40 0000 -------
Created an attachment (id=90981) [edit]
Update the source file for generating the arcload config

Modifies the arcload config source file so that the generated config passes
needed variables for loading an X-based LiveCD.

------- Comment #3 From Joshua Kinard 2006-07-05 10:45:30 0000 -------
Created an attachment (id=90988) [edit]
Update gdm.conf handling to account for gdm-2.14 differences

gdm-2.14 uses defaults in /usr/share/gdm/defaults.conf and desired changes go
into an overlay config in /etc/X11/gdm/custom.conf versus the old behavior of
applying sed maginc to /etc/X11/gdm/gdm.conf.

------- Comment #4 From Joshua Kinard 2006-07-05 10:47:52 0000 -------
Created an attachment (id=90989) [edit]
Prevent catalyst from re-merging sources all the time

This one needs some review.  In my test runs for both netboot2 and
livecd-stage2, catalyst would always wipe out and re-merge the kernel sources
even when kerncache was set, which got annoying.  The deleted block of code
doesn't make a whole lot of sense to me, but removing it makes catalyst keep
the sourcetree around unless -p is passed or the kerncache is manually deleted.
 Some review on this behavior might be warranted.

------- Comment #5 From Joshua Kinard 2006-07-05 10:49:31 0000 -------
Created an attachment (id=90990) [edit]
Favour settings in the specfile versus make.conf

If a particular setting is specified in the spec files, use that instead fo
what may be specified in the make.conf in the chroot.  If no spec file setting
is available, then the value from make.conf is used if it exists.

This one might need some review too.

------- Comment #6 From Joshua Kinard 2006-07-05 10:57:19 0000 -------
Created an attachment (id=90992) [edit]
Add sanity checks to mips' bootloader-setup section

Before moving or deleting directories, check that the target exists first.

------- Comment #7 From Joshua Kinard 2006-07-05 13:45:01 0000 -------
Created an attachment (id=91008) [edit]
Fix chost/c[xx]flags/ldflags overrides

This modifies generic_stage_target so that the override functions for chost,
cflags, cxxflags, and ldflags only pull their values from the make.conf file by
default.  As such, stage3, stage4, grp, tinderbox, netboot[1|2], and the
embedded targets all use this method to set these values.  stage1 and stage2
override this behavior, however, and pull their values from the spec file.

------- Comment #8 From Chris Gianelloni (RETIRED) 2006-07-11 14:42:05 0000 -------
OK.  I put these in CVS.  I did do a little shuffling of the gdm stuff because
I didn't like how it read and preferred to try to keep things to 80 columns. 
It doesn't change the functionality, except in places where the patch made
incorrect assumptions, such as defaulting to the "gentoo" user.  This will show
up in 2.0_rc50.

------- Comment #9 From Andrew Gaffney 2006-07-11 15:48:31 0000 -------
The gdm patch was a bit wrong. It tries to interpolate ${sedxtra} in a
single-quoted string, which just doesn't work. I modifed it a bit locally, and
it works fine.

First, I changed sedxtra to autologin_user:

                [ -n "${clst_livecd_users}" ] && [ -n "${first_user}" ] \
                    && autologin_user="${first_user}" \
                    || autologin_user="gentoo"

Then I changed the sed a bit:

                sed -e
's:\(\[daemon\]\)$:\1\nTimedLoginEnable=true\nTimedLoginDelay=10\nTimedLogin='${autologin_user}':'

------- Comment #10 From Chris Gianelloni (RETIRED) 2006-07-12 11:32:18 0000 -------
Umm... Andrew?  Did you read the patch I actually *applied* versus what was
posted here?  :P

------- Comment #11 From Andrew Gaffney 2006-07-12 11:41:57 0000 -------
Nope :P

------- Comment #12 From Chris Gianelloni (RETIRED) 2006-07-19 17:13:52 0000 -------
Fixed in 2.0_rc50...

First Last Prev Next    No search results available      Search page      Enter new bug