First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 138415
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Shell Tools Herd Bugs <shell-tools@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: James Rowe <jnrowe@gmail.com>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
when-fix_test_environment.patch when-fix_test_environment.patch patch James Rowe 2006-06-28 17:32 0000 728 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 138415 depends on: Show dependency tree
Bug 138415 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2006-06-28 17:31 0000 
Emerging app-misc/when fails when FEATURES=test, because the tool requires
a semi-setup work environment and attempts to call the binary without a path
from the Makefile.

  The attached patch fixes both these problems, and allows the building of
when if FEATURES=test is set.

Thanks


James

------- Comment #1 From James Rowe 2006-06-28 17:32:03 0000 ------- 
Created an attachment (id=90391) [edit]
when-fix_test_environment.patch

------- Comment #2 From Ryan Hill 2007-01-19 04:49:14 0000 ------- 
we can't touch ${HOME} from an ebuild, it violates our sandbox environment. 
i've added a test restriction to the ebuild instead.

------- Comment #3 From James Rowe 2007-01-20 06:49:32 0000 ------- 
First, thanks for getting around to this bug.

> ------- Comment #2 from dirtyepic@gentoo.org  2007-01-19 04:49 -0800 -------
> we can't touch ${HOME} from an ebuild, it violates our sandbox environment.
> i've added a test restriction to the ebuild instead.

  Please reconsider this change.  Using HOME isn't a sandbox violation,
because it doesn't touch any files outside of portage's temp directory.

  Portage creates a package specific HOME for use by ebuilds.  Take a look
at /usr/lib/portage/pym/portage.py to see the implementation or just add an
'echo $HOME' to an ebuild to see it in action ;)  Paludis also handles this
in ebuild/builtin_init.bash and pkgcore in pkgcore/ebuild/ebd.py, admittedly
I haven't tried either of those just read the source.

Thanks,

James

------- Comment #4 From Ryan Hill 2007-01-22 00:11:15 0000 ------- 
well, learn something new every day. ;)

i've undone my change and applied your patch.  thanks.
First Last Prev Next    No search results available      Search page      Enter new bug