First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 136351
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Catalyst Developers <catalyst@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Andrew Gaffney <agaffney@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 136351 depends on: Show dependency tree
Bug 136351 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-06-10 19:04 0000
Starting at line 511 in modules/generic_stage_target.py, there's the following
code:

  for y in loop2:
    if not addlargs.has_key("boot/kernel/"+x+"/packages"):
      addlargs["boot/kernel/"+x+"/packages"]=[[y]]
    else:
      addlargs["boot/kernel/"+x+"/packages"].append(y)

The first part of the 'if' block appears to do something undesired. It creates
the initial list and then sticks the first package inside another list.
Subsequent packages are added to the main list. This would result in something
like:

  [ [ "pkg1" ], "pkg2", "pkg3", "pkg4", "pkg5" ]

Somehow, this just doesn't seem right.

------- Comment #1 From Chris Gianelloni (RETIRED) 2006-06-22 07:19:52 0000 -------
What would you recommend as a fix?

------- Comment #2 From Andrew Gaffney 2006-06-22 07:24:54 0000 -------
Get rid of one of the sets of brackets in the first part of the 'if':

addlargs["boot/kernel/"+x+"/packages"]=[y]

------- Comment #3 From Chris Gianelloni (RETIRED) 2006-06-22 07:54:53 0000 -------
Heh... why didn't you just say that?  :P

------- Comment #4 From Andrew Gaffney 2006-06-22 08:19:15 0000 -------
Because that would have just made sense?

------- Comment #5 From Chris Gianelloni (RETIRED) 2006-06-28 06:00:14 0000 -------
Fixed in 2.0_rc49

First Last Prev Next    No search results available      Search page      Enter new bug