Bug 136351 – possible problem with boot/kernel/foo/packages processing

• Status: RESOLVED FIXED
• Product: Gentoo Hosted Projects

[Description Andrew Gaffney (RETIRED) 2006-06-10 19:04:44 UTC]

Starting at line 511 in modules/generic_stage_target.py, there's the following code:

  for y in loop2:
    if not addlargs.has_key("boot/kernel/"+x+"/packages"):
      addlargs["boot/kernel/"+x+"/packages"]=[[y]]
    else:
      addlargs["boot/kernel/"+x+"/packages"].append(y)

The first part of the 'if' block appears to do something undesired. It creates the initial list and then sticks the first package inside another list. Subsequent packages are added to the main list. This would result in something like:

  [ [ "pkg1" ], "pkg2", "pkg3", "pkg4", "pkg5" ]

Somehow, this just doesn't seem right.

[Comment 1 Chris Gianelloni (RETIRED) 2006-06-22 07:19:52 UTC]

What would you recommend as a fix?

[Comment 2 Andrew Gaffney (RETIRED) 2006-06-22 07:24:54 UTC]

Get rid of one of the sets of brackets in the first part of the 'if':

addlargs["boot/kernel/"+x+"/packages"]=[y]

[Comment 3 Chris Gianelloni (RETIRED) 2006-06-22 07:54:53 UTC]

Heh... why didn't you just say that?  :P

[Comment 4 Andrew Gaffney (RETIRED) 2006-06-22 08:19:15 UTC]

Because that would have just made sense?

[Comment 5 Chris Gianelloni (RETIRED) 2006-06-28 06:00:14 UTC]

Fixed in 2.0_rc49