Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 135103 - [new ebuild] sci-biology/gmap-20060421
Summary: [new ebuild] sci-biology/gmap-20060421
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: George Shapovalov (RETIRED)
URL: http://www.gene.com/share/gmap/
Whiteboard:
Keywords: EBUILD, InOverlay
Depends on: weaver
Blocks:
  Show dependency tree
 
Reported: 2006-05-31 21:15 UTC by Andrey Kislyuk (RETIRED)
Modified: 2008-05-26 14:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gmap-20060421.ebuild (gmap-20060421.ebuild,413 bytes, text/plain)
2006-05-31 21:16 UTC, Andrey Kislyuk (RETIRED)
Details
die on make failure (gmap-20060421.ebuild,420 bytes, text/plain)
2006-06-02 12:04 UTC, Andrey Kislyuk (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kislyuk (RETIRED) gentoo-dev 2006-05-31 21:15:46 UTC
A Genomic Mapping and Alignment Program for mRNA and EST Sequences

http://www.gene.com/share/gmap/

This is a very simple ebuild, however the package license is custom afaik.
Comment 1 Andrey Kislyuk (RETIRED) gentoo-dev 2006-05-31 21:16:27 UTC
Created attachment 88063 [details]
gmap-20060421.ebuild
Comment 2 Andrey Kislyuk (RETIRED) gentoo-dev 2006-06-01 06:27:37 UTC
This package should be put in sci-biology.

The license for this package is:

Copyright (c) 2005 Genentech, Inc.  All rights reserved.

The Developers of this software are Thomas D. Wu <twu@gene.com> and
Colin K. Watanabe <ckw@gene.com>.

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Package"), to use, copy, and distribute copies of the Package,
without modifications, provided that the above copyright notice and
this permission notice are included in all copies or substantial
portions of the Package.  Distribution of this Package as part of a
commercial software product requires prior arrangement with the
Developers.

Permission is also hereby granted, free of charge, to any person
obtaining a copy of this Package, to modify your copy or copies of the
Package or any portion of it, provided that you use the modified
Package only within your corporation or organization.  Distribution of
a modified version of this Package requires prior arrangement with the
Developers.

Genome databases, map files, and other result files produced as output
from software in this Package do not automatically fall under the
copyright of this Package, but belong to whoever generated them, and
may be distributed freely.

IN NO EVENT SHALL GENENTECH, INC. BE LIABLE TO ANY PARTY FOR DIRECT,
INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, OR OTHER
LIABILITY, INCLUDING LOST PROFITS, ARISING FROM THE USE OF THIS
SOFTWARE.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
GENENTECH, INC. HAS NO OBLIGATION TO PROVIDE MAINTENANCE, SUPPORT,
UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
Comment 3 Andrey Kislyuk (RETIRED) gentoo-dev 2006-06-02 12:04:11 UTC
Created attachment 88207 [details]
die on make failure
Comment 4 Andrey Kislyuk (RETIRED) gentoo-dev 2006-12-20 10:00:01 UTC
The latest version can be found at

http://www.gentoo-sunrise.org/sunrise/browser/reviewed/sci-biology/gmap
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2006-12-20 10:05:37 UTC
I'm already in sci-bio.
Comment 6 Olivier Fisette (RETIRED) gentoo-dev 2007-03-09 02:19:47 UTC
I already watch this bug through the sci-biology alias.
Comment 7 George Shapovalov (RETIRED) gentoo-dev 2007-12-14 23:06:18 UTC
Hi Andrey.

Sorry for the delay. I'll try to go through some of your ebuilds finally.
This one is pretty basic, still there are a few things you should cleanup, even though they are stylistical (I guess this is one of the early ones? I saw some of the recent in overlays and those were quite cleaner).

1. The ebuild is missing headers required for proper processing in cvs, please add those (Copyright, License and Header lines). In general, please use template, such as skel.ebuild for example, as a basis of new ebuilds. Even just using "vim pkg-ver.ebuild" when creating a new file will pull in a relevant template.

2. RESTRICT="nomirror" should be RESTRICT="mirror"

3. MY_P="`expr substr ${PV} 1 4`-`expr substr ${PV} 5 2`-`expr substr ${PV} 7 2`"
Two issues actually:
3.1: please use $(action) form instead of backquotes
3.2: It would be better to use versionator.eclass here

4. Is there really nothing else to install? At the very least "dodoc AUTHORS Changelog ..." for the common files should be added (no need to have INSTALL there, but should contain COPYING)

Oh, and the latest version out is 2007-09-28 at the moment, so please update ebuild with these remarks to that version ;).

George
Comment 8 Andrey Kislyuk (RETIRED) gentoo-dev 2007-12-14 23:08:46 UTC
George,

As I mention in the comments, the latest version can be found at

http://www.gentoo-sunrise.org/sunrise/browser/reviewed/sci-biology/gmap

I update that regularly (it's currently at the latest version) and it corrects all the issues you list. As far as I can tell there's nothing else to dodoc, no.
Comment 9 George Shapovalov (RETIRED) gentoo-dev 2007-12-14 23:08:46 UTC
For tracking purposes adding recruitment bug as a dependency. Not the other way around, as we'll do commits together when you get access, so it will be closed after recruitment.
Comment 10 Andrey Kislyuk (RETIRED) gentoo-dev 2007-12-14 23:09:35 UTC
sorry, that link has now become

http://overlays.gentoo.org/proj/sunrise/browser/sunrise/sci-biology/gmap
Comment 11 George Shapovalov (RETIRED) gentoo-dev 2007-12-14 23:45:21 UTC
Ah, yes, sorry, I already added sunrise to overlays, but after going through this one. The version in the overlay looks quite allright :). I'll go through a few more of your ebuilds and then pester recruiters on the recruitment bug..

George
Comment 12 Andrey Kislyuk (RETIRED) gentoo-dev 2008-05-23 19:28:36 UTC
InCVS
Comment 13 Martin Mokrejš 2008-05-26 10:53:07 UTC
Please allow also for ~amd64, it compiles fine for me hre.
Comment 14 Andrey Kislyuk (RETIRED) gentoo-dev 2008-05-26 14:35:44 UTC
Keyworded, thanks