Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 134377 - groff-1.19.1 CJK patch
Summary: groff-1.19.1 CJK patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-25 19:39 UTC by Atsushi Kobayashi
Modified: 2006-12-30 05:54 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
groff-1.19.1-japanese-r5111.patch (groff-1.19.1-japanese-r5111.patch,285.66 KB, text/plain)
2006-05-25 19:41 UTC, Atsushi Kobayashi
Details
groff-1.19.1-r3.ebuild (groff-1.19.1-r3.ebuild,3.55 KB, text/plain)
2006-05-25 19:43 UTC, Atsushi Kobayashi
Details
review log by solar and SpanKY (irc-tailed.log,1.80 KB, text/plain)
2006-05-25 21:26 UTC, hiyuh
Details
groff-1.19.1-r3.ebuild (patch get from original URL) (groff-1.19.1-r3.ebuild,3.66 KB, text/plain)
2006-05-26 00:29 UTC, Atsushi Kobayashi
Details
A diff of ebuild of groff 1.19.1-r2 and 1.19.1-r3 (hopefully) (groff-1.19.1-r2_to_r3.diff,3.66 KB, patch)
2006-05-31 05:03 UTC, hiyuh
Details | Diff
A diff of ebuild of man-pages-ja ebuild for making it no block >=groff-1.19.* (man-pages-ja-20060415-r2_r3.diff,481 bytes, patch)
2006-05-31 05:07 UTC, hiyuh
Details | Diff
My man.conf (a working sample) (man.conf,4.72 KB, text/plain)
2006-06-27 05:12 UTC, hiyuh
Details
groff-1.19.2-r2.ebuild (groff-1.19.2-r2.ebuild,3.09 KB, text/plain)
2006-07-14 17:25 UTC, michael@smith-li.com
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Atsushi Kobayashi 2006-05-25 19:39:01 UTC
Im import groff-1.19.1 CJK patch from Momonga Linux.
This patch bring manpages-ja can use with groff-1.19.1
Comment 1 Atsushi Kobayashi 2006-05-25 19:41:25 UTC
Created attachment 87523 [details]
groff-1.19.1-japanese-r5111.patch

This patch from http://developer.momonga-linux.org/viewcvs/*checkout*/trunk/pkgs/groff/groff-1.19.1-japanese.patch?rev=5111
Comment 2 Atsushi Kobayashi 2006-05-25 19:43:29 UTC
Created attachment 87524 [details]
groff-1.19.1-r3.ebuild

USE="cjk" activated ebuild based on groff-1.19.1-r2.ebuild
Comment 3 Atsushi Kobayashi 2006-05-25 19:49:38 UTC
re-emerge these
USE="cjk nls" LINGUAS="ja en" emerge man groff man-pages man-pages-ja lv

It will work
PAGER="lv -c" LANG="ja_JP.eucJP" man ls
we can view man-pages-ja again without old groff 1.18.*
Comment 4 hiyuh 2006-05-25 21:26:52 UTC
Created attachment 87525 [details]
review log by solar and SpanKY

SpanKY and solar commented this stuff.
Some TODO are to stuff it into officail tree.
Please see that log, and poke its ebuild. :)
Comment 5 Atsushi Kobayashi 2006-05-26 00:29:25 UTC
Created attachment 87535 [details]
groff-1.19.1-r3.ebuild (patch get from original URL)

okay, rewrited ebuild here.
fetch patch direct from 
http://developer.momonga-linux.org/viewcvs/*checkout*/trunk/pkgs/groff/groff-1.19.1-japanese.patch
case this patch placed gentoo mirror, please change URI and epatch command comment out version.
Comment 6 hiyuh 2006-05-31 05:03:50 UTC
Created attachment 87972 [details, diff]
A diff of ebuild of groff 1.19.1-r2 and 1.19.1-r3 (hopefully)

I've re-rewite "ready to commit" groff-1.19.1-r3 ebuild for CJK support
and added die's message or so on, IMHO.
It can be apply to groff-1.19-r2.ebuild in official tree.
Comment 7 hiyuh 2006-05-31 05:07:49 UTC
Created attachment 87974 [details, diff]
A diff of ebuild of man-pages-ja ebuild for making it no block >=groff-1.19.*

I've modified man-pages-ja ebuild for making it no block >=groff-1.19.* anymore.
It can be applied to man-pages-ja-20060415-r2.
Comment 8 hiyuh 2006-05-31 05:10:33 UTC
FYI, groff-1.19.1-r3 (hopefully) seems work for me, too.
When it was compiling, some uninitialization or so on are warned, though.
Comment 9 hiyuh 2006-06-27 04:57:49 UTC
FYI, /etc/man.conf has some sys-apps/groff's configuration.
But it's installed as one of sys-apps/man's stuffs.
Unfortunately, sys-apps/groff-1.19.1-r3 (hopefully) wouldn't work with
official /etc/man.conf (it means default which is installed as a
sys-apps/man stuff, e.g. sys-apps/man-1.6d), IIRC.

So, it's require to edit for reading bilingual man-pages.
I'll file my /etc/man.conf as a working sample.
Comment 10 hiyuh 2006-06-27 05:12:14 UTC
Created attachment 90268 [details]
My man.conf (a working sample)

NOTE:
 * EUC-JP locale are required for proper working groff with -Tnippon.
 * And then, PAGER and BROWSER should have encoding trans functionality
   when user locale is not EUC-JP.

My default locale is UTF-8, of cource.
 LANG="ja_JP.UFT-8"
 LC_ALL="ja_JP.UTF-8"
If you use this man.conf,
when just do man hogehoge shows hogehoge's man-pages-ja, if it's available,
when do LANG="en_US.UTF-8" LC_ALL="en_US.UTF-8" man fugafuga shows
fugafuga's man-pages.
Of cource, you can put it as a alias of "eman" or so on.
Comment 11 michael@smith-li.com 2006-07-14 17:25:31 UTC
Created attachment 91745 [details]
groff-1.19.2-r2.ebuild

Similar ebuild w/cjk patch for groff-1.19.2. 

I took a slightly different approach to this ebuild, asking the user to put the gzipped patch in $FILESDIR since I've never seen a patch come from $WORKDIR before (is that common with large patches?)

Anyway, at this development stage it's all fairly safe because testers would have to use an overlay to test this anyway.

JP_PATCH_URI= http://developer.momonga-linux.org/viewcvs/*check
out*/trunk/pkgs/groff/groff-1.19.2-japanese.patch?rev=10378
Comment 12 Chris White (RETIRED) gentoo-dev 2006-08-14 21:05:30 UTC
Looked over this rather large patch.  From what I noted most of it looks ok and is just using wide character logic versus traiditional char logic due to the multibyte nature of Japanese.

There was some stuff towards the end that seemed a little odd, namely the entire #if 0 business.  Wasn't sure what the patch author was trying to accomplish there.

Other than that looks good, though someone else gets to vouch for the almost-but-not-really-lisp looking macro stuff at the end.
Comment 13 hiyuh 2006-12-17 07:49:53 UTC
FYI, sys-apps/portage-2.1.2_rc3-r6 breaks here's sys-apps/groff-1.19.1-r3.
B/c USE flag sensitive SRC_URI stuff is not parenthetic.
I'm not sure this breakage is caused by official policy.
But this diff can help, I though.

diff -r 3279378b9645 -r a1fe5eb9e98f sys-apps/groff/groff-1.19.1-r3.ebuild
--- a/sys-apps/groff/groff-1.19.1-r3.ebuild	Sun Dec 17 21:54:38 2006 +0900
+++ b/sys-apps/groff/groff-1.19.1-r3.ebuild	Mon Dec 18 00:40:56 2006 +0900
@@ -9,7 +9,7 @@ HOMEPAGE="http://www.gnu.org/software/gr
 
 JP_PATCH_REV="5111"
 SRC_URI="mirror://gnu/groff/${P}.tar.gz
-	cjk? mirror://gentoo/${P}-japanese-r${JP_PATCH_REV}.patch.gz"
+	cjk? ( mirror://gentoo/${P}-japanese-r${JP_PATCH_REV}.patch.gz )"
 # FIXME:
 # See bug #134377.
 #
Comment 14 SpanKY gentoo-dev 2006-12-29 16:03:08 UTC
groff-1.19.2-r1 now contains the patch, thanks all
Comment 15 Mamoru KOMACHI (RETIRED) gentoo-dev 2006-12-30 05:46:05 UTC
Thanks SpanKY. However, the ebuild should run eautoreconf and trun --enable-japanese on to actually build cjk support. This is fixed in CVS.
Comment 16 SpanKY gentoo-dev 2006-12-30 05:54:47 UTC
accept that your changes now cause 'die' to be run for everyone with USE=-cjk

fixed in cvs