First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 134070
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Default Assignee for Orphaned Packages <maintainer-needed@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Ole Craig <olc@macmillan-craig.net>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
glastree-gmake381.diff patch to glastree's makefile patch Ole Craig 2006-05-22 16:32 0000 847 bytes Details | Diff
glastree-1.04.ebuild ebuild that uses the patch text/plain Ole Craig 2006-05-22 16:33 0000 745 bytes Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 134070 depends on: Show dependency tree
Show dependency graph
Bug 134070 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-05-22 16:31 0000
backslash-newlines within shell commands are handled differently in make 3.81,
which breaks the glastree makefile since it uses a perl command to figure out
whether Date::Calc is installed and that perl command is spread out over
several lines for readability.

workaround 1: use make 3.80-rX

workaround 2: edit the glastree makefile to remove the backslash-newlines, or
encapsulate the perl within a makefile variable. See attached ebuild and
patchfile.

------- Comment #1 From Ole Craig 2006-05-22 16:32:49 0000 -------
Created an attachment (id=87291) [edit]
patch to glastree's makefile

------- Comment #2 From Ole Craig 2006-05-22 16:33:44 0000 -------
Created an attachment (id=87292) [edit]
ebuild that uses the patch

------- Comment #3 From Jakub Moc 2006-05-23 02:24:47 0000 -------
No metadata.xml

------- Comment #4 From Ole Craig 2006-05-23 09:02:02 0000 -------
metadata.xml was missing from the ebuild I modified. I can certainly create
one, but I'm not trying to steal Terje Kvernes's package...

------- Comment #5 From Jakub Moc 2006-05-23 11:37:11 0000 -------
(In reply to comment #4)
> metadata.xml was missing from the ebuild I modified. I can certainly create
> one, but I'm not trying to steal Terje Kvernes's package...

Heh, the comment was not aimed at you, please ignore it... :)

------- Comment #6 From Harald van Dijk 2006-05-23 22:49:13 0000 -------
> # backslash-newline splitting of singlequoted commandlines is broken by GNU make 3.81

Actually, it's broken in gmake 3.80, and fixed in 3.81. The current behaviour
is what POSIX requires.

Thanks for the patch. A slightly simpler approach though is to move the code so
that both with and without the backslashes, the perl code is valid and does the
same thing. I did this for 1.04, which is in portage now.

------- Comment #7 From Ole Craig 2006-05-23 23:20:56 0000 -------
(In reply to comment #6)
> > # backslash-newline splitting of singlequoted commandlines is broken by GNU make 3.81
> 
> Actually, it's broken in gmake 3.80, and fixed in 3.81. The current behaviour
> is what POSIX requires.

Perhaps "broken" is unwarranted (or at least misplaced) verbiage in both our
comments. The upstream makefile implicitly expected the previous behaviour
(exhibited in every GNU make I've ever had to build a makefile for, which is
admittedly far from a canonical list) and as you say POSIX specs different (IMO
more confusing) behaviour. When something works for a very long time and then
suddenly stops working without internal changes, colloquial usage would hold
that something else has broken it. I suppose I should have said something more
like "GNU make 3.81 changed the way backslash-newlines are interpreted within
singlequoted commandlines, which breaks the upstream makefile." But I was in a
hurry and slightly vexed that the damn thing built on one of my gentoo boxes
but not the other. 

and, hey, I think the bugreport subject line got it more or less right... so go
grind your POSIX axe (POSaxe?) on somebody else. :-)

[...]
> I did this for 1.04, which is in portage now.

Ah, curse my slow mirrors! They prevent me from inspecting this elegant
improvement in a timely fashion!

All tongue-in-cheek aside, thanks for updating the ebuild. I'll check it out
after I've gotten some sleep.

First Last Prev Next    No search results available      Search page      Enter new bug