First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 133500
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Ruby Team <ruby@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Hans de Graaff <graaff@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
rails-1.1.6-r1.ebuild rails-1.1.6-r1.ebuild text/plain Nguyen Thai Ngoc Duy (RETIRED) 2006-10-02 05:08 0000 1.12 KB Details
1.1.6-deprecate-old-lighttpd.patch files/1.1.6-deprecate-old-lighttpd.patch patch Nguyen Thai Ngoc Duy (RETIRED) 2006-10-02 05:09 0000 651 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 133500 depends on: 123022 Show dependency tree
Bug 133500 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-05-16 08:38 0000
The use of lighttpd in Rails 1.1.2 is optional, but it is the default setup for
the internal server script in script/server. The lighttpd config file that
Rails copies into a new Rails setup contains features (in particular CWD) which
older lighttpd versions don't understand. This leads to an error which gives no
indication that a newer version of lighttpd is needed. Upgrading to lighttpd
1.4.10-r2 works fine.

------- Comment #1 From Thilo Bangert 2006-05-30 13:02:50 0000 -------
1.4.11 has been asked to be marked stable

------- Comment #2 From Jari-Matti Mäkelä 2006-09-30 03:00:52 0000 -------
(In reply to comment #1)
> 1.4.11 has been asked to be marked stable

1.4.11 has been marked stable (x86, amd64, ppc64, sparc) for a while now. Can
we close this?

------- Comment #3 From Hans de Graaff 2006-09-30 03:05:32 0000 -------
The fact that lighttpd has been marked stable does not fix the bug, it just
makes it less likely that people run into it.

I guess the right way to fix it is to add a lighttpd USE flag to the rails
ebuild and depend on >=lighttpd-0.4.10 in this case.

------- Comment #4 From Thilo Bangert 2006-09-30 03:37:28 0000 -------
perhaps adding something like

if has_version www-servers/lighttpd && has_version
<=www-servers/lighttpd-1.4.10
   ewarn "you need at least www-servers/lighttpd-1.4.10 if you want"
   ewarn "to use lighttpd with rails!"
fi

in pkg_setup and/or pkg_config
would suffice. the ebuild should possibly even die at that point... i don't
know of a reason why one would like to stick to a version below 1.4.10...

the big problem of course is, if you have rails and lighttpd installed you have
to have lighttpd-1.4.10 or higher... there is nothing to choose. AFAICT this
can't currently be modeled within an ebuild - so its just a matter of which
hack we choose...

the last alternative would be to fix the rails server script to, depending on a
use flag, use either webrick or lighttpd...

tough call

------- Comment #5 From Nguyen Thai Ngoc Duy (RETIRED) 2006-09-30 12:28:55 0000 -------
I'd rather hack commands/server.rb to ignore lighttpd older than 1.4.10 (along
with a warning maybe). However patching a gem is not very fun.
Anyway, upstream should know about this and should fix this. They've already
used `lighttpd -version` to check for lighttpd's existence. With a proper
regexp, they can determine if the installed lighttpd can be used.
Hans, did you inform upstream?

------- Comment #6 From Hans de Graaff 2006-10-01 01:49:16 0000 -------
No, I did not inform upstream at the time because I thought we could handle
this with a simple dependency. Looking through the Trac database it looks like
this was reported twice, but upstream does not appear to see this as a problem.
They just say to use 4.1.11 or higher. This is also their recommendation due to
older versions being buggy. See:

http://dev.rubyonrails.org/ticket/4344
http://dev.rubyonrails.org/ticket/4451

------- Comment #7 From Nguyen Thai Ngoc Duy (RETIRED) 2006-10-02 05:08:54 0000 -------
Created an attachment (id=98599) [edit]
rails-1.1.6-r1.ebuild

------- Comment #8 From Nguyen Thai Ngoc Duy (RETIRED) 2006-10-02 05:09:17 0000 -------
Created an attachment (id=98600) [edit]
files/1.1.6-deprecate-old-lighttpd.patch

------- Comment #9 From Nguyen Thai Ngoc Duy (RETIRED) 2006-10-02 05:11:44 0000 -------
I intend to patch rails 1.1.6 only.  Any reason I should patch older versions?
If you can test the attached ebuild, it would be highly appreciated.
I'll add it to portage some next days if there is no response.

------- Comment #10 From Hans de Graaff 2006-10-02 12:42:32 0000 -------
All the versions of rails < 1.1.6 contain a significant security leak, so they
should not be patched but instead removed from portage.

I patch seems to work fine on my system.

------- Comment #11 From Nguyen Thai Ngoc Duy (RETIRED) 2006-10-02 22:47:01 0000 -------
InCVS

First Last Prev Next    No search results available      Search page      Enter new bug