As I said, check_extra_config fails to die if anything but last test fails. Also, error/warning reporting should be done in the same manner. Patch will follow shortly.
brilliant, thanks.
CC'ing in kernel herd as well, this will need to spur awareness.
Created attachment 86612 [details, diff] linux-info.eclass.patch The improvements part: - first interpret @ and ~ operators since the natural way is to specify ~!FOE instead !~FOE (searched in the tree; nothing is affected by this change) - for "soft" checks (~ or @): give the oportunity to specify the function used to report the problem (eerror or ewarn) by defining vars like ERROR_${config} or WARNING_${config}
Please decide whether you apply this patch or not. The current net-dialup/ppp-2.4.3-r15 ebuild use features implemented by this patch; if you don't apply it, I would have to find other ways to obtain what I want.
If you don't respond till Sunday, I will consider you accept the patch and apply it myself.
(In reply to comment #5) > If you don't respond till Sunday, I will consider you accept the patch and > apply it myself. No, you will not. The patch is being looked on, have patience.
Unfortunately because of time constraints on my end, and the fact the patch touches trivial changes which add extra reading (albeit minimal) I've not had time until recently to review this. Judging from my preliminary checks, and reading through it all looks fine. Please feel free to commit and email kernel@gentoo.org to inform of the eclass changes. Perhaps attaching the patch/bug would be enough background info. Cheers, John
(In reply to comment #7) > Judging from my preliminary checks, and reading through it all looks fine. > Please feel free to commit and email kernel@gentoo.org to inform of the eclass > changes. Perhaps attaching the patch/bug would be enough background info. I've applied a slightly different patch (now the last messages are displayed using eerror when hard_errors_count > 0, otherwise ewarn being used). kernel team is in CC, therefore I find it redundant to send them an email regarding this bug. Please add me to CC list if bugs are opened regarding the new check_extra_config(). Thank you!
