132408 – Genkernel handles --tempdir wrong

Bug 132408 - Genkernel handles --tempdir wrong

Summary: Genkernel handles --tempdir wrong

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Hosted Projects
Classification:	Unclassified
Component:	genkernel (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Genkernel Maintainers

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:

Reported:	2006-05-06 00:20 UTC by Martin Parm
Modified:	2006-06-20 12:55 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Fixes for --tempdir handling (genkernel-3.3.11d_fix-tmp.patch,1.24 KB, patch) 2006-05-06 00:24 UTC, Martin Parm	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Martin Parm 2006-05-06 00:20:13 UTC

Genkernel has two minor problems with --tempdir
1) Setting --tempdir only changed the TEMP variable, so code using the TMPDIR will still use the default location
2) TEMP is set before commandline parameter are evaluated. So it's not enough just to change TEMP to TMPDIR in parse_cmdline().

This bug is a minor issue for most users, but it's a show-stopper for using genkernel in a sandboxed environment or if the default TMPDIR location (/var/tmp/) is read-only or short of space.

Comment 1 Martin Parm 2006-05-06 00:24:22 UTC

Created attachment 86237 [details, diff]
Fixes for --tempdir handling

This patch fixes the --tempdir handling.

The first part of the patch (gen_cmdline.sh) fixes the problem itself.

The second part (genkernel) is a cosmetic change, which make the evaluation order more clear. Having TEMP set after sourcing gen_cmdline.sh can be misleading.

Comment 2 Martin Parm 2006-05-06 00:29:09 UTC

The patch has been tested with genkernel-3.3.11d

Comment 3 Tim Yamin (RETIRED) gentoo-dev

2006-06-20 12:55:44 UTC

Fixed in 3.4.0_pre1, thanks.