First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 131856
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo X packagers <x11@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Ryan Hill <dirtyepic@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
freeglut-2.4.0-warnings-arent-errors.patch freeglut-2.4.0-warnings-arent-errors.patch patch Ryan Hill 2006-04-30 19:07 0000 398 bytes Details | Diff
freeglut-gcc42.patch freeglut-gcc42.patch patch Joshua Baergen (RETIRED) 2006-07-25 20:22 0000 283 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 131856 depends on: Show dependency tree
Show dependency graph
Bug 131856 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2006-04-30 19:05 0000 
freeglut-2.4.0 builds with -Werror, causing it to fail when building with GCC
4.2 

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -O2
-march=nocona -fomit-frame-pointer -pipe -fno-ident -g -Wall -pedantic -Werror
-c freeglut_menu.c -MT libglut_la-freeglut_menu.lo -MD -MP -MF
.deps/libglut_la-freeglut_menu.TPlo  -fPIC -DPIC -o
.libs/libglut_la-freeglut_menu.lo
cc1: warnings being treated as errors
freeglut_joystick.c: In function 'fgJoystickDetect':
freeglut_joystick.c:1687: warning: the address of 'fgJoystick', will always
evaluate as 'true'
make[2]: *** [libglut_la-freeglut_joystick.lo] Error 1

attached is a patch to prevent this and other warnings from causing unnecessary
build failures.

------- Comment #1 From Ryan Hill 2006-04-30 19:07:14 0000 ------- 
Created an attachment (id=85893) [edit]
freeglut-2.4.0-warnings-arent-errors.patch

------- Comment #2 From Joshua Baergen (RETIRED) 2006-05-02 08:44:29 0000 ------- 
I'd rather fix the code than dropping Werror.  It'd probably take very little
effort.

------- Comment #3 From Donnie Berkholz 2006-06-20 23:11:32 0000 ------- 
Upping to critical since we're already on 4.1, 4.2 isn't too far off.

------- Comment #4 From Ryan Hill 2006-06-23 17:04:12 0000 ------- 
4.2 hasn't branched yet, and the final won't be released til ~3 months after
that, so we have some time yet. ;)

------- Comment #5 From Joshua Baergen (RETIRED) 2006-07-25 20:22:47 0000 ------- 
Created an attachment (id=92754) [edit]
freeglut-gcc42.patch

Don't check the pointer of a statically allocated structure.

------- Comment #6 From Joshua Baergen (RETIRED) 2006-07-25 20:23:12 0000 ------- 
Ryan, give that patch a try if you have a chance.

------- Comment #7 From Ryan Hill 2006-07-28 18:59:49 0000 ------- 
looks good.  (ebuild needs a cd ${S} in src_unpack to use as-is.)

------- Comment #8 From Joshua Baergen (RETIRED) 2006-07-29 11:04:40 0000 ------- 
Committed to CVS, thanks for testing.
First Last Prev Next    No search results available      Search page      Enter new bug