Bugzilla Bug 129616

Ebuild uses an older version of cbiere's patch.
http://www.ghostwhitecrab.com/generator/generator-0.35-cbiere-r2.tar.bz2 is the
current release. Changelog as follows:

2005-09-02

    * Moved inclusion of most system header files to hdr/generator.h and added
check for sys/param.h for less #include trouble.
    * Removed platform-specific versions of the SWAP16/SWAP32 macros as these
were only used in two places.

2005-08-29

    * Applied another patch by Henry Pr

Ebuild uses an older version of cbiere's patch.
http://www.ghostwhitecrab.com/generator/generator-0.35-cbiere-r2.tar.bz2 is the
current release. Changelog as follows:

2005-09-02

    * Moved inclusion of most system header files to hdr/generator.h and added
check for sys/param.h for less #include trouble.
    * Removed platform-specific versions of the SWAP16/SWAP32 macros as these
were only used in two places.

2005-08-29

    * Applied another patch by Henry Prêcheur to fix compile errors and
warnings using GCC 4.0.
    * Replaced strsep() for IRIX which doesn't provide this non-standard
function. Thanks to Daichi Kawahata.
    * Fixed all compiler warnings that were left over. As a side-effect some
unnecessary emulator code was eliminated. Generator should now compile cleanly
with "-W -Wall -Wformat=2" when using GCC.
    * Replaced all code which used snprintf() and removed the replacement
implementation of snprintf() because the few uses of it are better handled by
far less complex code. (Just in case: no snprintf() was replaced with
sprintf().)
    * Removed the GCC compiler flag -minline-all-stringops which was quite
unnecessary and is not available on all platforms. The GCC flag -ffast-math is
only used for x86 machines and for Alpha -mieee is added as a precaution by
default. Thanks to Alejandro.
    * Got rid of all C++ style comments for better compatibility with older C
compilers.

Thanks... ;]

The only ebuild modifications necessary to use "cbiere-r2" patch are to
$SRC_URI and $S

I'm noticing some weirdnesses that weren't there when I compiled myself, and it
appears that the configure switches are the problem. I'll test more soon.

0.35-r1, using both the original patch and the -r2, produces a QA notice:

QA Notice: the following files contain executable stacks
 Files with executable stacks will not work properly (or at all!)
 on some architectures/operating systems.  A bug should be filed
 at http://bugs.gentoo.org/ to make sure the file is fixed.
RWX --- --- usr/games/bin/generator-gtk

You probably want that in a seperate bug, right? ^_^

Definitely.  Even better would be a patch attached to that bug.

I don't speak assembler, but from what I've read I may be able to fix it
anyway. Bug 130539 is the new one. 

I wrote an updated ebuild, but am tearing my hair out over arrays in Bash. I
could use some help - it won't iterate over the for loop, why, why... *sob*

src_compile() {
        local myconf="--with-gcc=$(gcc-major-version) \
                --disable-dependency-tracking --with-sdl-audio"
        local mygui=
        local myguis=

        use x86 \
                && myconf="${myconf} --with-raze" \
                || myconf="${myconf} --with-cmz80"

        myguis="sdl"
        use gtk && myguis="gtk" [ -n "${myguis}" ]
        use svga && myguis="svgalib" [ -n "${myguis}" ]

        for mygui in ${myguis}; do
                [[ -f Makefile ]] && make -s clean
                egamesconf \
                        ${myconf} \
                        --with-${mygui} || die
                emake -j1 || die "building ${mygui}"
                mv main/generator-${mygui} my-bins/
        done
}

Created an attachment (id=85387) [edit]
generator-0.35-r2.ebuild

Nevermind on the last post! Attached is a working ebuild that builds multiple
targets including SDL (existing ebuild is non-working in that regard), and
removes old irrelevant seds. Added use flag to choose SDL as audio output,
which is slower for me but might be preferable to some. Defaults to /dev/dsp.
Tested both SDL and GTK versions on x86.

Created an attachment (id=97557) [edit]
generator-0.35-r3.ebuild

Here's an updated ebuild and patch, incorporating the execstacks fix and a few
other things.

Unfortunately, now I get a corrupted display with both this version and the -r2
version in portage. I have no idea if it's a newer version of SDL, the
execstacks patch, xorg7, or my video drivers that's causing this issue.

Created an attachment (id=97558) [edit]
generator-0.35-r3-execstacks.patch

It seems my display error was caused by an old or corrupt ~/.genrc (config)
file. So, no troubles now :)

Created an attachment (id=98733) [edit]
generator-0.35-r3.ebuild

Removed dependency on sed and cleaned it up a bit.

Added to portage... thanks for the ebuild and the patch!