First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 129360
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Common Lisp Bugs <common-lisp@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Nick Dimiduk (RETIRED) <ndimiduk@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
ppc-macos.diff ppc-macos patch patch Nick Dimiduk (RETIRED) 2006-04-09 09:13 0000 2.20 KB Details | Diff
ppc-macos.patch disabled sb-test as original patch Nick Dimiduk (RETIRED) 2006-04-14 10:41 0000 1.87 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 129360 depends on: Show dependency tree
Bug 129360 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-04-09 09:13 0000
Nothing significant needed to be done because there is now upstream support. 
However, due to issues related to `use ppc` evaluating to true on this arch and
related changes to the ebuild, it should be tested on a ppc-linux system. 
Attached is a patch to add ppc-macos support.  The ebuild is also available via
http in my darcs overlay at the indicated URI.

------- Comment #1 From Nick Dimiduk (RETIRED) 2006-04-09 09:13:50 0000 -------
Created an attachment (id=84288) [edit]
ppc-macos patch

As above.

------- Comment #2 From Wormo 2006-04-11 21:39:28 0000 -------
Seems ok to me. Successfully built with the patch, and used it to compile
maxima which also seems fine.

------- Comment #3 From Matthew Kennedy (RETIRED) 2006-04-11 23:33:51 0000 -------
wormo, do you mean to say that it worked on ppc linux or ppc-macos?

Nick, if it is found to work fine on both architectures, you should commit the
patch to CVS.  The only question I have about your patch is the last section:

@@ -91,7 +104,7 @@
 #      use x86 \
 #              && echo '(enable :sb-futex)' \
 #              >>${S}/customize-target-features.lisp
-       echo '(disable :sb-test)' >>${S}/customize-target-features.lisp
+#      echo '(disable :sb-test)' >>${S}/customize-target-features.lisp
        ! use unicode \
                && echo '(disable :sb-unicode)' \
                >>${S}/customize-target-features.lisp

That would affect all archs.  Is there any reason to exclude :sb-test from
customize-target-features? 

------- Comment #4 From Wormo 2006-04-13 11:04:24 0000 -------
Worked on ppc linux

------- Comment #5 From Nick Dimiduk (RETIRED) 2006-04-14 10:19:15 0000 -------
mkennedy:

That line will be uncommented for submission.  It's not necessary.  Why is
sb-test disabled by default?  Is it extra runtime type-checking or something? 
I enabled the test hoping for extra output while testing sbcl on ppc-macos.

------- Comment #6 From Nick Dimiduk (RETIRED) 2006-04-14 10:41:46 0000 -------
Created an attachment (id=84658) [edit]
disabled sb-test as original

Re-disabled sb-test.

------- Comment #7 From Matthew Kennedy (RETIRED) 2006-04-14 12:47:06 0000 -------
In the SBCL archive root directory base-target-features.lisp-expr:

 ;; Do regression and other tests when building the system. You might
 ;; or might not want this if you're not a developer, depending on how
 ;; paranoid you are. You probably do want it if you are a developer.
 ;; This test does not affect the target system (in much the same way
 ;; as :sb-after-xc-core, below).
 :sb-test

I can't remember what effect it had exactly, but disabling it for users is a
good idea.  I vaguely recall it avoids loading up *-test.asd system definitions
and that was a speedup.

I'll apply your latest patch when I get home.

------- Comment #8 From Matthew Kennedy (RETIRED) 2006-04-21 09:32:18 0000 -------
Nick, one more question about the patch:

    if use ppc-macos && use ldb; then
        true
    elif use ppc && use ldb; then
        sbcl_einfo <<'EOF'                                                      
Building SBCL on PPC with LDB support is not a supported configuration          
in Gentoo. Please refer to Bug #121830 for more information.                    
EOF                                                                             
        die
    fi

I'm not sure what the intention there is.  Does ldb really work on ppc-macos
but not on non-macos ppc?

------- Comment #9 From Matthew Kennedy (RETIRED) 2006-04-24 12:38:20 0000 -------
I dont think it does, so I adjusted that stanza slightly and committed to
portage.

------- Comment #10 From Nick Dimiduk (RETIRED) 2006-04-25 15:40:33 0000 -------
Sorry for the delay; I'm in the middle of moving.

I tried building sbcl with the ldb use flag enabled and encountered no
compilation errors as described in the associated bug mentioned in the ebuild
(#121830).  Hence, I left it as an available option in the patch.

First Last Prev Next    No search results available      Search page      Enter new bug