Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 128448 - Keyword x11-apps/xplsprinters
Summary: Keyword x11-apps/xplsprinters
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Other
: Highest normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: Inclusion
: 84261 130936 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-04-01 15:27 UTC by Canal Vorfeed
Modified: 2006-09-08 11:36 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xorg-server-1.0.2-r3.patch (xorg-server-1.0.2-r3.patch,1.50 KB, patch)
2006-04-13 22:31 UTC, Ed Catmur
Details | Diff
xorg-server-1.0.2-Xprt-build.patch (xorg-server-1.0.2-Xprt-build.patch,7.68 KB, patch)
2006-04-13 22:32 UTC, Ed Catmur
Details | Diff
xorg-server-1.0.2-xprint-init.patch (xorg-server-1.0.2-xprint-init.patch,417 bytes, patch)
2006-04-13 22:32 UTC, Ed Catmur
Details | Diff
xorg-server-1.0.2-r3.ebuild (xorg-server-1.0.2-r3.ebuild,5.53 KB, text/plain)
2006-04-13 22:33 UTC, Ed Catmur
Details
xorg-server-1.0.99.901-Xprint-xprintdir.patch (xorg-server-1.0.99.901-Xprint-xprintdir.patch,425 bytes, patch)
2006-04-21 06:46 UTC, Ed Catmur
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Canal Vorfeed 2006-04-01 15:27:33 UTC
Nothing strange in logs but after installation /usr/lib/misc/xprint has lines 

#ifdef OS_SOLARIS
#elif defined(OS_LINUX)
#endif

they are supposed to be handled by cpp preprocessor before actual install, right ?

And it does not try to look for encodings.dir file in /usr/share/fonts/encodings ...

Unfortunatelly I'm not familiar enough with modular X build to fix this bug...
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2006-04-02 16:30:13 UTC
Ed, any interest in fixing xprint?
Comment 2 Ed Catmur 2006-04-13 22:31:29 UTC
Created attachment 84604 [details, diff]
xorg-server-1.0.2-r3.patch

Ebuild patch.

The upstream bug for Xprint is https://bugs.freedesktop.org/show_bug.cgi?id=5525

This ebuild uses a modified version of the patch at that bug, and an patch to run the xprint.cpp file through the preprocessor in the way it should be.

Patches need autoreconf, so this ebuild sets SNAPSHOT. x11-apps/xplsprinters is added to DEPEND to ensure the profile scripts etc. work.
Comment 3 Ed Catmur 2006-04-13 22:32:22 UTC
Created attachment 84605 [details, diff]
xorg-server-1.0.2-Xprt-build.patch

Upstream patch to build Xprt properly
Comment 4 Ed Catmur 2006-04-13 22:32:57 UTC
Created attachment 84606 [details, diff]
xorg-server-1.0.2-xprint-init.patch

Patch to build init script
Comment 5 Ed Catmur 2006-04-13 22:33:27 UTC
Created attachment 84607 [details]
xorg-server-1.0.2-r3.ebuild

Ebuild (for testing).
Comment 6 Joshua Baergen (RETIRED) gentoo-dev 2006-04-16 14:59:03 UTC
(In reply to comment #2)
> This ebuild uses a modified version of the patch at that bug, and an patch to
> run the xprint.cpp file through the preprocessor in the way it should be.

How is it modified?
Comment 7 Donnie Berkholz (RETIRED) gentoo-dev 2006-04-16 16:26:04 UTC
*** Bug 84261 has been marked as a duplicate of this bug. ***
Comment 8 Ed Catmur 2006-04-17 14:09:17 UTC
(In reply to comment #6)
> (In reply to comment #2)
> > This ebuild uses a modified version of the patch at that bug, and an patch to
> > run the xprint.cpp file through the preprocessor in the way it should be.
> 
> How is it modified?

Pr
Comment 9 Ed Catmur 2006-04-17 14:09:17 UTC
(In reply to comment #6)
> (In reply to comment #2)
> > This ebuild uses a modified version of the patch at that bug, and an patch to
> > run the xprint.cpp file through the preprocessor in the way it should be.
> 
> How is it modified?

Précis of differences:

1. Xprint/Makefile.am: XPRINTDIR is defined to $(prefix)/lib/X11/xserver instead of $(prefix)/X11/xserver. Upstream has the latter, so this will need considering when next xorg-server release happens.
2. cfb/Makefile.am.inc: cfb8bit.c depends on compiler.h, not cfbmskbits.h. This is as upstream of 20060107. (Upstream now has cfb8bit.o instead for non-GNU make; see http://webcvs.freedesktop.org/xorg/xserver/xorg/cfb/Makefile.am.inc?r1=1.5&r2=1.6 )
3. Create Xprint/pcl-mono/Makefile.am and Xprint/pcl/Makefile.am.inc; evidently the patch submitter didn't know how to generate a file-creating diff.
Comment 10 Donnie Berkholz (RETIRED) gentoo-dev 2006-04-19 21:48:40 UTC
Ed, how much of this stuff is necessary for 1.0.99?
Comment 11 Donnie Berkholz (RETIRED) gentoo-dev 2006-04-19 22:26:17 UTC
Arch teams, please keyword x11-apps/xplsprinters.
Comment 12 Donnie Berkholz (RETIRED) gentoo-dev 2006-04-19 22:32:31 UTC
Please keyword.
Comment 13 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-04-19 22:47:53 UTC
Already taken care of for bsd if it's just xplsprinters.
Comment 14 Ed Catmur 2006-04-21 06:46:46 UTC
Created attachment 85108 [details, diff]
xorg-server-1.0.99.901-Xprint-xprintdir.patch

(In reply to comment #9)
> Ed, how much of this stuff is necessary for 1.0.99?
 
xorg-server-1.0.2-xprint-init.patch is still needed; it gets the xprint init script built correctly.
xorg-server-1.0.2-Xprt-build.patch is not needed.
This attached patch is needed; it fixes a mismatch between configure.ac and Xprint/Makefile.am (configure has xpconfigdir=$libdir/X11/xserver).
Comment 15 Donnie Berkholz (RETIRED) gentoo-dev 2006-04-23 14:21:31 UTC
Great, thanks. I've changed that patch a bit to use libdir instead, to work properly with multilib systems.
Comment 16 Donnie Berkholz (RETIRED) gentoo-dev 2006-04-23 15:31:38 UTC
I've committed everything except the xplsprinters add to RDEPEND, since it's not keyworded everywhere yet.
Comment 17 Guy Martin (RETIRED) gentoo-dev 2006-04-23 15:37:26 UTC
Done on hppa.
Comment 18 Donnie Berkholz (RETIRED) gentoo-dev 2006-04-23 15:40:51 UTC
*** Bug 130936 has been marked as a duplicate of this bug. ***
Comment 19 Donnie Berkholz (RETIRED) gentoo-dev 2006-06-20 22:49:58 UTC
Ping alpha, amd64, ia64, xprint is broken on your archs.
Comment 20 Daniel Gryniewicz (RETIRED) gentoo-dev 2006-06-21 10:58:59 UTC
amd64 done
Comment 21 Donnie Berkholz (RETIRED) gentoo-dev 2006-07-14 11:44:39 UTC
Alpha, waiting on you ...
Comment 22 Donnie Berkholz (RETIRED) gentoo-dev 2006-07-31 13:08:03 UTC
(In reply to comment #20)
> Alpha, waiting on you ...
> 

Still..
Comment 23 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-05 16:22:49 UTC
Alpha team, ping.
Comment 24 Thomas Cort (RETIRED) gentoo-dev 2006-09-08 10:52:49 UTC
added ~alpha.
Comment 25 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-08 11:36:01 UTC
Fixed, finally.