Bug 128252 – links-2.1_pre20 USE logic is duff / breaks non-interactivity

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Gustavo Zacarias (RETIRED) 2006-03-31 07:00:52 UTC]

links-2.1_pre20 can't be built with with fbcon+gpm without png since the ebuild dies.
This affects livecd builds since we usually USE="-*" and add up just the basic needs. libpng should be added to the deps for fbcon and be done with it instead of dying.

[Comment 1 Gustavo Zacarias (RETIRED) 2006-03-31 07:06:45 UTC]

Seems you're missing jpeg too in there...

[Comment 2 Marcelo Goes (RETIRED) 2006-03-31 10:47:02 UTC]

Created attachment 83532 [details, diff]
links-2.1_pre20.ebuild.diff

Hi,

Should this fix all you need?

Marcelo

[Comment 3 Gustavo Zacarias (RETIRED) 2006-04-01 04:01:05 UTC]

It's a step in the right direction but you're still doing it for X? and gpm?

[Comment 4 Marcelo Goes (RETIRED) 2006-04-01 06:11:44 UTC]

Created attachment 83616 [details, diff]
links-2.1_pre20.ebuild.diff

I suppose you mean X and svga?

Anyway, this patch gets rid of pkg_setup(). I suppose libpng is a common enough component that anyway using X or svga will want it anyway, so it should be ok to kill pkg_setup() and add them to X? and svga? DEPEND.

Is this correct now?

[Comment 5 Marcelo Goes (RETIRED) 2006-04-01 06:12:47 UTC]

(In reply to comment #4)
> component that anyway using X or svga will want it anyway

... that anyONE using X or svga...

[Comment 6 Gustavo Zacarias (RETIRED) 2006-04-05 05:51:42 UTC]

Sorry for the delay in getting back.
Yeah looks good now.

[Comment 7 Marcelo Goes (RETIRED) 2006-04-05 08:02:32 UTC]

Thanks, in cvs.