Bugzilla Bug 127917

Hi,

it seems that you use the compression patch from:
http://sourceforge.net/tracker/index.php?func=detail&aid=895531&group_id=11118&atid=311118
Bug 83278 (no direct copy though)

The patch uses heavily '#ifdef FEATURE_ZLIB' but the ebuild does not enable it
(--enable-zlib). Thus the patch has just one effect:
Privoxy now sends the Accept-Encoding html-header (with -prevent-compression in
default.action) and can't decode the answer. And because of this, privoxy can't
filter compressed pages any more (e.g. google) - without any error message,
btw.

If you --enable-zlib, you notice some compile errors introduced by your patch.
An attached patch fixes this. But this is just a quick fix. I did not do a full
review of this compression patch (either your or the original version).

Because of this, I don't think that it is a good idea to enable this
experimental patch by default in this ebuild. Privoxy 3.0.3 should be a stable
version.

Regards
Georg Sauthoff

Created an attachment (id=83334) [edit]
quick fix

Created an attachment (id=83336) [edit]
zlib patch

Please try this patch, along with --enable-zlib in configure command line of
course. It passed the google test with success.

I plan to conditionally apply it in -r4, depending on the zlib flag. This
feature is too good to loose it.

fixed in -r4.
thanks for spotting this error!

Hi,

you're welcome. But one small thing:

I looked at -r4:
'epatch "${FILESDIR}/${P}-zlib.patch"'
should depend on the zlib useflag, too. Else the user with useflag -zlib gets
the entry '-prevent-compression' in his config and the mainly disabled patch at
compile time. Thus, again compressed pages are unfiltered.

Regards
Georg Sauthoff

ok, fixed in -r5.